admin/raven
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean up migrate_outstanding stuff

Browse Source
This commit is contained in:
John Cardinal
2022-03-18 14:31:20 +00:00
parent 4fe4bc1ebb
commit 36dbeb1541
3 changed files with 13 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
devdocs/todo.txt
View File

@@ -1,10 +1,8 @@
“Accept the things to which fate binds you, and love the people with whom fate brings you together,but do so with all your heart.”
― Marcus Aurelius, Meditations
"Make it happen"
- Jim July 28th 2021
# now
trialing plan for setting up server, do we charge? how much, what questions do we need answered to set up droplet
can a site be in a sufolder so I don't need a domain name or key, just hang them all off helloayanova.com/s/siteb?
proxy if path?
@@ -12,7 +10,7 @@
# OUTSTANDING BEFORE RELEASE
docs: default nginx config missing large file upload settings possibly other things compare to devops one
#1 items below in each category, some #2 as well
todo: test with licensed key to ensure evaluate is gone and everything works logging in as each user to regular home page
@@ -135,6 +133,7 @@ todo:2 subscribe to all sources of security vulnerabilities that could apply to
██████╔╝╚██████╔╝╚██████╗╚██████╔╝██║ ╚═╝ ██║███████╗██║ ╚████║ ██║ ██║ ██║ ██║ ██║╚██████╔╝██║ ╚████║
╚═════╝ ╚═════╝ ╚═════╝ ╚═════╝ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝ ╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═════╝ ╚═╝ ╚═══╝
1: proper nginx config to allow large uploads etc copy from devops
@@ -404,6 +403,8 @@ https://community.letsencrypt.org/t/create-certs-for-different-machines/107091/1
todo: 2 test notification sent from ops notification settings form should include a link so can test that the link back url is working
todo: 3 noticed when didn't give sufficient rights to .chromium whatever folder at linux server that got weird error reporting as it couldn't download chromium on first boo, sb a proper error, only way I noticed was no files in chromium folder
todo: 2 AyaNova is not logged an event when a serial number is reset but ther is an event type for that purpose
I'm not certain if this is related to editing an object to change the serial or the seed being changed
When this is coded add it to the documentation at adm-history.md
@@ -766,6 +767,10 @@ client: Total : 295 files, 112234 codes, 6586 comments, 5547 blanks, all 124367
“Accept the things to which fate binds you, and love the people with whom fate brings you together,but do so with all your heart.”
― Marcus Aurelius, Meditations
"Make it happen"
- Jim July 28th 2021

50
server/AyaNova/Controllers/CustomerServiceRequestController.cs
View File

@@ -127,55 +127,7 @@ namespace AyaNova.Api.Controllers
return NoContent();
}
// /// <summary>
// /// Reject CustomerServiceRequest
// /// </summary>
// /// <param name="id">Source object id</param>
// /// <param name="apiVersion">From route path</param>
// /// <returns>CustomerServiceRequest</returns>
// [HttpPost("reject/{id}")]
// public async Task<IActionResult> RejectCustomerServiceRequest([FromRoute] long id, ApiVersion apiVersion)
// {
// if (!serverState.IsOpen)
// return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
// CustomerServiceRequestBiz biz = CustomerServiceRequestBiz.GetBiz(ct, HttpContext);
// if (!Authorized.HasCreateRole(HttpContext.Items, biz.BizType))
// return StatusCode(403, new ApiNotAuthorizedResponse());
// if (!ModelState.IsValid)
// return BadRequest(new ApiErrorResponse(ModelState));
// CustomerServiceRequest o = await biz.RejectAsync(id);
// if (o == null)
// return BadRequest(new ApiErrorResponse(biz.Errors));
// else
// return CreatedAtAction(nameof(CustomerServiceRequestController.GetCustomerServiceRequest), new { id = o.Id, version = apiVersion.ToString() }, new ApiCreatedResponse(o));
// }
// /// <summary>
// /// Accept CustomerServiceRequest to new WorkOrder
// /// </summary>
// /// <param name="id">Source CSR id</param>
// /// <param name="apiVersion">From route path</param>
// /// <returns>CustomerServiceRequest with WorkOrderItemId set</returns>
// [HttpPost("accept/{id}/{workorderid}")]
// public async Task<IActionResult> AcceptCustomerServiceRequest([FromRoute] long id, ApiVersion apiVersion)
// {
// if (!serverState.IsOpen)
// return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
// CustomerServiceRequestBiz biz = CustomerServiceRequestBiz.GetBiz(ct, HttpContext);
// if (!Authorized.HasCreateRole(HttpContext.Items, biz.BizType))
// return StatusCode(403, new ApiNotAuthorizedResponse());
// if (!ModelState.IsValid)
// return BadRequest(new ApiErrorResponse(ModelState));
// CustomerServiceRequest o = await biz.AcceptAsync(id);
// if (o == null)
// return BadRequest(new ApiErrorResponse(biz.Errors));
// else
// return CreatedAtAction(nameof(CustomerServiceRequestController.GetCustomerServiceRequest), new { id = o.Id, version = apiVersion.ToString() }, new ApiCreatedResponse(o));
// }
//------------

39
server/AyaNova/biz/CustomerServiceRequestBiz.cs
View File

@@ -153,45 +153,6 @@ namespace AyaNova.Biz
// ////////////////////////////////////////////////////////////////////////////////////////////////
// //ACCEPT
// //
// internal async Task<CustomerServiceRequest> AcceptAsync(long csrId, long workorderId) //MIGRATE_OUTSTANDING waiting for workorder to be completed or at least have a customerid which it currently doesn't
// {
// var dbObject = await GetAsync(csrId, false);
// if (dbObject == null)
// {
// AddError(ApiErrorCode.NOT_FOUND, "id");
// return null;
// }
// throw new System.NotImplementedException("//MIGRATE_OUTSTANDING CustomerServiceRequestBiz::AcceptAsync - awaiting workorder completion ");
// // WorkOrder w=null;
// //if (workorderId==0){WorkOrderBiz.GenerateWorkOrder()} //this is how it would work in theory
// }
// ////////////////////////////////////////////////////////////////////////////////////////////////
// //REJECT
// //
// internal async Task<CustomerServiceRequest> RejectAsync(long csrId)
// {
// var dbObject = await GetAsync(csrId, false);
// if (dbObject == null)
// {
// AddError(ApiErrorCode.NOT_FOUND, "id");
// return null;
// }
// //Nothing to validate as it just came from the db and rejecting doesn't require validation
// dbObject.Status = CustomerServiceRequestStatus.Declined;
// await PutAsync(dbObject);
// return dbObject;
// }
////////////////////////////////////////////////////////////////////////////////////////////////
//SEARCH