From 36dbeb1541cd4db3cb83aaf9b9b2e24051ddf765 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Fri, 18 Mar 2022 14:31:20 +0000 Subject: [PATCH] clean up migrate_outstanding stuff --- devdocs/todo.txt | 19 ++++--- .../CustomerServiceRequestController.cs | 50 +------------------ .../AyaNova/biz/CustomerServiceRequestBiz.cs | 39 --------------- 3 files changed, 13 insertions(+), 95 deletions(-) diff --git a/devdocs/todo.txt b/devdocs/todo.txt index 296c9f76..089dd2f4 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -1,10 +1,8 @@ - “Accept the things to which fate binds you, and love the people with whom fate brings you together,but do so with all your heart.” - ― Marcus Aurelius, Meditations -"Make it happen" - - Jim July 28th 2021 - - +# now +trialing plan for setting up server, do we charge? how much, what questions do we need answered to set up droplet +can a site be in a sufolder so I don't need a domain name or key, just hang them all off helloayanova.com/s/siteb? + proxy if path? @@ -12,7 +10,7 @@ # OUTSTANDING BEFORE RELEASE -docs: default nginx config missing large file upload settings possibly other things compare to devops one +#1 items below in each category, some #2 as well todo: test with licensed key to ensure evaluate is gone and everything works logging in as each user to regular home page @@ -135,6 +133,7 @@ todo:2 subscribe to all sources of security vulnerabilities that could apply to ██████╔╝╚██████╔╝╚██████╗╚██████╔╝██║ ╚═╝ ██║███████╗██║ ╚████║ ██║ ██║ ██║ ██║ ██║╚██████╔╝██║ ╚████║ ╚═════╝ ╚═════╝ ╚═════╝ ╚═════╝ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝ ╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═════╝ ╚═╝ ╚═══╝ +1: proper nginx config to allow large uploads etc copy from devops @@ -404,6 +403,8 @@ https://community.letsencrypt.org/t/create-certs-for-different-machines/107091/1 todo: 2 test notification sent from ops notification settings form should include a link so can test that the link back url is working +todo: 3 noticed when didn't give sufficient rights to .chromium whatever folder at linux server that got weird error reporting as it couldn't download chromium on first boo, sb a proper error, only way I noticed was no files in chromium folder + todo: 2 AyaNova is not logged an event when a serial number is reset but ther is an event type for that purpose I'm not certain if this is related to editing an object to change the serial or the seed being changed When this is coded add it to the documentation at adm-history.md @@ -766,6 +767,10 @@ client: Total : 295 files, 112234 codes, 6586 comments, 5547 blanks, all 124367 + “Accept the things to which fate binds you, and love the people with whom fate brings you together,but do so with all your heart.” + ― Marcus Aurelius, Meditations +"Make it happen" + - Jim July 28th 2021 diff --git a/server/AyaNova/Controllers/CustomerServiceRequestController.cs b/server/AyaNova/Controllers/CustomerServiceRequestController.cs index a7a8c70f..a90527c5 100644 --- a/server/AyaNova/Controllers/CustomerServiceRequestController.cs +++ b/server/AyaNova/Controllers/CustomerServiceRequestController.cs @@ -127,55 +127,7 @@ namespace AyaNova.Api.Controllers return NoContent(); } - - // /// - // /// Reject CustomerServiceRequest - // /// - // /// Source object id - // /// From route path - // /// CustomerServiceRequest - // [HttpPost("reject/{id}")] - // public async Task RejectCustomerServiceRequest([FromRoute] long id, ApiVersion apiVersion) - // { - // if (!serverState.IsOpen) - // return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason)); - // CustomerServiceRequestBiz biz = CustomerServiceRequestBiz.GetBiz(ct, HttpContext); - // if (!Authorized.HasCreateRole(HttpContext.Items, biz.BizType)) - // return StatusCode(403, new ApiNotAuthorizedResponse()); - // if (!ModelState.IsValid) - // return BadRequest(new ApiErrorResponse(ModelState)); - // CustomerServiceRequest o = await biz.RejectAsync(id); - // if (o == null) - // return BadRequest(new ApiErrorResponse(biz.Errors)); - // else - // return CreatedAtAction(nameof(CustomerServiceRequestController.GetCustomerServiceRequest), new { id = o.Id, version = apiVersion.ToString() }, new ApiCreatedResponse(o)); - // } - - // /// - // /// Accept CustomerServiceRequest to new WorkOrder - // /// - // /// Source CSR id - // /// From route path - // /// CustomerServiceRequest with WorkOrderItemId set - // [HttpPost("accept/{id}/{workorderid}")] - // public async Task AcceptCustomerServiceRequest([FromRoute] long id, ApiVersion apiVersion) - // { - // if (!serverState.IsOpen) - // return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason)); - // CustomerServiceRequestBiz biz = CustomerServiceRequestBiz.GetBiz(ct, HttpContext); - // if (!Authorized.HasCreateRole(HttpContext.Items, biz.BizType)) - // return StatusCode(403, new ApiNotAuthorizedResponse()); - // if (!ModelState.IsValid) - // return BadRequest(new ApiErrorResponse(ModelState)); - // CustomerServiceRequest o = await biz.AcceptAsync(id); - // if (o == null) - // return BadRequest(new ApiErrorResponse(biz.Errors)); - // else - // return CreatedAtAction(nameof(CustomerServiceRequestController.GetCustomerServiceRequest), new { id = o.Id, version = apiVersion.ToString() }, new ApiCreatedResponse(o)); - // } - - - + //------------ diff --git a/server/AyaNova/biz/CustomerServiceRequestBiz.cs b/server/AyaNova/biz/CustomerServiceRequestBiz.cs index 38ac746d..2282b5ec 100644 --- a/server/AyaNova/biz/CustomerServiceRequestBiz.cs +++ b/server/AyaNova/biz/CustomerServiceRequestBiz.cs @@ -153,45 +153,6 @@ namespace AyaNova.Biz - // //////////////////////////////////////////////////////////////////////////////////////////////// - // //ACCEPT - // // - // internal async Task AcceptAsync(long csrId, long workorderId) //MIGRATE_OUTSTANDING waiting for workorder to be completed or at least have a customerid which it currently doesn't - // { - // var dbObject = await GetAsync(csrId, false); - // if (dbObject == null) - // { - // AddError(ApiErrorCode.NOT_FOUND, "id"); - // return null; - // } - - // throw new System.NotImplementedException("//MIGRATE_OUTSTANDING CustomerServiceRequestBiz::AcceptAsync - awaiting workorder completion "); - // // WorkOrder w=null; - // //if (workorderId==0){WorkOrderBiz.GenerateWorkOrder()} //this is how it would work in theory - - - - // } - - // //////////////////////////////////////////////////////////////////////////////////////////////// - // //REJECT - // // - // internal async Task RejectAsync(long csrId) - // { - // var dbObject = await GetAsync(csrId, false); - // if (dbObject == null) - // { - // AddError(ApiErrorCode.NOT_FOUND, "id"); - // return null; - // } - - // //Nothing to validate as it just came from the db and rejecting doesn't require validation - // dbObject.Status = CustomerServiceRequestStatus.Declined; - // await PutAsync(dbObject); - // return dbObject; - // } - - //////////////////////////////////////////////////////////////////////////////////////////////// //SEARCH