This commit is contained in:
@@ -56,20 +56,14 @@ todo: Attachments button should indicate attachments:
|
||||
|
||||
|
||||
## SERVER MISC ITEMS
|
||||
|
||||
** IMPORTANT todo: double check concurrency code with Customer or Project just to be sure, it has been changed but not sure if it was ever properly tested.
|
||||
This bit is concerning in controller:
|
||||
if (biz.Errors.Exists(z => z.Code == ApiErrorCode.CONCURRENCY_CONFLICT))
|
||||
return StatusCode(409, new ApiErrorResponse(biz.Errors));
|
||||
else
|
||||
return BadRequest(new ApiErrorResponse(biz.Errors));
|
||||
And the new ct.Replace(dbObject, putObject); being used in put*biz is also concerning
|
||||
in the old code it would specifically have to set the concurrency value
|
||||
Need to thoroughly check it's working as it should
|
||||
|
||||
todo: It's in need of tweaking: changes made to widgetbiz putasync method to replicate to all others
|
||||
todo: PUTASYNC all biz objects CONCURRENCY ISSUE It's in need of tweaking: changes made to widgetbiz putasync method to replicate to all others
|
||||
first of all it needs to return the putObject, not the dbObject otherwise the concurrency is outdated
|
||||
secondly, it needs to check the concurrency token as a validation issue, the db doesn't do it, it doesn't care what it is
|
||||
todo: many biz objects are not using new PUT methodology
|
||||
Might be because new methodology assumes complete PUT object as a entire replacement not a partial update
|
||||
some of these objects (User) do partial updates so....
|
||||
also this includes *all* of the initial workorder object so there's that
|
||||
might be that they don't need it but for consistency should check into it
|
||||
|
||||
|
||||
todo: userbiz validate can delete has funky error
|
||||
|
||||
Reference in New Issue
Block a user