This commit is contained in:
2021-02-09 19:47:04 +00:00
parent 42cfddbc6e
commit b8fb9edba8
4 changed files with 27 additions and 21 deletions

View File

@@ -9,8 +9,14 @@ MISC ITEMS THAT CAME UP
## CLIENT MISC ITEMS
todo: check timeout algorithm for notification checking, when server is down it seems to top out at 10 minutes delay, but that seems short if the server is down all night and it's checking constantly or something
todo: ClientNote form link back to customer disappears on save of NEW record only (not update), should always be present
todo: validation errors not expanded in errorbox,
for example saving a widget with same name results in proper display at name field but in error box says:
Validation error
ErrorAPI2200
I expect it to say the full errorapi2200 bit or simply "Validation error"
or, maybe it's ok as is?
todo: clicking into a decimal field with zero in it already and then clicking out causes the record to be dirty
see tax-code for example
todo: standardize routes and route names and form names
@@ -61,6 +67,11 @@ todo: Attachments button should indicate attachments:
in the old code it would specifically have to set the concurrency value
Need to thoroughly check it's working as it should
todo: It's in need of tweaking: changes made to widgetbiz putasync method to replicate to all others
first of all it needs to return the putObject, not the dbObject otherwise the concurrency is outdated
secondly, it needs to check the concurrency token as a validation issue, the db doesn't do it, it doesn't care what it is
todo: userbiz validate can delete has funky error
todo: bugbug filter on a phone number field results in error at server as unsupported type
make sure all types are supported

View File

@@ -1,11 +1,6 @@
/* xeslint-disable */
let keepChecking = false;
const DEFAULT_POLLING_INTERVAL = 60000;
//const DEFAULT_POLLING_INTERVAL = 5000;
const MAX_POLLING_INTERVAL = 10 * 60 * 1000; //10 minutes maximum wait time
const MAX_POLLING_INTERVAL = 30 * 60 * 1000; //30 minutes maximum wait time
export default {
async startPolling() {
if (keepChecking == true) {

View File

@@ -5,7 +5,7 @@
<v-form ref="form" v-if="formState.ready">
<v-row>
<gz-error :errorBoxMessage="formState.errorBoxMessage"></gz-error>
<gz-error :error-box-message="formState.errorBoxMessage"></gz-error>
<v-col cols="12" v-if="customername">
<v-btn @click="goToCustomer"> {{ customername }}</v-btn>
</v-col>
@@ -40,7 +40,7 @@
v-model="obj.noteDate"
:readonly="formState.readOnly"
ref="noteDate"
testId="noteDate"
test-id="noteDate"
:error-messages="form().serverErrors(this, 'noteDate')"
@input="fieldValueChanged('noteDate')"
></gz-date-time-picker>

View File

@@ -1,12 +1,12 @@
<template>
<div>
<gz-report-selector ref="reportSelector"></gz-report-selector>
{{ obj.concurrency }}
<v-row v-if="formState.ready">
<v-col>
<v-form ref="form">
<v-row>
<gz-error :errorBoxMessage="formState.errorBoxMessage"></gz-error>
<gz-error :error-box-message="formState.errorBoxMessage"></gz-error>
<v-col cols="12" sm="6" lg="4" xl="3">
<v-text-field
v-model="obj.name"
@@ -84,7 +84,7 @@
v-model="obj.startDate"
:readonly="formState.readOnly"
ref="startDate"
testId="startDate"
test-id="startDate"
:error-messages="form().serverErrors(this, 'startDate')"
@input="fieldValueChanged('startDate')"
></gz-date-time-picker>
@@ -98,7 +98,7 @@
v-model="obj.endDate"
:readonly="formState.readOnly"
ref="endDate"
testId="endDate"
test-id="endDate"
@input="fieldValueChanged('endDate')"
></gz-date-time-picker>
</v-col>
@@ -111,8 +111,8 @@
xl="3"
>
<gz-pick-list
:ayaType="ayaTypes().User"
:showEditIcon="true"
:aya-type="ayaTypes().User"
:show-edit-icon="true"
v-model="obj.userId"
:readonly="formState.readOnly"
:label="$ay.t('User')"
@@ -184,9 +184,9 @@
<v-col cols="12">
<gz-custom-fields
v-model="obj.customFields"
:formKey="formCustomTemplateKey"
:form-key="formCustomTemplateKey"
:readonly="formState.readOnly"
:parentVM="this"
:parent-v-m="this"
ref="customFields"
data-cy="customFields"
:error-messages="form().serverErrors(this, 'customFields')"
@@ -196,8 +196,8 @@
<v-col v-if="form().showMe(this, 'Wiki')" cols="12">
<gz-wiki
:ayaType="ayaType"
:ayaId="obj.id"
:aya-type="ayaType"
:aya-id="obj.id"
ref="wiki"
v-model="obj.wiki"
:readonly="formState.readOnly"
@@ -211,8 +211,8 @@
>
<gz-attachments
:readonly="formState.readOnly"
:ayaType="ayaType"
:ayaId="obj.id"
:aya-type="ayaType"
:aya-id="obj.id"
></gz-attachments
></v-col>
</v-row>