admin/raven
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Browse Source
This commit is contained in:
John Cardinal
2020-05-07 19:34:43 +00:00
parent 9143fcd7be
commit f15ef1d775
2 changed files with 43 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
devdocs/todo.txt
View File

@@ -17,7 +17,9 @@ todo: search tables in schema, I think there is a missing index here, need to lo
API REFACTORING (note: workordercontroller / biz should be following all these rules so it's the template if need reference)
todo: all api route parameters, post object sb "newObject", put="updatedObject"
IN BIZ TOO
todo: all api routes, re-arrange code in controller in this order POST (and postlike such as duplicate), GET, PUT, DELETE for consistency and logicality
BIZ TOO
todo: all api route URI's sb lower case with dashes if necessary (use plural noun scheme)
https://docs.microsoft.com/en-us/azure/architecture/best-practices/api-design#organize-the-api-around-resources
todo: Controllers should not need to know about databases
@@ -25,7 +27,7 @@ todo: Controllers should not need to know about databases
todo: Routes should check rights *BEFORE* they fetch the object, not after, all routes affected
i.e. delete route instantiates biz object, then it fetchs object from db *then* it checks if they have rights to delete (generically, not specific to that object)
This is out of order as it triggers a db call even if they have no rights to do it
todo: all biz objects "ExistsAsync" is this required / necessary?
todo: log failed
- Download attempts with wrong key

77
server/AyaNova/biz/WorkOrderBiz.cs
View File

@@ -40,40 +40,7 @@ namespace AyaNova.Biz
return await ct.WorkOrder.AnyAsync(e => e.Id == id);
}
////////////////////////////////////////////////////////////////////////////////////////////////
/// GET
///
///
internal async Task<WorkOrder> GetAsync(long fetchId, bool logTheGetEvent = true)
{
/*
https://docs.microsoft.com/en-us/ef/core/querying/related-data
using (var context = new BloggingContext())
{
var blogs = context.Blogs
.Include(blog => blog.Posts)
.ThenInclude(post => post.Author)
.ThenInclude(author => author.Photo)
.ToList();
}
WARNING: Since version 3.0.0, each Include will cause an additional JOIN to be added to SQL queries produced by relational providers, whereas previous versions generated additional SQL queries. This can significantly change the performance of your queries, for better or worse. In particular, LINQ queries with an exceedingly high number of Include operators may need to be broken down into multiple separate LINQ queries in order to avoid the cartesian explosion problem.
*/
//This is simple so nothing more here, but often will be copying to a different output object or some other ops
//var ret = await ct.WorkOrder.SingleOrDefaultAsync(m => m.Id == fetchId);
var ret = await ct.WorkOrder.Include(w => w.WorkorderItems).SingleOrDefaultAsync(m => m.Id == fetchId);
if (logTheGetEvent && ret != null)
{
//Log
await EventLogProcessor.LogEventToDatabaseAsync(new Event(UserId, fetchId, BizType, AyaEvent.Retrieved), ct);
}
return ret;
}
////////////////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////////////////////////////////////////////////////////////////////
//CREATE
//TODO: Modify this to expect a workorder object like most POST routes for other objects
@@ -81,15 +48,15 @@ WARNING: Since version 3.0.0, each Include will cause an additional JOIN to be a
//Called from route and also seeder
internal async Task<WorkOrder> CreateAsync(WorkOrder inObj)
internal async Task<WorkOrder> CreateAsync(WorkOrder newObject)
{
await ValidateAsync(inObj, null);
await ValidateAsync(newObject, null);
if (HasErrors)
return null;
else
{
//do stuff with widget
WorkOrder outObj = inObj;
WorkOrder outObj = newObject;
//Test get serial id visible id number from generator
outObj.Serial = ServerBootConfig.WORKORDER_SERIAL.GetNext();
@@ -186,6 +153,42 @@ WARNING: Since version 3.0.0, each Include will cause an additional JOIN to be a
}
////////////////////////////////////////////////////////////////////////////////////////////////
/// GET
///
///
internal async Task<WorkOrder> GetAsync(long fetchId, bool logTheGetEvent = true)
{
/*
https://docs.microsoft.com/en-us/ef/core/querying/related-data
using (var context = new BloggingContext())
{
var blogs = context.Blogs
.Include(blog => blog.Posts)
.ThenInclude(post => post.Author)
.ThenInclude(author => author.Photo)
.ToList();
}
WARNING: Since version 3.0.0, each Include will cause an additional JOIN to be added to SQL queries produced by relational providers, whereas previous versions generated additional SQL queries. This can significantly change the performance of your queries, for better or worse. In particular, LINQ queries with an exceedingly high number of Include operators may need to be broken down into multiple separate LINQ queries in order to avoid the cartesian explosion problem.
*/
//This is simple so nothing more here, but often will be copying to a different output object or some other ops
//var ret = await ct.WorkOrder.SingleOrDefaultAsync(m => m.Id == fetchId);
var ret = await ct.WorkOrder.Include(w => w.WorkorderItems).SingleOrDefaultAsync(m => m.Id == fetchId);
if (logTheGetEvent && ret != null)
{
//Log
await EventLogProcessor.LogEventToDatabaseAsync(new Event(UserId, fetchId, BizType, AyaEvent.Retrieved), ct);
}
return ret;
}
////////////////////////////////////////////////////////////////////////////////////////////////
//UPDATE
//