admin/raven
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Browse Source
This commit is contained in:
John Cardinal
2023-10-26 23:42:32 +00:00
parent d5caad81b0
commit ce1e3f2b68
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/AyaNova/biz/ReportBiz.cs
View File

@@ -451,7 +451,6 @@ namespace AyaNova.Biz
await JobsBiz.UpdateJobStatusAsync(job.GId, JobStatus.Running); await JobsBiz.UpdateJobStatusAsync(job.GId, JobStatus.Running);
ReportRenderManager.AddJob(job.GId, log); ReportRenderManager.AddJob(job.GId, log);
// await JobsBiz.LogJobAsync(job.GId, $"LT:StartJob {job.JobType}");
//rehydrate job objects //rehydrate job objects
log.LogDebug($"Start; rehydrate job {job.Name}"); log.LogDebug($"Start; rehydrate job {job.Name}");
@@ -571,6 +570,11 @@ namespace AyaNova.Biz
//API DOCS http://www.puppeteersharp.com/api/index.html //API DOCS http://www.puppeteersharp.com/api/index.html
log.LogDebug($"Launching headless Browser and new page now:"); log.LogDebug($"Launching headless Browser and new page now:");
//bugbug: if browser fails to launch return error to user is not expected format json but text instead as there is no handling here
//this should be wrapped in an outer try block that handles browser failing to launch and returns clean error object JSON formatted
//and explaining server error see server error log with some indicative text like "render engine failed to launch"
//i.e. intentionally without the word browser to not confuse the user
using (var browser = await Puppeteer.LaunchAsync(lo)) using (var browser = await Puppeteer.LaunchAsync(lo))
using (var page = (await browser.PagesAsync())[0]) using (var page = (await browser.PagesAsync())[0])
{ {