diff --git a/server/AyaNova/biz/ReportBiz.cs b/server/AyaNova/biz/ReportBiz.cs index eaed6ab3..cb495899 100644 --- a/server/AyaNova/biz/ReportBiz.cs +++ b/server/AyaNova/biz/ReportBiz.cs @@ -451,7 +451,6 @@ namespace AyaNova.Biz await JobsBiz.UpdateJobStatusAsync(job.GId, JobStatus.Running); ReportRenderManager.AddJob(job.GId, log); - // await JobsBiz.LogJobAsync(job.GId, $"LT:StartJob {job.JobType}"); //rehydrate job objects log.LogDebug($"Start; rehydrate job {job.Name}"); @@ -571,6 +570,11 @@ namespace AyaNova.Biz //API DOCS http://www.puppeteersharp.com/api/index.html log.LogDebug($"Launching headless Browser and new page now:"); + //bugbug: if browser fails to launch return error to user is not expected format json but text instead as there is no handling here + //this should be wrapped in an outer try block that handles browser failing to launch and returns clean error object JSON formatted + //and explaining server error see server error log with some indicative text like "render engine failed to launch" + //i.e. intentionally without the word browser to not confuse the user + using (var browser = await Puppeteer.LaunchAsync(lo)) using (var page = (await browser.PagesAsync())[0]) {