server/AyaNova/biz/NotifyEventProcessor.cs

@@ -61,6 +61,7 @@ namespace AyaNova.Biz
                     //this will likely be a development error, not a production error so no need to log etc
                     throw new System.ArgumentException("NotifyEventProcessor:AddGeneralNotifyEvent: DefaultNotification requires a user id but none was specified");
                 }
+                //create in app
                 NotifyEvent n=new NotifyEvent(){EventType=eventType,UserId=userId, Message=message}
 
                 return;

server/AyaNova/generator/CoreJobNotify.cs

@@ -46,6 +46,15 @@ namespace AyaNova.Biz
                 {
                     //select all jobs with no deliver date or deliver date no longer in future
 
+                    //IMPLEMENTATION NOTES:  This code
+                    // finds the events in NotifyEvent
+                    // check subscription to determine if the age related ones are deliverable now
+                    // check subscriptions for each delivery type, i.e. there might be both smtp and inapp separately for the same event so it needs to know that and deliver accordingly
+                    // remove the notify event after it's processed
+
+
+
+                    //Older notes:
                     //### PLAN if it's an smtp delivery that fails and it's to someone who can be delivered in app then it should send an inapp notification of 
                     //delivery failure and still delete the smtp delivery
                     //If it's not possible to notify the person via in app of the failed smtp then perhaps it notifies OPS personnel and biz admin personnel