admin/raven-client
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Browse Source
This commit is contained in:
John Cardinal
2021-07-22 17:48:51 +00:00
parent 4ff6e6e7b5
commit e7ce4f98fc
1 changed files with 118 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

194
ayanova/devdocs/todo.txt
View File

@@ -31,22 +31,30 @@ Sept 1st
## MISC ITEMS THAT CAME UP
Coded by importance
1 means definitely right away
2 means definitely later after 1'sales
3 means nice to have but not sure or not urgent may even remove
## E2E TESTING
## V8MIGRATE
todo: Need a way to diagnose fail to migrate for remote user's db, there will be a lot of initial issues importing for people until we hit all the edge cases so...
todo:1 Add a "tag with" field that defaults to v7-import in the migrator UI selections so that users can set what they want or clear it entirely
todo:1 Need a way to diagnose fail to migrate for remote user's db, there will be a lot of initial issues importing for people until we hit all the edge cases so...
any fail of migration of an item of any kind needs to log the full object being attempted to save
we need enough info to figure out what went wrong without needing to see the entire db
exception handler should log full object being sent over the wire on fail
Also a separate plan is to have it log to v8 so we can then login to v8 remotely and see what the error was
but that's a future possibility thing, probably not as important as just logging to the same error log
todo: custom fields field names are not coming across, still show "Custom 1" when shoudl show whatever is set
todo: assigned doc not found text has too many newlines in it, should just sit on one line in exported notes
todo: dirty big test again with contracts etc
todo: v8 migrate additions
todo:1 custom fields field names are not coming across, still show "Custom 1" when shoudl show whatever is set
todo:1 assigned doc not found text has too many newlines in it, should just sit on one line in exported notes
todo:2 dirty big test again with contracts etc
todo:1 v8 migrate additions
Erase DB warning must be very distinctive like bright yellow and red with crossbones etc
Report sent *to* the new server upon completion (any state) via MEMO to superuser
should send the entire contents of the output screen error or not as it will contain useful info like dupes not exported etc
@@ -56,30 +64,88 @@ todo: v8 migrate additions
is there a way to still export them?
Is it possible to login during migrate to the v8 server?
Need a running count per item, I have the total at the start so it should show what item it is currently processing of that count like 50/1000 or something
todo: workorders - need to set billing and service address from customers on migrate
todo:1 workorders - need to set billing and service address from customers on migrate
## CLIENT MISC ITEMS
bugbug: direct notification errors out
user->direct notification
todo: joyce requested fields to add to reports viz fields
-3 case 3864 Joyce misc item - Layout improvement:
Summary (workorder overall) - looks like now can enter unlimited amount of text..... BUT if only using for four or five words, its still showing ALL this blank space across the entire screen
Tags - takes up entire row even though none or only one tag.
**Would like to discuss/recommend a way to have Summary field and Tags field reduced in size perhaps depending on amount of data
I.e. adjust size depending on what has been entered as in:
Tags - would rather see selection box width of single column (i.e. set it to show same as would show on a phone which is one column wide) without the screenwide lines and extra height showing now.
Summary - would rather show width of single column, only if multiple lines and/or # of characters exceeds xx then show extra height and width.
Custom fields - when set to Text takes up extra height. I understand that this is because of the "potential" text, i.e. that could have multiple rows etc. Is there ANY way to minimize these so only shows additional space IF actually used?
[#will look into it, not sure what can be done, the layout is pretty rigidly fixed within the UI framework to be able to work properly without conflict with the layout, but maybe there's something#]
-1 case 3864 Joyce misc item - add more viz fields to po:
Sample data for a PO
**VendorViz shows ONLY the vendor name:
-where and how to get address, contact name, phone number(s) for the selected vendor?
**DropShipToCustomerViz shows ONLY the customer name:
-how to get address, contact name(s), phone number(s) for the selected Ship to Customer?
todo:1 joyce requested fields to add to reports viz fields
PO - Customer address and contact information (for PO where a customer has been selected to be shipped to)
todo: notifications screen add delete all menu item that will just remove all the notifications present
-2 case 3864 Joyce misc item - part unit of measure auto suggest
You changed this which is great! -> Unit Charge (for labor and travel Rates) - now offers auto-suggest from prior entries to save typing.
************************************************************* OUTSTANDING ISSUE ****************************************************************
COULD YOU ALSO do similar for a Part's Unit of Measure field? in addition to saves typing PLUS allows user to select existing unit of measure so don'thave 10 different ways entered of "each", "ea", EAC", "per" etc
******************************************************************************************************************
-2 case 3864 Joyce misc item
TO BE ABLE TO PROVIDE TECHNICIAL SUPPORT: please document the following so when providing support AND for those that do review docs:
When NEW+ Po Item, when select a Part, the PO Cost and Vendor Number is NOT filled in UNTIL select Save for that PO Item.
WITH NOTE: Vendor Number can ONLY fill in automatically IF selected vendor for the PO is either the part's selected Wholesaler OR Alternative Wholesaler.
POTENTIAL ISSUES?: On "first" save, Vendor Number overwrites ANYTHING manually entered into the PO Cost field AND that has been manually entered into the Vendor Number field, overwriting with the actual part cost existing, and with the actual vendor number that is existing for the selected part. Once have saved at least once, THEN can edit.
-2 case 3864 Joyce misc item - help docs for report designer missing some info:
Help docs does not have anything about the "PDF Options" section of a report template. Info to include:
- Header template / Footer template:
-- leaving this link in here
https://pptr.dev/#?product=Puppeteer&version=v5.3.0&show=api-pagepdfoptions to refer to
-- Be aware what is in CSS section of report template is NOT capable of being applied here. Technical term is "CSS must be inlined" - i.e. specify font attributes as per example below.
-- Example of showing todays date in the header, and Page x of XX - note also total pages refers to TOTAL pages, NOT pages per object (i.e. if printing from a list of workorders, the total pages will be ALL workorders pages, not pages per workorder.
<span style="font-size:6pt;width: 94%; text-align:left; ">&nbsp;&nbsp;&nbsp;&nbsp;Todays date:&nbsp;<span class="date"></span></span>
<span style="font-size:6pt;width: 94%; text-align: right; ">Page&nbsp;<span class="pageNumber"></span>&nbsp;of&nbsp;<span class="totalPages"></span>&nbsp;&nbsp;&nbsp;&nbsp;</span>
-- identify all class=xx that CAN be used here in PDF Options: are there ANY other's other than class="date" to display todays' date, class="pageNumber" for page number, class="totalPages" for total pages of entire report (note that class="totalPages" identifies ALL pages of the report, NOT just per object)
- Paper Format: north american standard is Letter and Legal, select other sizes (i.e. A1) based on the paper you actually use - i.e. your country.
- Print Background MUST be checkmarked for CSS attributes such as alternating table rows to work
Help Docs about the Prepare section of the report template:
Make sure that information listed here about the minimum IS what is referred to elsewhere AS WELL as IS the actual minimum entered in ANY sample report templates included when a database is generated.
i.e. presently states:
async function ayPrepareData(ayAllData) {
return ayAllData;
}
I bring this up, because in sample report templates instead of ayAllData, reportData is used. IF doesn't EVERY make a difference what is called, please say so. If DOES make a difference if uses the name ayReportData or any other existing object, please say so.
bugbug:1 direct notification errors out
user->direct notification
todo:2 notifications screen add delete all menu item that will just remove all the notifications present
Maybe a checkbox and delete selected and select all?? That way can also be a dual useful feature
also should delete *from* the client so that it deletes only what it has in view so user doesn't accidentally delete unseen yet to be delivered ones?
todo: notification new bell alert count add to title so shows in task bar when not in view?
todo:3 notification new bell alert count add to title so shows in task bar when not in view?
like messenger "(1)" "(23)" etc
todo: roles are all over the place in some cases, e.g. login as tech restricted user and can see vendors / accounting and etc
todo: browser back to new record page
todo:2 browser back to new record page
when make new record then go back goes to new record again, should it go to record before *new* record page instead??
todo: link back to list from single edit form
todo:3 link back to list from single edit form
it would be very handy to have a simple link back to the list or back a level
on each edit form. If new record then it skips that and goes to list
so maybe a specific link to list, not just a back link
@@ -87,52 +153,50 @@ todo: link back to list from single edit form
not sure about that, maybe in wide mode it could surface that from menu but in
narrow mode no shortcut because they could use the nav menu anyway and because fuck em, that's why :)
todo: notifications form if left sitting there should auto-refresh when it gets any new notifications?
not 100% sure about this one, maybe it's a nice to have feature but a waste of time otherwise
todo: notifications new count seems to be double getting on each iteration
todo: Seeding UI keep track of timing and later down the road when firmed up, provide estimate (average server will take):
todo:1 notifications new count seems to be double getting on each iteration
todo:3 Seeding UI keep track of timing and later down the road when firmed up, provide estimate (average server will take):
2021-05-31 10:26:45.4801|INFO|Seeder|Small level sample data seeded in 27 seconds
2021-05-31 10:47:07.3417|INFO|Seeder|MEDIUM level sample data seeded in 2 minutes and 13 seconds
2021-05-31 10:56:04.9450|INFO|Seeder|LARGE level sample data seeded in 4 minutes and 17 seconds
2021-05-31 12:06:34.2680|INFO|Seeder|HUGE level sample data seeded in 24 minutes and 54 seconds
todo: need to track fetched keys vs used keys so can tell if fetched a key that I don't need or stopped using due to code change
todo: need to track fetched keys that don't exists, should bomb immediately so I can remove them, they will eat up traffic for no useful purpose!!
todo: strip all *viz fields from object before sending over the wire from client to server
todo:2 need to track fetched keys vs used keys so can tell if fetched a key that I don't need or stopped using due to code change
todo:1 need to track fetched keys that don't exists, should bomb immediately so I can remove them, they will eat up traffic for no useful purpose!!
todo:2 PO (workorder already done) strip all *viz fields from object before sending over the wire from client to server
Setting their value to undefined stops them being sent so do that, but remember they then need to be updated on the return record
PO I'm thinking is the main one??
todo: grid position not preserved when open a record then track back
todo:2 grid position not preserved when open a record then track back
i.e. go to last record in a multipage list, open something, go back and will see it's back to the start of the list losing the user's scroll position
this is very important that it work correctly
todo: purchase order form should work more like workorder form, it's a but fucky YAGNI??
Joyce has a case, technically it works but see what Joyce wrote
todo: custom required rules only apply to new records!!
todo:1 custom required rules only apply to new records!!
todo: inventory and other lists shows LT: because namefetcher postgres function returns it when it's not a named item
todo:2 inventory and other lists shows LT: because namefetcher postgres function returns it when it's not a named item
expects UI to translate it but UI doesn't so need a way to deal with that
to see what calls it just search for "AYGETNAME" in server project, also anything that calls bizobject name fetcher direct
it would be a better procedure if it was passed in a translation ID and would automatically get the key at db level of course
todo: notification subscription tags UI
todo:2 notification subscription tags UI
Must make it clear that *ALL* tags in the subscription must exist in the object to match
if not documented also document this
todo: Contract override by TAGS
todo:2 Contract override by TAGS
Translation / docs Must make it clear that *ALL* tags in that particular contract price override must exist in the object to match
User is expected to make multiple records if they want multiple different matching tags
reason for this is that they can do a more fine grained selection of multiple tags like "onsite" + "merville"
whereas if it was an any match then there would be no finer level of control, only one term to choose for each.
todo: form field customization add a "reset" feature to reset to default for when people fuck it up
todo:3 form field customization add a "reset" feature to reset to default for when people fuck it up
basically just show all fields and remove the required from fields
todo: add NOW button to date picker just like time picker that does the same thing
todo:1 add NOW button to date picker just like time picker that does the same thing
todo: Not in love with the "Error api2200" as the only error text in the box
todo:2 Not in love with the "Error api2200" as the only error text in the box
sometimes it has things you can't see in the form
ideally I'd like to see it have a string of text as a duplicate showing the errors translated in a list
in addition to each form field being set. This would cover our ass in case we missed a "general" or renamed a field or a wierd error
@@ -142,72 +206,54 @@ todo: Not in love with the "Error api2200" as the only error text in the box
At the very least make sure every raw error returned goes into the client log so can help with tech support when people need it without resorting to
making them open developer console to see the actual raw error. (if do this maybe extend the length of the error log as it's possibly too short to capture enough stuff this way??)
todo: Translation: "Physical" address seems wierd, rename to Street address or Delivery address or Service Address or whatever
todo: broken rules can't save should color save button red in addition to disabled some forms can't see what's what
todo: Any "Priority" type value in UI that has colors should use ayaFireAlt icon instead of round circle which is for minor status only
todo:2 Translation: "Physical" address seems wierd, rename to Street address or Delivery address or Service Address or whatever
todo:3 broken rules can't save should color save button red in addition to disabled some forms can't see what's what
todo:3 Any "Priority" type value in UI that has colors should use ayaFireAlt icon instead of round circle which is for minor status only
Flag is for major status like all of workorder
todo: be sure to address items in case https://rockfish.ayanova.com/default.htm#!/rfcaseEdit/3864
before next update to server / windows build for Joyce
todo: Re-test reporting on linux, just updated puppeteer sharp and it might be affected due to newer chromium
todo: double check main page boilerplate stuff is up to date 2021
todo:3 double check main page boilerplate stuff is up to date 2021
https://www.matuzo.at/blog/html-boilerplate/
todo: when there is an errorbox error it's possible to miss it as it's at the top scrolled off screen and you can save as the appbar doesn't scroll
todo:2 when there is an errorbox error it's possible to miss it as it's at the top scrolled off screen and you can save as the appbar doesn't scroll
need more feedback, perhaps appbar turns red, or save button turns red or whole page has a color to it..??
Or maybe just as simple as an toast alert popup whatever it's called that temporarily shows the same error as is in the box at top
todo: REPORTING
naming of things is confusing possibly prepare code should use same names as ayreportdata etc so users aren't confused
also it should be named to indicate the server is modifying the data before it's sent to the template
i.e. name everything so it's clear what is being done where
todo: reporting custom fields
todo:2 reporting custom fields
Joyce ran into an issue with a custom field defined as currency adn wanted to use it in a calculation on a report but it presents as a string
Look into either a helper to ease that or more ideally it presents as the type that it's supposed to be pre-modified? (not sure of the implications)
Do I have a custom fields helper already? What does it do?
Maybe translated custom fields alongside the string version??
Users see it as currency would be just as confused as Joyce was expecting it to be a number
todo: cleanup unnecessary use of a ayatype access inside the Methods of objects as it's now available in vue via main object,
todo:3 cleanup unnecessary use of a ayatype access inside the Methods of objects as it's now available in vue via main object,
e.g. where you see this: ayaTypes().XXXX you can replace it directly with this: $ay.ayt().XXXX and then REMOVE completely the ayaTypes() method in the vm of that object
todo: use const, not let unless need to reassign the variable
todo:2 use const, not let unless need to reassign the variable
Going to need a case by case through all uses but it's a very important precaution so code it that way now for all new code
todo: make sure other datatable besides wo use form() rowError classes for consistency rather than self set in forms
todo:3 make sure other datatable besides wo use form() rowError classes for consistency rather than self set in forms
see woitem / schedusers etc for example
todo: why the need for setErrorBoxErrors when setting the formstate errors already allows all the fields to pickup the errors for them
todo:3 why the need for setErrorBoxErrors when setting the formstate errors already allows all the fields to pickup the errors for them
shouldn't the errorbox itself pickup it's own errors and elminate the need for this??
currently is: <gz-error :error-box-message="formState.errorBoxMessage"></gz-error>
maybe could be this?: <gz-error :error-box-message="form().serverErrors(this, 'generalerror')"></gz-error>
might even be a drop in replacement, should test, would reduce fuckery
todo: gzdecimal triggering dirty just by clicking into and out of a field witha value in it.
todo:3 gzdecimal triggering dirty just by clicking into and out of a field witha value in it.
also, it sometimes shows without the decimal then with the decimal for editing then without, it's crazy
the decimal thing is probbly what's triggering the dirty change.
saw this when developing the wo form and testing scheduled users estimated qty field
todo: apierror showing in errorbox on validation error
todo:3 apierror showing in errorbox on validation error
this is too technical looking, needs to be cleaner for end users
maybe even a summary of errors for big forms showing property names and errors?
or at least say something like fields have errors or somesuch to guide them down into the form
small forms it's obvious but wo it's a bit ...actually still obvious, maybe just a cleaner line of text without the code looking stuff like "apiError" or whatever it shows
todo: generateMenu called on forms redundantly?
todo:3 generateMenu called on forms redundantly?
called for getdata, but also called in created in wrong place i.e. always rather than just when it's not a getdata situation due to already existing
todo: select list templates under global is offering types that don't6 have select lists like memo etc
todo: if all custom fields are turned off then should not show anything (I think that's already the case but confirm)
todo: ability to turn off attachments for every form it's on via customize ui
todo:2 select list templates under global is offering types that don't have select lists like memo etc
todo:2 ability to turn off attachments for every form it's on via customize ui
def can see admin wanting areas off limits for attachments and it would clean up the UI if not used
todo: ability to turn off the wiki for every form via customize ui
todo:2 ability to turn off the wiki for every form via customize ui
todo: adm-translations, adm-report templates data tables are skewed to the left due to lack of selection box column making filter icon partially gone off page
if has extension then should have selection box otherwise figure out what the dealio is
todo: after post to server check if this still happens:
Ayanova requires javascript is showing now all of a sudden on requests as if it's trying to serve app stuff from the server !?
refresh login and first response is the raw html page with noscript showing
maybe not even an issue, it does need that page after all
TODO: if keep seeing slowdown typing in large text fields maybe check if it's running rules endlessly and slowing things down that way
profile?
@@ -454,15 +500,7 @@ todo: many biz objects are not using new PUT methodology
########################################################################################################################
CURRENTLY DOING: more misc stuff below to complete workorder!!!
CASES TODO:
Some initial workorder cases to do
3843 1: prevent negative amounts on woitempart.quantity (rule I guess)
CURRENTLY DOING:
AFTER ABOVE ITEMS AND HAVE SUBSTANTIALLY COMPLETED WO
@@ -1237,4 +1275,8 @@ BUILD 116
- Application title bar fixed regression bug where it was not showing translation for main data table forms but was showing translation key instead
it should show the data table list name when it's a main data table list and if it's an individual record opened then it should show the record name or closest equivalent (serial for wo etc)
- Workorder header new Viz fields added: FromQuoteViz, FromPMViz, FromCSRViz which display the source record serial (or Name in the case of CSR) if the work order was generated from any of those things
- Workorder header new Viz fields added: FromQuoteViz, FromPMViz, FromCSRViz which display the source record serial (or Name in the case of CSR) if the work order was generated from any of those things
- case 3906 - fixed
- case 3907 - by design, see case for details
- case 3864 (subitem regarding memos showing replied when forwarded etc) fixed