HUGE REFACTOR / CLEANUP

if there is a issue it's probably something in here that was changed

ayanova/src/views/ay-history.vue

@@ -6,7 +6,6 @@
     >
     <v-row>
       <gz-error :error-box-message="formState.errorBoxMessage"></gz-error>
-
       <v-col rows="12">
         <template v-if="$route.params.userlog">
           <!-- **** USER LOG ****** -->
@@ -98,21 +97,15 @@
     </v-row>
   </v-card>
 </template>
-
 <script>
-/////////////////////////////////////////////////////////////////////////////////////////////////////////////
-/*  Xeslint-disable    */
-////////////////////////////////////////////////////////////////////////////////////////////////////////////
-
 const FORM_KEY = "ay-history";
 const API_BASE_URL = "event-log/";
 const DEFAULT_EVENTS_PAGE_SIZE = 200;
 export default {
   async created() {
-    let vm = this;
+    const vm = this;
     try {
       await initForm(vm);
-
       vm.readOnly = true;
       window.$gz.eventBus.$on("menu-click", clickHandler);
       generateMenu(vm, false);
@@ -196,7 +189,7 @@ export default {
       );
     },
     getIconForPage() {
-      let vm = this;
+      const vm = this;
       if (vm.$route.params.userlog) {
         return vm.ayaTypes[window.$gz.type.User].icon;
       } else {
@@ -245,7 +238,7 @@ export default {
       }
     },
     async getDataFromApi() {
-      let vm = this;
+      const vm = this;
       if (vm.formState.loading) {
         return;
       }
@@ -271,10 +264,9 @@ export default {
       url += "&Offset=" + vm.page * DEFAULT_EVENTS_PAGE_SIZE;
       url += "&limit=" + DEFAULT_EVENTS_PAGE_SIZE;
       try {
-        let res = await window.$gz.api.get(url);
+        const res = await window.$gz.api.get(url);
 
         if (res.error) {
-          //Not found?
           if (res.error.code == "2010") {
             window.$gz.form.handleObjectNotFound(vm);
           }
@@ -286,11 +278,11 @@ export default {
           vm.name = await window.$gz.translation.translateStringWithMultipleKeysAsync(
             res.data.name
           );
-          let temp = res.data.events;
-          let currentEventCount = vm.obj.length;
-          let timeZoneName = window.$gz.locale.getResolvedTimeZoneName();
-          let languageName = window.$gz.locale.getResolvedLanguage();
-          let hour12 = window.$gz.store.state.userOptions.hour12;
+          const temp = res.data.events;
+          const currentEventCount = vm.obj.length;
+          const timeZoneName = window.$gz.locale.getResolvedTimeZoneName();
+          const languageName = window.$gz.locale.getResolvedLanguage();
+          const hour12 = window.$gz.store.state.userOptions.hour12;
           for (let i = 0; i < temp.length; i++) {
             temp[i].date = window.$gz.locale.utcDateToShortDateAndTimeLocalized(
               temp[i].date,
@@ -303,24 +295,17 @@ export default {
             ].name = await window.$gz.translation.translateStringWithMultipleKeysAsync(
               temp[i].name
             );
-
             temp[i].index = currentEventCount + i;
           }
-
           vm.obj = [...vm.obj, ...temp];
-
-          //Update the form status
           window.$gz.form.setFormState({
             vm: vm,
             dirty: false,
             valid: true,
             loading: false
           });
-          //modify the menu as necessary
-          //  generateMenu(vm);
         }
       } catch (error) {
-        //Update the form status
         window.$gz.form.setFormState({
           vm: vm,
           loading: false
@@ -338,7 +323,7 @@ function clickHandler(menuItem) {
   if (!menuItem) {
     return;
   }
-  let m = window.$gz.menu.parseMenuItem(menuItem);
+  const m = window.$gz.menu.parseMenuItem(menuItem);
   if (m.owner == FORM_KEY && !m.disabled) {
     switch (m.key) {
       default:
@@ -354,7 +339,7 @@ function clickHandler(menuItem) {
 //
 //
 function generateMenu(vm) {
-  let menuOptions = {
+  const menuOptions = {
     isMain: false,
     icon: "$ayiHistory",
     title: "History",
@@ -369,17 +354,17 @@ function generateMenu(vm) {
 async function initForm(vm) {
   await fetchTranslatedText(vm);
   await populateAyaTypeList(vm);
-  await populateEventTypeList(vm);
+  populateEventTypeList(vm);
 }
 //////////////////////
 //
 //
 async function populateAyaTypeList(vm) {
   await window.$gz.enums.fetchEnumList("ayatype");
-  let ayt = window.$gz.enums.getSelectionList("ayatype");
-  let temp = {};
+  const ayt = window.$gz.enums.getSelectionList("ayatype");
+  const temp = {};
   for (let i = 0; i < ayt.length; i++) {
-    let item = ayt[i];
+    const item = ayt[i];
     let openableObject = false;
     //CoreBizObject add here
     //todo: centralize this if reuqired one more time anywhere