diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index e1c025dc..7d7098cb 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -29,7 +29,8 @@
//..........
-
+ Customer work order form / view / open???
+ Customer CSR form has a bunch of todo in the template, WTF?
Dashboard / widgets
Just enough an no more, this could be endless, come up with a top 5 or something and limit it to that
(this is also a very juicy v.next feature thing too)
@@ -94,6 +95,16 @@ Coded by importance
\_____|______|_____|______|_| \_| |_|
+- 1 refactoring let to const
+ remove all these:
+
+
+
+
+
+
+
+
- 1 BUG BUG: attempt to delete a customer with a linked unit (so it can't be deleted) and get error properly but overlay stays on form
whatever this is needs to be fixed everywhere
diff --git a/ayanova/src/App.vue b/ayanova/src/App.vue
index 6987d842..5c05dabe 100644
--- a/ayanova/src/App.vue
+++ b/ayanova/src/App.vue
@@ -2,7 +2,6 @@
-
-
diff --git a/ayanova/src/components/pm-item-loans.vue b/ayanova/src/components/pm-item-loans.vue
index 30f0ff8a..055e7b49 100644
--- a/ayanova/src/components/pm-item-loans.vue
+++ b/ayanova/src/components/pm-item-loans.vue
@@ -409,10 +409,6 @@
diff --git a/ayanova/src/components/pm-item-outside-services.vue b/ayanova/src/components/pm-item-outside-services.vue
index efbfc3e4..8107c70b 100644
--- a/ayanova/src/components/pm-item-outside-services.vue
+++ b/ayanova/src/components/pm-item-outside-services.vue
@@ -591,10 +591,6 @@
diff --git a/ayanova/src/components/work-order-address.vue b/ayanova/src/components/work-order-address.vue
index 7117188b..9106ffed 100644
--- a/ayanova/src/components/work-order-address.vue
+++ b/ayanova/src/components/work-order-address.vue
@@ -351,20 +351,15 @@
diff --git a/ayanova/src/views/adm-translation.vue b/ayanova/src/views/adm-translation.vue
index 45f78a55..74e32d4f 100644
--- a/ayanova/src/views/adm-translation.vue
+++ b/ayanova/src/views/adm-translation.vue
@@ -1,7 +1,6 @@
-
@@ -111,7 +110,7 @@
:return-value.sync="props.item.display"
:cancel-text="$ay.t('Cancel')"
:save-text="$ay.t('OK')"
- @save="saveItem(props.item)"
+ @save="saveItem()"
>
{{ props.item.display }}
@@ -136,21 +135,14 @@
-
diff --git a/ayanova/src/views/adm-user.vue b/ayanova/src/views/adm-user.vue
index 805cefff..956ac9d2 100644
--- a/ayanova/src/views/adm-user.vue
+++ b/ayanova/src/views/adm-user.vue
@@ -1,15 +1,12 @@
-
-
{{ $ay.t("User") }}
{{ $ay.t("UserSettings") }}
-
@@ -26,7 +23,6 @@
@input="fieldValueChanged('name')"
>
-
-
-
@@ -408,31 +402,20 @@
-
diff --git a/ayanova/src/views/ay-evaluate.vue b/ayanova/src/views/ay-evaluate.vue
index 47144286..27913aa4 100644
--- a/ayanova/src/views/ay-evaluate.vue
+++ b/ayanova/src/views/ay-evaluate.vue
@@ -102,24 +102,16 @@
-
diff --git a/ayanova/src/views/customer-workorder.vue b/ayanova/src/views/customer-workorder.vue
index 87abf056..5e933b16 100644
--- a/ayanova/src/views/customer-workorder.vue
+++ b/ayanova/src/views/customer-workorder.vue
@@ -21,10 +21,6 @@
diff --git a/ayanova/src/views/home-memo.vue b/ayanova/src/views/home-memo.vue
index 46c2fe4c..8a7e9d85 100644
--- a/ayanova/src/views/home-memo.vue
+++ b/ayanova/src/views/home-memo.vue
@@ -3,7 +3,6 @@
-
@@ -158,28 +157,18 @@
-
diff --git a/ayanova/src/views/home-memos.vue b/ayanova/src/views/home-memos.vue
index 0ae7ca74..7cc35ea6 100644
--- a/ayanova/src/views/home-memos.vue
+++ b/ayanova/src/views/home-memos.vue
@@ -53,7 +53,7 @@ async function clickHandler(menuItem) {
if (!menuItem) {
return;
}
- let m = window.$gz.menu.parseMenuItem(menuItem);
+ const m = window.$gz.menu.parseMenuItem(menuItem);
if (m.owner == FORM_KEY && !m.disabled) {
switch (m.key) {
case "new":
@@ -63,7 +63,7 @@ async function clickHandler(menuItem) {
});
break;
case "extensions":
- let res = await m.vm.$refs.extensions.open(
+ const res = await m.vm.$refs.extensions.open(
m.vm.$refs.gzdatatable.getDataListSelection(window.$gz.type.Memo)
);
if (res && res.refresh == true) {
@@ -72,7 +72,7 @@ async function clickHandler(menuItem) {
break;
case "report":
{
- let res = await m.vm.$refs.reportSelector.open(
+ const res = await m.vm.$refs.reportSelector.open(
m.vm.$refs.gzdatatable.getDataListSelection(window.$gz.type.Memo),
m.id
);
@@ -80,7 +80,7 @@ async function clickHandler(menuItem) {
return;
}
window.$gz.form.setLastReport(FORM_KEY, res);
- generateMenu(m.vm); //refresh the menu with the new report
+ generateMenu(m.vm);
}
break;
default:
@@ -96,7 +96,7 @@ async function clickHandler(menuItem) {
//
//
function generateMenu(vm) {
- let menuOptions = {
+ const menuOptions = {
isMain: true,
icon: "$ayiInbox",
title: "MemoList",
@@ -117,8 +117,6 @@ function generateMenu(vm) {
});
}
- //REPORTS
- //Report not Print, print is a further option
menuOptions.menuItems.push({
title: "Report",
icon: "$ayiFileAlt",
@@ -126,8 +124,7 @@ function generateMenu(vm) {
vm: vm
});
- //get last report selected
- let lastReport = window.$gz.form.getLastReport(FORM_KEY);
+ const lastReport = window.$gz.form.getLastReport(FORM_KEY);
if (lastReport != null) {
menuOptions.menuItems.push({
title: lastReport.name,
@@ -137,7 +134,6 @@ function generateMenu(vm) {
vm: vm
});
}
-
menuOptions.menuItems.push({
title: "Extensions",
icon: "$ayiPuzzlePiece",
diff --git a/ayanova/src/views/home-notifications.vue b/ayanova/src/views/home-notifications.vue
index 54780d14..5b71f2c6 100644
--- a/ayanova/src/views/home-notifications.vue
+++ b/ayanova/src/views/home-notifications.vue
@@ -66,7 +66,7 @@
const FORM_KEY = "notifications";
export default {
async created() {
- let vm = this;
+ const vm = this;
try {
await initForm(vm);
@@ -116,70 +116,41 @@ export default {
});
},
async deleteItem(item) {
- //prompt
- //delete
-
- let vm = this;
try {
- let dialogResult = await window.$gz.dialog.confirmDelete();
+ const dialogResult = await window.$gz.dialog.confirmDelete();
if (dialogResult != true) {
return;
}
-
- window.$gz.form.deleteAllErrorBoxErrors(vm);
- let res = await window.$gz.api.remove(
+ window.$gz.form.deleteAllErrorBoxErrors(this);
+ const res = await window.$gz.api.remove(
`notify/${item.id}`,
this.selectedItems
);
if (res.error) {
- vm.formState.serverError = res.error;
- window.$gz.form.setErrorBoxErrors(vm);
+ this.formState.serverError = res.error;
+ window.$gz.form.setErrorBoxErrors(this);
}
await this.getDataFromApi();
} catch (ex) {
- window.$gz.errorHandler.handleFormError(ex, vm);
+ window.$gz.errorHandler.handleFormError(ex, this);
}
},
-
async getDataFromApi() {
- let vm = this;
-
try {
- window.$gz.form.deleteAllErrorBoxErrors(vm);
-
- let res = await window.$gz.api.get("notify/app-notifications");
-
+ window.$gz.form.deleteAllErrorBoxErrors(this);
+ const res = await window.$gz.api.get("notify/app-notifications");
if (res.error) {
- //Not found?
if (res.error.code == "2010") {
- window.$gz.form.handleObjectNotFound(vm);
+ window.$gz.form.handleObjectNotFound(this);
}
- vm.formState.serverError = res.error;
- window.$gz.form.setErrorBoxErrors(vm);
+ this.formState.serverError = res.error;
+ window.$gz.form.setErrorBoxErrors(this);
} else {
- //pre-make the display list object
- //source object:
- //[ { "id": 1, "concurrency": 18835104, "userId": 1, "created": "2020-07-20T19:35:49.665888Z", "ayaType": 2,
- // "objectId": 101, "eventType": 2, "notifySubscriptionId": 1, "message": null, "fetched": true } ]
- //display object:
- //{event:"",objectname:"",objecttype:null,icon:null,eventdate:null,openurl:null,suburl:null,eventid}
-
- let temp = res.data;
-
- //Nice touch to show super faded just before deletion but don't have time for this at the moment
- // let dtNow = window.$gz.DateTime.local();
- // let dtToday = window.$gz.DateTime.local(
- // dtNow.year,
- // dtNow.month,
- // dtNow.day
- // );
- // let dtPrecipice = dtToday.plus({ days: -85 }).toUTC();
-
+ const temp = res.data;
const timeZoneName = window.$gz.locale.getResolvedTimeZoneName();
const languageName = window.$gz.locale.getResolvedLanguage();
const hour12 = window.$gz.store.state.userOptions.hour12;
const currencyName = window.$gz.locale.getCurrencyName();
-
for (let i = 0; i < temp.length; i++) {
temp[
i
@@ -190,24 +161,20 @@ export default {
hour12
);
- temp[i]["uievent"] = vm.selectLists.eventTypes.find(
+ temp[i]["uievent"] = this.selectLists.eventTypes.find(
z => z.id == temp[i].eventType
).name;
- temp[i]["uiayatype"] = vm.selectLists.ayaTypes.find(
+ temp[i]["uiayatype"] = this.selectLists.ayaTypes.find(
z => z.id == temp[i].ayaType
).name;
temp[i].icon = window.$gz.util.iconForType(temp[i].ayaType);
if (temp[i].name == "~SERVER~") {
- temp[i].name = vm.$ay.t("Server");
+ temp[i].name = this.$ay.t("Server");
}
- // if (temp[i].message && temp[i].message.includes("\n")) {
- // temp[i].message = temp[i].message.replace("\n", "
");
- // }
-
temp[i].ageValueViz = window.$gz.locale.durationLocalized(
temp[i].ageValue
);
@@ -228,33 +195,30 @@ export default {
temp[i].decValueViz = "";
}
}
-
- vm.obj = [...temp];
-
- //modify the menu as necessary
- generateMenu(vm);
- //Update the form status
+ this.obj = [...temp];
+ generateMenu(this);
window.$gz.form.setFormState({
- vm: vm,
+ vm: this,
dirty: false,
valid: true,
loading: false
});
-
//Check the new count and update accordingly
//this is to ensure that when a user is viewing the latest notifications they don't see the NEW count still in the bell icon in menu since they are viewing them live
- let status = await window.$gz.api.get("notify/new-count");
+ const status = await window.$gz.api.get("notify/new-count");
if (status.error) {
//throw new Error(status.error);
- throw new Error(window.$gz.errorHandler.errorToString(status, vm));
+ throw new Error(
+ window.$gz.errorHandler.errorToString(status, this)
+ );
}
window.$gz.store.commit("setNewNotificationCount", status.data);
}
} catch (error) {
- window.$gz.errorHandler.handleFormError(error, vm);
+ window.$gz.errorHandler.handleFormError(error, this);
} finally {
window.$gz.form.setFormState({
- vm: vm,
+ vm: this,
loading: false
});
}
@@ -269,16 +233,12 @@ async function clickHandler(menuItem) {
if (!menuItem) {
return;
}
- let m = window.$gz.menu.parseMenuItem(menuItem);
+ const m = window.$gz.menu.parseMenuItem(menuItem);
if (m.owner == FORM_KEY && !m.disabled) {
switch (m.key) {
case "refresh":
await m.vm.getDataFromApi();
break;
- // case "directnotify":
- // let res = await m.vm.$refs.extensions.open();
- // break;
-
default:
window.$gz.eventBus.$emit(
"notify-warning",
@@ -292,7 +252,7 @@ async function clickHandler(menuItem) {
//
//
function generateMenu(vm) {
- let menuOptions = {
+ const menuOptions = {
isMain: true,
icon: "$ayiBell",
title: "Notifications",
diff --git a/ayanova/src/views/home-notify-direct.vue b/ayanova/src/views/home-notify-direct.vue
index 9300cb01..d88f0fb9 100644
--- a/ayanova/src/views/home-notify-direct.vue
+++ b/ayanova/src/views/home-notify-direct.vue
@@ -3,7 +3,6 @@
-
-
-
-
diff --git a/ayanova/src/views/inv-part-adjustment.vue b/ayanova/src/views/inv-part-adjustment.vue
index 3cb540d1..8710099e 100644
--- a/ayanova/src/views/inv-part-adjustment.vue
+++ b/ayanova/src/views/inv-part-adjustment.vue
@@ -69,32 +69,23 @@
-
diff --git a/ayanova/src/views/inv-purchase-orders.vue b/ayanova/src/views/inv-purchase-orders.vue
index ba16f3cf..8abb8f27 100644
--- a/ayanova/src/views/inv-purchase-orders.vue
+++ b/ayanova/src/views/inv-purchase-orders.vue
@@ -19,7 +19,6 @@
-
diff --git a/ayanova/src/views/svc-contract.vue b/ayanova/src/views/svc-contract.vue
index eb34c5ae..cba5db40 100644
--- a/ayanova/src/views/svc-contract.vue
+++ b/ayanova/src/views/svc-contract.vue
@@ -1306,31 +1306,19 @@
-
diff --git a/ayanova/src/views/svc-meter-readings.vue b/ayanova/src/views/svc-meter-readings.vue
index 7737b7b5..8f8d3b4a 100644
--- a/ayanova/src/views/svc-meter-readings.vue
+++ b/ayanova/src/views/svc-meter-readings.vue
@@ -15,13 +15,7 @@
-
diff --git a/ayanova/src/views/svc-pm-item-expenses.vue b/ayanova/src/views/svc-pm-item-expenses.vue
index e3ea8c33..b454aa4a 100644
--- a/ayanova/src/views/svc-pm-item-expenses.vue
+++ b/ayanova/src/views/svc-pm-item-expenses.vue
@@ -19,7 +19,6 @@
-
diff --git a/ayanova/src/views/svc-quote-item-labors.vue b/ayanova/src/views/svc-quote-item-labors.vue
index f99981f7..de5b9687 100644
--- a/ayanova/src/views/svc-quote-item-labors.vue
+++ b/ayanova/src/views/svc-quote-item-labors.vue
@@ -22,7 +22,6 @@
-
diff --git a/ayanova/src/views/svc-quote-item-scheduled-users.vue b/ayanova/src/views/svc-quote-item-scheduled-users.vue
index 76cf3c0d..95080d9c 100644
--- a/ayanova/src/views/svc-quote-item-scheduled-users.vue
+++ b/ayanova/src/views/svc-quote-item-scheduled-users.vue
@@ -22,7 +22,6 @@
-