HUGE REFACTOR / CLEANUP

if there is a issue it's probably something in here that was changed

ayanova/src/components/report-selector-control.vue

@@ -88,27 +88,28 @@ export default {
       });
     },
     async renderReport(reportId, reportName) {
-      let vm = this;
-      if (vm.$route.params.recordid == 0) {
+      if (this.$route.params.recordid == 0) {
         return;
       }
 
-      let reportDataOptions = vm.reportDataOptions;
+      const reportDataOptions = this.reportDataOptions;
       if (!reportDataOptions) {
         this.reject("Missing report data unable to render report");
       }
       reportDataOptions.ReportId = reportId;
       //Meta data from client for use by report script
       reportDataOptions.ClientMeta = window.$gz.api.reportClientMetaData();
-      vm.rendering = true;
-      let url = "report/render";
+      this.rendering = true;
 
-      let res = await window.$gz.api.upsert(url, reportDataOptions);
-      vm.rendering = false;
+      const res = await window.$gz.api.upsert(
+        "report/render",
+        reportDataOptions
+      );
+      this.rendering = false;
       if (res.error) {
         this.reject(res);
       } else {
-        let reportUrl = window.$gz.api.reportDownloadUrl(res.data);
+        const reportUrl = window.$gz.api.reportDownloadUrl(res.data);
         if (window.open(reportUrl, "Report") == null) {
           this.reject(
             "Problem displaying report in new window.  Browser must allow pop-ups to view reports; check your browser setting"
@@ -123,7 +124,7 @@ export default {
       }
     },
     async open(reportDataOptions, preSelectReportId) {
-      let vm = this;
+      const vm = this;
       if (reportDataOptions == null) {
         throw new Error("report-selector:Open missing reportDataOptions");
       }
@@ -135,7 +136,7 @@ export default {
       this.preSelectReportId = preSelectReportId;
       if (!preSelectReportId) {
         //get report list from server
-        let res = await window.$gz.api.get(
+        const res = await window.$gz.api.get(
           `report/list/${reportDataOptions.AType}`
         );
         if (res.error) {