This commit is contained in:
2019-11-21 23:43:32 +00:00
parent 1f34ec6256
commit a904674d6c
2 changed files with 34 additions and 3 deletions

View File

@@ -58,6 +58,37 @@ TODO: Widget edit form, new record gives following error because custom field no
- Maybe can just do it like the main form but reference the main form's error collection??
TODO: gzform - seems to be assuming that server is returning matching field names as in form but they don't seem to match in case nor with name as for example notes in form is WidgetNotes in server error box:
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[name] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[name] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[serial] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[serial] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[count] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[count] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[dollarAmount] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[dollarAmount] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[startDate] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[startDate] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[endDate] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[endDate] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[active] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[active] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[roles] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[roles] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[notes] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[notes] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[tags] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[tags] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[customFields] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[customFields] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetNotes] to form field ref:[WidgetCustom2] gzform.js:91
getErrorsForField finding matches, comparing serverErrorField:[WidgetCustom2] to form field ref:[WidgetCustom2] gzform.js:91
TODO: Save button isn't enabling on changes in new record when it should. Enter in a value in the Name field of an empty record and move to a new field and it should immediately show the save button due to dirtiness?
- Or is it becuase of broken rules that are not being displayed immediately? (new record should really show a bunch of broken rules right away as it has some empty and required fields)
TODO: Make sure can easily make new record in Widget form before getting into deeper stuff or making any other object forms.
TODO: Widget edit form, new record sb time and dates pre-filled in? Server involved? How to handle new record initial date set?

View File

@@ -82,11 +82,13 @@ function getErrorsForField(vm, ref) {
return !o.target;
});
} else {
ret = window.$gz._.filter(vm.formState.serverError.details, function(o) {
if (!o.target) {
return false;
}
//server error fields are capitalized
console.log("getErrorsForField finding matches, comparing serverErrorField:["+o.target + "] to form field ref:["+ref+"]");
return o.target.toLowerCase() == ref;
});
}
@@ -325,8 +327,6 @@ export default {
//make sure formState.serverErrors is defined on data
if (!window.$gz._.has(vm, "formState.serverError")) {
debugger;
throw "DEV ERROR gzform::formState.serverErrors -> formState.serverError seems to be missing from form's vue data object";
}
@@ -352,7 +352,7 @@ export default {
//check for errors if we have any errors
if (!window.$gz._.isEmpty(vm.formState.serverError)) {
debugger;
//First let's get the top level error code
var apiErrorCode = parseInt(vm.formState.serverError.code);