admin/raven-client
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CHECKPOINT some misc changes and about to manually upgrade package.json dependencies again

Browse Source
This commit is contained in:
John Cardinal
2022-01-12 16:20:18 +00:00
parent a32c9e63c9
commit 9d4851a5f9
9 changed files with 43 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
ayanova/devdocs/todo.txt
View File

@@ -25,6 +25,8 @@ Prioritize anything that stands in the way of beta testing
TODO:
- Reporting issues below so can give to joyce to fixup reports, also several report related cases sb done now and then give her new beta
with instructions on fixup errors.
docs cleanup
Figure out where we stand with VUE and Vuetify releases as we want to have a stable release but don't want to release and find out a major bug is fixed the next day or something
@@ -33,23 +35,6 @@ Also need a protocol for handling updating front and back
# OUTSTANDING MAJOR AREAS TO BETA
- Monaco editor, update it to latest if possible and add js validation setting seems to be built in but is not in effect:
// validation settings
monaco.languages.typescript.javascriptDefaults.setDiagnosticsOptions({
noSemanticValidation: false,
noSyntaxValidation: false
});
This would have caught Joyce's errors in js code, also maybe there is a linter for other things too which woudl help with css issues etc
- Report templates code
go through every report, look at javascript in preparedata and determine if any weirdnesses
for example the customer z_replaceCarriage return with space code is using an undeclared variable n (which is also redundant anyway)
there maybe issues that need to be fixed or performance things etc
can't just assume they are all correct
maybe a quick check is to lint them in a copy paste standalone file??
YES, make a test .js script page that is a "harness" for the code then copy paste into it and it will show the errors
- Features
Roles
@@ -782,6 +767,28 @@ TODO: 1 BETA DOCS:
██ ██ ███████ ██ ██████ ██ ██ ██ ██ ██ ████ ██████
- 1: Monaco editor, update it to latest if possible and add js validation setting seems to be built in but is not in effect:
// validation settings
monaco.languages.typescript.javascriptDefaults.setDiagnosticsOptions({
noSemanticValidation: false,
noSyntaxValidation: false
});
TEST IT with the report z_replace carriage return with space which has errors in js that don't currently warn about
This would have caught Joyce's errors in js code, also maybe there is a linter for other things too which woudl help with css issues etc
- 1: Report templates code
go through every report, look at javascript in preparedata and determine if any weirdnesses
for example the customer z_replaceCarriage return with space code is using an undeclared variable n (which is also redundant anyway) ((javascript is insanely forgiving))
there maybe issues that need to be fixed or performance things etc
can't just assume they are all correct
maybe a quick check is to lint them in a copy paste standalone file??
YES, make a test .js script page that is a "harness" for the code then copy paste into it and it will show the errors
- 2: Report templates seem to have the LOUD helper in all of them when it's not used, sb removed from default report and just an example in docs if at all
---
@@ -798,8 +805,6 @@ TODO: 1 BETA DOCS:
\_____|______|_____|______|_| \_| |_|
-1 todo: increase level of restriction in linter, it will detect some real bugs like undeclared variable usage etc
see myapp for deets
- 2 todo: put reset link somewhere in UI so user can just click on it, maybe the login form?? Or the About form? about->log form?
@@ -964,6 +969,15 @@ todo: 3 Schedule form reporting?
|_____/|______|_| \_\ \/ |______|_| \_\
todo: 2 remove unused translations
add code at server to scan all reports and parse out translation keys used into a single list of unique values for use later
Find way to find all translations in client project requested and make into unique list
Find way to get all translations specified at server and make into unique list
Determine if there is anything that will come over from v7 that would be broken if removed from v8??
what is the policy here anyway exactly? This needs to be determined.
is it possible for v7 imported objects to refer somehow to translation keys that v8 doesn't actually use anywhere or is it just the translated text itself that would be outdated?
find way to take unique list and auto-compare it to actual translations and spit out list of potentially unused
todo: 2 VERY IMPORTANT test on windows where all paths have spaces, i.e. set the server data path to a location with funky folder names with spaces etc
confirm everything in raven that writes to disk still works, logging, backup, attachments, temp files served (reports) etc
@@ -997,11 +1011,6 @@ todo: 2 rockfish generate keys for purchased licenses, the real deal
todo: 2 lost contact with db server notification message to be sent once to ops admin??
don't want too many but should notify
todo:2 Joyce case 3931 test restore of 4alarm data
Get a copy from Joyce on the red drive, it's about 5gb
write up how to do it if there are manual steps (there will be I guess but maybe there shouldn't be)
make sure it works one way or another
confirm it's really backing up everything
todo: 2 make priority / woitem / wostatus colors distinct from each other
whitecaps color scheme shale/pastel etc

2
ayanova/src/components/gzconfirm.vue
View File

@@ -27,7 +27,7 @@
</template>
<span v-if="options.title" class="ml-5"> {{ options.title }} </span>
</v-card-title>
<!-- eslint-disable vue/no-v-html -->
<v-card-text
class="text-body-1 text-sm-h6 my-5"
v-html="options.message"

1
ayanova/src/components/pm-item-units.vue
View File

@@ -142,6 +142,7 @@
>
<v-card>
<v-card-title>{{ $ay.t("UnitWarrantyInfo") }}</v-card-title>
<!-- eslint-disable vue/no-v-html -->
<v-card-text
v-html="
value.items[activeWoItemIndex].units[activeItemIndex]

1
ayanova/src/components/quote-item-units.vue
View File

@@ -142,6 +142,7 @@
>
<v-card>
<v-card-title>{{ $ay.t("UnitWarrantyInfo") }}</v-card-title>
<!-- eslint-disable vue/no-v-html -->
<v-card-text
v-html="
value.items[activeWoItemIndex].units[activeItemIndex]

1
ayanova/src/components/work-order-item-units.vue
View File

@@ -148,6 +148,7 @@
>
<v-card>
<v-card-title>{{ $ay.t("UnitWarrantyInfo") }}</v-card-title>
<!-- eslint-disable vue/no-v-html -->
<v-card-text
v-html="
value.items[activeWoItemIndex].units[activeItemIndex]

2
ayanova/src/views/home-schedule.vue
View File

@@ -103,7 +103,7 @@
<v-icon small :color="event.textColor" class="mr-1">{{
iconForEvent(event.type)
}}</v-icon>
<!-- eslint-disable vue/no-v-html -->
<span
:class="event.textColor + '--text'"
v-html="eventSummary()"

1
ayanova/src/views/home-search.vue
View File

@@ -50,6 +50,7 @@
@click="openItem(item)"
>
<v-list-item-title v-text="item.name"></v-list-item-title>
<!-- eslint-disable vue/no-v-html -->
<v-list-item-subtitle
v-html="item.info"
></v-list-item-subtitle>

2
ayanova/src/views/svc-schedule-user.vue
View File

@@ -96,7 +96,7 @@
<v-icon small :color="event.textColor" class="mr-1">{{
iconForEvent(event.type)
}}</v-icon>
<!-- eslint-disable vue/no-v-html -->
<span
:class="event.textColor + '--text'"
v-html="eventSummary()"

7
ayanova/src/views/svc-schedule.vue
View File

@@ -132,10 +132,9 @@
<template v-slot:event="{ event, eventSummary }">
<div class="v-event-draggable">
<span
:class="event.textColor + '--text'"
v-html="eventSummary()"
/><v-icon
<!-- eslint-disable vue/no-v-html -->
<span :class="event.textColor + '--text'" v-html="eventSummary()" />
<v-icon
v-if="!event.editable"
x-small
:color="event.textColor"