admin/raven-client
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CHECKPOINT Font conversion to tree shaking friendly method starts here

Browse Source
This commit is contained in:
John Cardinal
2020-10-05 16:29:19 +00:00
parent 761a1a4f39
commit 9ba997d104
1 changed files with 15 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
ayanova/devdocs/todo.txt
View File

@@ -3,34 +3,26 @@
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
TODO: BUILD 62
Test at devops with lighthouse, in browser confirm it properly avoids downloading report editor until needed
remove todo immediately below if it's fixed now
todo: chunk-vendors has fa-brands in it which is fucking huge, what else is in there I don't need?
eradicate fa-brands!
Looks like I'm doing it wrong, I was using a generic NPM module when there is a Vue specific one that also has guidance to limit to just the icons I actually use:
https://github.com/FortAwesome/vue-fontawesome
This could be a big breaking change so need to do it carefully and all at once as it's own project
Definitely need to do though, it will save a lot of size to just include the actual icons I'm using which is a handful
GUIDANCE
See c:\temp\mytest project which uses the correct lib
https://github.com/FortAwesome/vue-fontawesome#learn-about-our-new-svg-implementation
https://stackoverflow.com/questions/52030435/fontawesome-with-vuetify-how-to-include-font-awesome-icons-within-the-v-icon-c/58261449#58261449
todo: why do I want precaching at all? Seems like a bad idea all around
it aggressively fetches things like the report designer etc
slows down first page load
hmm..
INFO
need service worker to enable install to desktop / phone app screen
advantages are access to device info and features (which I don't use now), user ease of use because it's just sitting right on the screen (this is the only reason I support it)
lazy loading is probably what I want: https://blog.logrocket.com/lazy-loading-in-vue-js/
I do want the feature, I just want it to back off when not required
https://vueschool.io/articles/vuejs-tutorials/lazy-loading-and-code-splitting-in-vue-js/
todo: login button can be obscured by footer, this should not happen try forcing margin below, footer maybe has a setting to confine it?
move the login button?
make sure enter works with it
todo: chrome "Lighthouse" test against devops and implement recommendations
particularly favor time to first
change .png to .webp
todo: precache workbox trying to cache api routes:
workbox Precaching did not find a match for /api/v8.0/notify/new-count
workbox Precaching did not find a match for /api/v8.0/notify/hello
workbox Precaching did not find a match for /api/v8.0/logo/small
Find a way to turn off
https://developers.google.com/web/tools/workbox/modules/workbox-precaching#how_workbox-precaching_works
### SMALL QUICK ITEMS #####
todo: change logos from png to webp
@@ -42,9 +34,7 @@ todo: is notifynewcount request double sending? It seems like it appears twice
todo: lodash, according to lighthouse it's vulnerable version and needs update
can I just remove it and replace the functionality with built in javascript methods now?
todo: libs outside of package.json, check if they are outdated or need updating or can be replaced / removed
todo: login button can be obscured by footer, this should not happen try forcing margin below, footer maybe has a setting to confine it?
move the login button?
make sure enter works with it
todo: scaffold a new vue project with same options and see what it generates for all the config files etc
I might be missing some new stuff that needs to be in there in light of the webpack whitelist thing earlier
@@ -117,17 +107,6 @@ todo: v7 items .net final version update to if possible and feature request for
todo: chunk-vendors has fa-brands in it which is fucking huge, what else is in there I don't need?
eradicate fa-brands!
Looks like I'm doing it wrong, I was using a generic NPM module when there is a Vue specific one that also has guidance to limit to just the icons I actually use:
https://github.com/FortAwesome/vue-fontawesome
This could be a big breaking change so need to do it carefully and all at once as it's own project
Definitely need to do though, it will save a lot of size to just include the actual icons I'm using which is a handful
GUIDANCE
See c:\temp\mytest project which uses the correct lib
https://github.com/FortAwesome/vue-fontawesome#learn-about-our-new-svg-implementation
todo: decimal-control and currency-control:
Fix currency and decimal input controls since after vue-currency update latest version get error ".$ci is undefined" when open a form with them on it
proposal: remove all need for vue-currency-input, see if can roll my own using intl code