2021-09-06 19:10:26 +00:00
parent 713359cb3d
commit 5625e38810
17 changed files with 35 additions and 23 deletions
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -62,9 +62,6 @@ Coded by importance
 ## CLIENT MISC ITEMS


-1 Default global setting tax codes, default minutes etc?	
-	doesn't seem to be implemented, maybe it shoudl not be there??
-
 -2 hyperlinks in memos sb clickable to open in new tab or window or whatever
 	this supports help links in migrate and also user links like "take a look at workorder 55" with a link to it in the UI
 	recognize urls and make them actionable somehow
@@ -859,4 +856,4 @@ BUILD 129 CHANGES OF NOTE
 - Extensions dialog could be dismissed by clicking outside or pressing escape circumventing Exit button; made Exit button only way to close dialog
 - Workorder / quote / pm adding missing work order item Travel "distance" field from travel section in form on data tables, customize forms etc
 - Work order item expense "Summary" field changed to "Description" in English translation to disambiguate it on lists and forms from Item "Summary" and Workorder header "Summary"
-
+- Work / Quote / PM order global default tax codes implemented in labor, loan, parts, sched users, travels but not outside service as wasn't in v7 and not sure if appropriate to default that one.  Also not expenses because not default in v7 and also not always tax anyway.
--- a/ayanova/src/components/pm-item-labors.vue
+++ b/ayanova/src/components/pm-item-labors.vue
@@ -540,7 +540,8 @@ export default {
        serviceDetails: null,
        serviceRateQuantity: 0,
        noChargeQuantity: 0,
-        taxCodeSaleId: null,
+        taxCodeSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        price: 0,
        priceOverride: null,
        isDirty: true,
--- a/ayanova/src/components/pm-item-loans.vue
+++ b/ayanova/src/components/pm-item-loans.vue
@@ -493,7 +493,7 @@ export default {
        outDate: null,
        dueDate: null,
        returnDate: null,
-        taxCodeId: null,
+        taxCodeId: window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
        loanUnitId: 0, //zero to break rule on new
        quantity: 1,
        rate: 1,
--- a/ayanova/src/components/pm-item-parts.vue
+++ b/ayanova/src/components/pm-item-parts.vue
@@ -614,7 +614,8 @@ export default {
            partId: z.partId,
            partWarehouseId: this.selectedPartWarehouse,
            quantity: z.quantity,
-            taxPartSaleId: null,
+            taxPartSaleId:
+              window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
            price: 0,
            priceOverride: null,
            cost: 0,
@@ -723,7 +724,8 @@ export default {
        partId: 0, //deliberately zero to break rule on new
        partWarehouseId: 1, //important always default to "default" warehouse id 1 as even with inventory turned off it's required
        quantity: 1,
-        taxPartSaleId: null,
+        taxPartSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
        price: 0,
        priceOverride: null,
        cost: 0,
--- a/ayanova/src/components/pm-item-scheduled-users.vue
+++ b/ayanova/src/components/pm-item-scheduled-users.vue
@@ -383,7 +383,8 @@ export default {
        serviceDetails: null,
        serviceRateQuantity: s.estimatedQuantity,
        noChargeQuantity: 0,
-        taxCodeSaleId: null,
+        taxCodeSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        price: 0,
        priceOverride: null,
        isDirty: true,
--- a/ayanova/src/components/pm-item-travels.vue
+++ b/ayanova/src/components/pm-item-travels.vue
@@ -553,7 +553,8 @@ export default {
          : null,
        travelStartDate: null,
        travelStopDate: null,
-        travelRateId: null,
+        travelRateId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        travelDetails: null,
        travelRateQuantity: 0,
        noChargeQuantity: 0,
--- a/ayanova/src/components/quote-item-labors.vue
+++ b/ayanova/src/components/quote-item-labors.vue
@@ -540,7 +540,8 @@ export default {
        serviceDetails: null,
        serviceRateQuantity: 0,
        noChargeQuantity: 0,
-        taxCodeSaleId: null,
+        taxCodeSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        price: 0,
        priceOverride: null,
        isDirty: true,
--- a/ayanova/src/components/quote-item-loans.vue
+++ b/ayanova/src/components/quote-item-loans.vue
@@ -493,7 +493,7 @@ export default {
        outDate: null,
        dueDate: null,
        returnDate: null,
-        taxCodeId: null,
+        taxCodeId: window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
        loanUnitId: 0, //zero to break rule on new
        quantity: 1,
        rate: 1,
--- a/ayanova/src/components/quote-item-parts.vue
+++ b/ayanova/src/components/quote-item-parts.vue
@@ -614,7 +614,8 @@ export default {
            partId: z.partId,
            partWarehouseId: this.selectedPartWarehouse,
            quantity: z.quantity,
-            taxPartSaleId: null,
+            taxPartSaleId:
+              window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
            price: 0,
            priceOverride: null,
            cost: 0,
@@ -723,7 +724,8 @@ export default {
        partId: 0, //deliberately zero to break rule on new
        partWarehouseId: 1, //important always default to "default" warehouse id 1 as even with inventory turned off it's required
        quantity: 1,
-        taxPartSaleId: null,
+        taxPartSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
        price: 0,
        priceOverride: null,
        cost: 0,
--- a/ayanova/src/components/quote-item-scheduled-users.vue
+++ b/ayanova/src/components/quote-item-scheduled-users.vue
@@ -383,7 +383,8 @@ export default {
        serviceDetails: null,
        serviceRateQuantity: s.estimatedQuantity,
        noChargeQuantity: 0,
-        taxCodeSaleId: null,
+        taxCodeSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        price: 0,
        priceOverride: null,
        isDirty: true,
--- a/ayanova/src/components/quote-item-travels.vue
+++ b/ayanova/src/components/quote-item-travels.vue
@@ -553,7 +553,8 @@ export default {
          : null,
        travelStartDate: null,
        travelStopDate: null,
-        travelRateId: null,
+        travelRateId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        travelDetails: null,
        travelRateQuantity: 0,
        noChargeQuantity: 0,
--- a/ayanova/src/components/work-order-item-labors.vue
+++ b/ayanova/src/components/work-order-item-labors.vue
@@ -540,7 +540,8 @@ export default {
        serviceDetails: null,
        serviceRateQuantity: 0,
        noChargeQuantity: 0,
-        taxCodeSaleId: null,
+        taxCodeSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        price: 0,
        priceOverride: null,
        isDirty: true,
--- a/ayanova/src/components/work-order-item-loans.vue
+++ b/ayanova/src/components/work-order-item-loans.vue
@@ -497,7 +497,7 @@ export default {
        outDate: null,
        dueDate: null,
        returnDate: null,
-        taxCodeId: null,
+        taxCodeId: window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
        loanUnitId: 0, //zero to break rule on new
        quantity: 1,
        rate: 1,
--- a/ayanova/src/components/work-order-item-outside-services.vue
+++ b/ayanova/src/components/work-order-item-outside-services.vue
@@ -688,7 +688,7 @@ export default {
        sentDate: window.$gz.locale.nowUTC8601String(),
        etaDate: null,
        returnDate: null,
-        taxCodeId: null,
+        taxCodeId: null, //Is it labor or parts tax code?  wasn't in v7 leaving empty for now 
        isDirty: true,
        workOrderItemId: this.value.items[this.activeWoItemIndex].id,
        uid: Date.now(),
--- a/ayanova/src/components/work-order-item-parts.vue
+++ b/ayanova/src/components/work-order-item-parts.vue
@@ -614,7 +614,8 @@ export default {
            partId: z.partId,
            partWarehouseId: this.selectedPartWarehouse,
            quantity: z.quantity,
-            taxPartSaleId: null,
+            taxPartSaleId:
+              window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
            price: 0,
            priceOverride: null,
            cost: 0,
@@ -723,7 +724,8 @@ export default {
        partId: 0, //deliberately zero to break rule on new
        partWarehouseId: 1, //important always default to "default" warehouse id 1 as even with inventory turned off it's required
        quantity: 1,
-        taxPartSaleId: null,
+        taxPartSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxPartSaleId,
        price: 0,
        priceOverride: null,
        cost: 0,
--- a/ayanova/src/components/work-order-item-scheduled-users.vue
+++ b/ayanova/src/components/work-order-item-scheduled-users.vue
@@ -383,7 +383,8 @@ export default {
        serviceDetails: null,
        serviceRateQuantity: s.estimatedQuantity,
        noChargeQuantity: 0,
-        taxCodeSaleId: null,
+        taxCodeSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        price: 0,
        priceOverride: null,
        isDirty: true,
--- a/ayanova/src/components/work-order-item-travels.vue
+++ b/ayanova/src/components/work-order-item-travels.vue
@@ -559,7 +559,8 @@ export default {
        travelDetails: null,
        travelRateQuantity: 0,
        noChargeQuantity: 0,
-        taxCodeSaleId: null,
+        taxCodeSaleId:
+          window.$gz.store.state.globalSettings.defaultTaxRateSaleId,
        price: 0,
        priceOverride: null,
        isDirty: true,