case 4073

This commit is contained in:
2022-01-12 21:01:24 +00:00
parent c3d132f427
commit 4685d3bac7
2 changed files with 3 additions and 88 deletions

View File

@@ -767,93 +767,7 @@ TODO: 1 BETA DOCS:
██ ██ ███████ ██ ██████ ██ ██ ██ ██ ██ ████ ██████
- 1: Monaco editor, update it to latest if possible and add js validation setting seems to be built in but is not in effect:
// validation settings
monaco.languages.typescript.javascriptDefaults.setDiagnosticsOptions({
noSemanticValidation: false,
noSyntaxValidation: false
});
TEST IT with the report z_replace carriage return with space which has errors in js that don't currently warn about
This would have caught Joyce's errors in js code, also maybe there is a linter for other things too which woudl help with css issues etc
working version:
"monaco-editor": "^0.21.3",
"monaco-editor-webpack-plugin": "^2.1.0",
https://github.com/microsoft/monaco-editor/tree/main/webpack-plugin
monaco-editor@0.19.2 '0.19.2'
monaco-editor@0.19.3 '0.19.3'
monaco-editor@0.20.0 '0.20.0'
monaco-editor@0.21.0 '0.21.0'
monaco-editor@0.21.1 '0.21.1'
monaco-editor@0.21.2 '0.21.2'
monaco-editor@0.21.3 '0.21.3'
monaco-editor@0.22.0 '0.22.0'
monaco-editor@0.22.1 '0.22.1'
monaco-editor@0.22.2 '0.22.2'
monaco-editor@0.22.3 '0.22.3'
monaco-editor@0.23.0 '0.23.0'
monaco-editor@0.24.0 '0.24.0'
monaco-editor@0.25.0 '0.25.0'
monaco-editor@0.25.1 '0.25.1'
monaco-editor@0.25.2 '0.25.2'
monaco-editor@0.26.0 '0.26.0'
monaco-editor@0.26.1 '0.26.1'
monaco-editor@0.27.0 '0.27.0'
monaco-editor@0.28.0 '0.28.0'
monaco-editor@0.28.1 '0.28.1'
monaco-editor@0.29.0 '0.29.0'
monaco-editor@0.29.1 '0.29.1'
monaco-editor@0.30.0 '0.30.0'
monaco-editor@0.30.1 '0.30.1'
monaco-editor@0.31.0 '0.31.0'
monaco-editor@0.31.1 '0.31.1'
C:\data\code\raven-client\ayanova>npm show monaco-editor-webpack-plugin@* version
monaco-editor-webpack-plugin@1.0.0 '1.0.0'
monaco-editor-webpack-plugin@1.1.0 '1.1.0'
monaco-editor-webpack-plugin@1.2.0 '1.2.0'
monaco-editor-webpack-plugin@1.2.1 '1.2.1'
monaco-editor-webpack-plugin@1.3.0 '1.3.0'
monaco-editor-webpack-plugin@1.4.0 '1.4.0'
monaco-editor-webpack-plugin@1.5.0 '1.5.0'
monaco-editor-webpack-plugin@1.5.1 '1.5.1'
monaco-editor-webpack-plugin@1.5.2 '1.5.2'
monaco-editor-webpack-plugin@1.5.3 '1.5.3'
monaco-editor-webpack-plugin@1.5.4 '1.5.4'
monaco-editor-webpack-plugin@1.6.0 '1.6.0'
monaco-editor-webpack-plugin@1.7.0 '1.7.0'
monaco-editor-webpack-plugin@1.8.0 '1.8.0'
monaco-editor-webpack-plugin@1.8.1 '1.8.1'
monaco-editor-webpack-plugin@1.8.2 '1.8.2'
monaco-editor-webpack-plugin@1.9.0 '1.9.0'
monaco-editor-webpack-plugin@1.9.1 '1.9.1'
monaco-editor-webpack-plugin@2.0.0 '2.0.0'
monaco-editor-webpack-plugin@2.1.0 '2.1.0'
monaco-editor-webpack-plugin@3.0.0 '3.0.0'
monaco-editor-webpack-plugin@3.0.1 '3.0.1'
monaco-editor-webpack-plugin@3.1.0 '3.1.0'
monaco-editor-webpack-plugin@4.0.0 '4.0.0'
monaco-editor-webpack-plugin@4.1.0 '4.1.0'
monaco-editor-webpack-plugin@4.1.1 '4.1.1'
monaco-editor-webpack-plugin@4.1.2 '4.1.2'
monaco-editor-webpack-plugin@4.2.0 '4.2.0'
monaco-editor-webpack-plugin@5.0.0 '5.0.0'
monaco-editor-webpack-plugin@6.0.0 '6.0.0'
monaco-editor-webpack-plugin@7.0.0 '7.0.0'
monaco-editor-webpack-plugin@7.0.1 '7.0.1'
- 1: Report templates code
go through every report, look at javascript in preparedata and determine if any weirdnesses
for example the customer z_replaceCarriage return with space code is using an undeclared variable n (which is also redundant anyway) ((javascript is insanely forgiving))
there maybe issues that need to be fixed or performance things etc
can't just assume they are all correct
maybe a quick check is to lint them in a copy paste standalone file??
YES, make a test .js script page that is a "harness" for the code then copy paste into it and it will show the errors
- 2: Report templates seem to have the LOUD helper in all of them when it's not used, sb removed from default report and just an example in docs if at all
---
@@ -1445,6 +1359,7 @@ BUILD 8.0.0-beta.0.11 CHANGES OF NOTE
})
so that the Helpers tab is empty (unless using a custom helper but I don't think there are any)
- case 4072 - set to priority 2 to keep an eye on in case it becomes an issue or I can fix it in some way
- case 4073 fixed

View File

@@ -558,7 +558,7 @@ export default {
noSemanticValidation: false,
noSyntaxValidation: false,
noSuggestionDiagnostics: false,
diagnosticCodesToIgnore: [2393] //this hides a weird error about ayPrepareData being declared more than once which I think is more related to it being barebones in there
diagnosticCodesToIgnore: [2393, 7044] //this hides a weird error about ayPrepareData being declared more than once which I think is more related to it being barebones in there
});
monaco.languages.typescript.javascriptDefaults.setCompilerOptions({
target: monaco.languages.typescript.ScriptTarget.ES6,