This commit is contained in:
2020-03-02 18:01:28 +00:00
parent f925206470
commit 2c471a0093
2 changed files with 2 additions and 16 deletions

View File

@@ -45,12 +45,6 @@ CURRENT TODOs
@@@@@@@@@@@ ROADMAP STAGE 1 and 2:
todo: save (post) of new record at client triggers renavigation to that page again which also triggers fetch
- Notes in beforeRouteUpdate(to, from, next) { in WIDGET edit form
- It's a bug in my logic, beforeRouteUpdate fires when submit changes the url in the url bar, but that should not trigger a refetch
- Only CREATED and beforeRouteUpdate are triggering GetDataFromAPI, created is valid on open of course so need to handle beforerouteupdate
-Does it really need to even do anything, I mean, why would the route update, I guess when navigating back and forth between widgets?
todo: CUSTOMIZE not working on widget edit form
todo: CUSTOM DATE FIELD NOT SETTING NOW??
- Retest every kind of custom field

View File

@@ -312,16 +312,8 @@ export default {
}
},
beforeRouteUpdate(to, from, next) {
//fetch the data for the record as if it's a new record
bugbug: if we are here because a recent submit this triggers a full fetch
//except there's no reason to full fetch as we already have the data required from the submit
//so need to flag that somehow or figure out better logic here
//- Only CREATED and beforeRouteUpdate are triggering GetDataFromAPI, created is valid on open of course so need to handle beforerouteupdate
//-Does it really need to even do anything, I mean, why would the route update, I guess when navigating back and forth between widgets?
//WHY IS THIS REQUIRED? IS IT BECAUSE OF NAV BACK AND FORTH BETWEEN WIDGETS MAYBE??
//TEST THAT BEFORE PROCEEDING WITH ANY FIX FOR SUBMIT FETCH ISSUE
//This triggers a fetch of the data when the ID value changes on the route
//which happens on duplicate, submit new record and change of active record id (backward nav/forward nav etc)
if (to.params.recordid != 0) {
this.getDataFromApi(to.params.recordid);
}