ayanova/devdocs/todo.txt

@@ -115,15 +115,7 @@ todo:1 workorders - need to set billing and service address from customers on mi
 	Custom fields - when set to Text takes up extra height. I understand that this is because of the "potential" text, i.e. that could have multiple rows etc. Is there ANY way to minimize these so only shows additional space IF actually used?
 	[#will look into it, not sure what can be done, the layout is pretty rigidly fixed within the UI framework to be able to work properly without conflict with the layout, but maybe there's something#]
 
--1** case 3864 Joyce misc item - add more viz fields to po:
 	
-	Add VENDOR mail and delivery addresses, all phone numbers and contact fields
-	Add dropshipcustomer phone numbers, both addresses to viz fields on po
-	
-
-todo:1** joyce requested fields to add to reports viz fields	
-	PO - Customer address and contact information (for PO where a customer has been selected to be shipped to) 
-
 
 -2 case 3864 Joyce misc item - part unit of measure auto suggest
 	You changed this  which is great! -> Unit Charge (for labor and travel Rates) - now offers auto-suggest from prior entries to save typing.
@@ -161,8 +153,7 @@ todo:1** joyce requested fields to add to reports viz fields
 
 
 
-bugbug:1** direct notification errors out
-	user->direct notification
+
 
 
 todo:2 notifications screen add delete all menu item that will just remove all the notifications present
@@ -185,8 +176,6 @@ todo:3 link back to list from single edit form
 	narrow mode no shortcut because they could use the nav menu anyway and because fuck em, that's why :)
 
 
-todo:1** notifications new count seems to be double getting on each iteration
-
 todo:3 Seeding UI keep track of timing and later down the road when firmed up, provide estimate (average server will take):
 	2021-05-31 10:26:45.4801|INFO|Seeder|Small level sample data seeded in 27 seconds
 	2021-05-31 10:47:07.3417|INFO|Seeder|MEDIUM level sample data seeded in 2 minutes and 13 seconds
@@ -279,7 +268,9 @@ todo:3 apierror showing in errorbox on validation error
 	small forms it's obvious but wo it's a bit ...actually still obvious, maybe just a cleaner line of text without the code looking stuff like "apiError" or whatever it shows
 todo:3 generateMenu called on forms redundantly?
 	called for getdata, but also called in created in wrong place i.e. always rather than just when it's not a getdata situation due to already existing
-todo:2 select list templates under global is offering types that don't have select lists like memo etc
+
+	
+todo:1** select list templates under global is offering types that don't have select lists like memo etc
 
 todo:2 ability to turn off attachments for every form it's on via customize ui
 	def can see admin wanting areas off limits for attachments and it would clean up the UI if not used
@@ -318,8 +309,6 @@ todo:2 remove widget now? Back and front (comment out obvs not remove entirely)
 
 ## SERVER MISC ITEMS
 
-todo:1** Joyce was having trouble getting a license request email response from rockfish when trialing 
-	it appeared it was not sending the confirmation check email, double check what the fuck
 
 
 todo:1 seeder customer and head office accounts now login show "No features have been enabled for your account"
@@ -897,6 +886,9 @@ BUILD 116
 - case 3907 - by design, see case for details
 - case 3864 (subitem regarding memos showing replied when forwarded etc) fixed
 - case 3908 back to you for suggestions
+- case 3909 replied back to you
 - case 3864 (po more fields for reporting)
 	Added VENDOR mail and delivery addresses, all phone numbers and contact fields
 	Added dropshipcustomer phone numbers, both addresses to viz fields on po
+
+- Fixed bug in Direct Notification where preselecting users in user list or single user form and selecting direct notification resulted in error instead of form open with users preselected

ayanova/src/components/pick-list.vue

@@ -317,8 +317,6 @@ export default {
       try {
         let res = await window.$gz.api.upsert("pick-list/list", pickListParams);
 
-        //  let res = await window.$gz.api.get("pick-list/list" + urlParams);
-
         vm.fetching = false;
         //We never expect there to be no data here
         if (!res.hasOwnProperty("data")) {

ayanova/src/router.js

@@ -154,8 +154,16 @@ export default new Router({
           /* webpackChunkName: "ay-common" */ "./views/home-notifications.vue"
         )
     },
+    // {
+    //   path: "/home-notify-direct/:userIdList?",
+    //   name: "home-notify-direct",
+    //   component: () =>
+    //     import(
+    //       /* webpackChunkName: "ay-common" */ "./views/home-notify-direct.vue"
+    //     )
+    // },
     {
-      path: "/home-notify-direct/:userIdList?",
+      path: "/home-notify-direct",
       name: "home-notify-direct",
       component: () =>
         import(

ayanova/src/views/adm-user.vue

@@ -996,7 +996,6 @@ async function clickHandler(menuItem) {
         break;
 
       case "directnotify":
-        //nav to direct notify with list of users appended to route
         if (m.vm.obj.id == 0) {
           m.vm.$router.push({
             name: "home-notify-direct"

ayanova/src/views/home-notify-direct.vue

@@ -319,6 +319,7 @@ async function fetchTranslatedText(vm) {
 //
 async function preFillSelection(vm) {
   var idParam = vm.$route.params.userIdList;
+
   let l = [];
   if (typeof idParam == "string" && idParam.includes(",")) {
     //just a random list of user ids seperated by commas
@@ -328,14 +329,16 @@ async function preFillSelection(vm) {
     l.push(parseInt(idParam, 10));
   }
 
-  for (let i of l) {
-    if (vm.toUsers.find(z => z.id == i)) {
-      continue;
-    }
-    let res = await window.$gz.api.get("pick-list/list?ayaType=3&preId=" + i);
-    if (res.data && res.data.length > 0) {
-      vm.toUsers.push(res.data[0]);
-    }
+  let res = await window.$gz.api.post("pick-list/list", {
+    ayaType: window.$gz.type.User,
+    inactive: false,
+    preselectedIds: l
+  });
+
+  if (res.data && res.data.length > 0) {
+    res.data.forEach(x => {
+      vm.toUsers.push(x);
+    });
   }
 }
 </script>