CHECKPOINT B4 SERVICE BANK SERVICEBANK REMOVAL This is the commit to see the service bank items if need to add back in

See case 3887
This commit is contained in:
2021-06-04 21:56:25 +00:00
parent 5e457e6500
commit 0d79c18e4b

View File

@@ -366,56 +366,6 @@ CURRENTLY DOING: workorder round two electric boogaloo
basics first then increasingly esoteric features
todo 3: service bank
Questions:
Can banked service go negative?
yes, and v8 is designed to allow it as well, if users complain it's a notification issue
In v7 it was manually applied, can v8 just auto apply and auto remove like inventory?
or is there a case where some things are not banked and some are?
How to show balances to user?
How to handle multiple bankable objects on one wo?
What would the new wo structure bank to if there are more than one unit, customer and ho all with bank??
would user have to choose what is banked?
What if a unit that is bankable is added to a workorder with new labor and saved but that workorder has already been saved and banked against customer, then there are now two separate things that have been banked?
maybe each item needs to determine what it was banked against so it can be reversed
Does the entire work order have a bankable object type/id snapshotted and that's used for all unless user changes it?
Can I remove the feature of a unit having a service bank entirely so that it can work automatically?
do people even use it??
TODO:
How it will work:
Work order can only bank entirely to one specific object, not a mix
if users need mix they must make another work order for other objects / split them out
Workorder has bankable object tid field that all bankable items are applied to upon save of those items
Bankable objects have a banked checkbox
While this field is not set any change that could result in a bankable object being added to the workorder will check this field and set it if it's not set
User can change this field to any bankable object supported on that workorder based on what is saved currently to it
user can only do this if teh workorder is saved and not dirty (just like state)
a popup form will open once it confirms it's saved and not dirty else a warning
in the popup form are shown all bankable objects and the currently selected one, user picks with radio button selection
if changed, the header is saved with the new bankable object
When a bankable object is set on the workorder or changed:
Workorder will go through all it's existing records and apply to this bankable object
A work order with a bankable object set is assumed to have been banked completely
new objects added will be banked upon save
changes to objects will fixup bank just like inventory does now
Individual bankable objects do not need a service bank id as any object on a saved workorder with a service bank
If can bank to multiple objects from one workorder then
Any bankable workorder* object needs to have a bankid field added adn when banked that is set with the bank id so it can be reversed to the correct object by rehydrating it
On demand balances with a click from menu
Add wo-wide Alert if bankable object determined for wo has negative balance in any visible category
alert should show all category balances
find bankable object, apply on save, reverse on delete / adjust, just like inventory does now but with all other shit
todo 3: notification