From f423243a1e99afdcd54f473dd8f31b9737621376 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Tue, 12 May 2020 22:18:59 +0000 Subject: [PATCH] --- devdocs/todo.txt | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/devdocs/todo.txt b/devdocs/todo.txt index f7267f09..7b3aef99 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -1,21 +1,16 @@ -TODO: PRIORITIZE ALL THE FOLLOWING INTO TWO CLASSES - "NOW" or "LATER" - then do the "now" ones -=-=-=- - -### NOW - todo: add query fail logging to datalist just like done with picklist so in production can catch mysterious problems more easily - TODO: BizRoles.cs seems to get hammered on every single request, is it efficient? - Why is it not cached in some way? - Look into Lazy initialization (i.e. private static readonly Lazy> mappings ....etc) - + - Maybe break it out into separate objects + if do so then ideally put them into the biz object responsible? + - it has to instantiate that anyway on any meaningful operation + or...is this worse than actually caching in a lifetime cache because it will need to load on every route hit whereas a lifteimte cache is just there from being loaded once? todo: AUTO ID GENERATOR change to a dedicated spot in global rather than inferring as it is not right practically for reasons Get the auto-id most recent values at boot time internal static void SetMostRecentAutoIdValuesFromDatabase(AyaNova.Models.AyContext ct) - TODO: API REFACTORING (note: workordercontroller / biz should be following all these rules so it's the template if need reference) todo: consider and then get rid of PATCH in all routes unless compelling reason to keep @@ -36,7 +31,6 @@ todo: Routes should check rights *BEFORE* they fetch the object, not after, all i.e. delete route instantiates biz object, then it fetchs object from db *then* it checks if they have rights to delete (generically, not specific to that object) This is out of order as it triggers a db call even if they have no rights to do it todo: all biz objects "ExistsAsync" is this required / necessary? - todo: Search get search result for workorder descendents doesn't fit into existing system due to it being a biz object wide feature but workorder having sub-get results - CHILD objects need to point to their parent and be readable in code for searching and for opening objects based on child object - so all child objects need a typeandid of the immediate parent @@ -44,7 +38,6 @@ todo: Search get search result for workorder descendents doesn't fit into existi - Required for opening a search result of a descendent that is not directly openable an - Need parent AyaType as an ENUM ATTRIBUTE in the AyaType table for easy traversal todo: search tables in schema, I think there is a missing index here, need to look at the search query section again as it was changed several times from the original schema creation - todo: api / server landing page is shitty on a mobile and really just shitty, add a logo or some shit todo: Should server show uptime somewhere?