From e86bb56a067ba5abb22f2a303cf45357fba57dd3 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Tue, 7 Nov 2023 18:09:45 +0000 Subject: [PATCH] --- docs/8.0/ayanova/docs/changelog.md | 2 ++ server/AyaNova/biz/ReportBiz.cs | 5 ----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/docs/8.0/ayanova/docs/changelog.md b/docs/8.0/ayanova/docs/changelog.md index f13b50f6..ccfa52d1 100644 --- a/docs/8.0/ayanova/docs/changelog.md +++ b/docs/8.0/ayanova/docs/changelog.md @@ -16,6 +16,8 @@ Released 2023-XX-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX - App, Server: Reporting - the ayT translation key helper function now shows an error directly in the rendered report in place of an incorrect or uncached translation key rather than the report failing entirely with an error message +- App: Improvements to error handling and display if there is an issue when rendering reports + **Added** - App: Work orders, Quotes and PM's added a new feature to the Customer Contact field to enable the user to select from any existing [Contact](customers.md#contacts-tab) entered for that Customer. diff --git a/server/AyaNova/biz/ReportBiz.cs b/server/AyaNova/biz/ReportBiz.cs index cb495899..01cbb2da 100644 --- a/server/AyaNova/biz/ReportBiz.cs +++ b/server/AyaNova/biz/ReportBiz.cs @@ -570,11 +570,6 @@ namespace AyaNova.Biz //API DOCS http://www.puppeteersharp.com/api/index.html log.LogDebug($"Launching headless Browser and new page now:"); - //bugbug: if browser fails to launch return error to user is not expected format json but text instead as there is no handling here - //this should be wrapped in an outer try block that handles browser failing to launch and returns clean error object JSON formatted - //and explaining server error see server error log with some indicative text like "render engine failed to launch" - //i.e. intentionally without the word browser to not confuse the user - using (var browser = await Puppeteer.LaunchAsync(lo)) using (var page = (await browser.PagesAsync())[0]) {