.vscode/launch.json

@@ -58,10 +58,11 @@
         //"AYANOVA_TEMP_FILES_PATH": "c:\\temp\\RavenTestData\\tempfiles",
         "AYANOVA_SERVER_TEST_MODE": "false",
         //"AYANOVA_LOG_PATH": "c:\\temp\\RavenTestData\\logs",
-
         //   "AYANOVA_SERVER_TEST_MODE_SEEDLEVEL": "small",
         //   "AYANOVA_SERVER_TEST_MODE_TZ_OFFSET": "-8",
-        "AYANOVA_BACKUP_PG_DUMP_PATH": "C:\\data\\code\\postgres_14\\bin\\"
+        //"AYANOVA_BACKUP_PG_DUMP_PATH": "C:\\data\\code\\postgres_14\\bin\\"
+        "AYANOVA_BACKUP_PG_DUMP_PATH": "C:\\Program Files\\ayanova\\local-postgres\\bin"
+        
       },
       "sourceFileMap": {
         "/Views": "${workspaceFolder}/Views"

server/AyaNova/generator/CoreJobBackup.cs

@@ -71,34 +71,31 @@ namespace AyaNova.Biz
                 DataBackupFile = FileUtil.GetFullPathForBackupFile(DataBackupFile);
 
                 var BackupUtilityCommand = "pg_dump";
+               
+
                 if (!string.IsNullOrWhiteSpace(ServerBootConfig.AYANOVA_BACKUP_PG_DUMP_PATH))
                     BackupUtilityCommand = Path.Combine(ServerBootConfig.AYANOVA_BACKUP_PG_DUMP_PATH, BackupUtilityCommand);
 
                 var Arguments = $"{DBNameParameter} -Fc > {DataBackupFile}";
 
                 var Result = RunProgram.Run(BackupUtilityCommand, Arguments, log, MAXIMUM_MS_ALLOWED_FOR_PROCESSING);
-                if (string.IsNullOrWhiteSpace(Result))
+                if (!string.IsNullOrWhiteSpace(Result))
-                {
-                    var ms = "Backup of database completed OK";
-                    log.LogDebug(ms);
-                   
-                }
-                else
                 {
                     var msg = $"Error during data backup \"{Result}\"";
                     await JobsBiz.LogJobAsync(Guid.Empty, msg);
                     log.LogError($"BACKUP ERROR: {Result}");
                     await NotifyEventHelper.AddGeneralNotifyEvent(NotifyEventType.BackupStatus, msg, "Backup");
                 }
+                else
+                {                   
+                    log.LogDebug("Backup of database completed OK");
 
                     //DO FILE BACKUP IF ATTACHMENTS BACKED UP
                     if (ServerGlobalOpsSettingsCache.Backup.BackupAttachments)
                     {
                         await JobsBiz.LogJobAsync(Guid.Empty, $"LT:Backup LT:Attachments");
                         FileUtil.BackupAttachments(DemandFileNamePrepend);                       
-                    var ms = "Backup of file attachments completed OK";
+                        log.LogDebug("Backup of file attachments completed OK");
-                    log.LogDebug(ms);                 
-
                     }
 
                     //PRUNE DATA BACKUP SETS NOT KEPT
@@ -112,6 +109,7 @@ namespace AyaNova.Biz
                     var duration = DateTime.Now - dtStartBackup;
                     await NotifyEventHelper.AddGeneralNotifyEvent(NotifyEventType.BackupStatus, $"Backup ({(OnDemand ? "manual / on demand" : "scheduled")}) completed successfully, duration (h:m:s.ms): {duration.ToString()}, server re-opened", "Backup");
                 }
+            }
             catch (Exception ex)
             {
                 await JobsBiz.LogJobAsync(Guid.Empty, "LT:JobFailed");

server/AyaNova/util/RunProgram.cs

@@ -52,6 +52,8 @@ namespace AyaNova.Util
             // var FullRunCommand=$"/C {BackupUtilityCommand} {Arguments}";
 
             //for Windows need to pass to cmd.exe because often have command line piping etc
+
+            //todo: make this work when there are spaces with quotes etc
             var args = $"/C {cmd} {arguments}";
             using (var process = new Process())
             {