admin/raven
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

case 4494

Browse Source
This commit is contained in:
John Cardinal
2023-03-22 00:02:46 +00:00
parent 749dbdff66
commit d615c1d7b0
5 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/8.0/ayanova/docs/changelog.md
View File

@@ -14,6 +14,10 @@ See the [upgrade instructions](ops-upgrade.md) section of this manual for detail
- App: Additional improvements to web app local error logging in certain conditions - App: Additional improvements to web app local error logging in certain conditions
#### Fixed
- Server: Fix for issue occasionally causing error saving duplicated Work order, Quote, PM with attachments selected
### AyaNova 8.0.39 (2023-03-17) ### AyaNova 8.0.39 (2023-03-17)
#### Added #### Added

16
server/AyaNova/biz/AttachmentBiz.cs
View File

@@ -224,7 +224,7 @@ namespace AyaNova.Biz
//////////////////////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////////////////
//DUPLICATE ATTACHMENTS TO NEW OBJECT //DUPLICATE ATTACHMENTS TO NEW OBJECT
// //
internal static async Task DuplicateAttachments(AyaTypeId aSource, AyaTypeId aDest, AyContext ct) internal static async Task DuplicateAttachments(AyaTypeId aSource, AyaTypeId aDest, long attachedByUserId, AyContext ct)
{ {
var sources = await ct.FileAttachment.AsNoTracking() var sources = await ct.FileAttachment.AsNoTracking()
.Where(z => z.AttachToAType == aSource.AType && z.AttachToObjectId == aSource.ObjectId) .Where(z => z.AttachToAType == aSource.AType && z.AttachToObjectId == aSource.ObjectId)
@@ -233,7 +233,19 @@ namespace AyaNova.Biz
{ {
foreach (var src in sources) foreach (var src in sources)
{ {
ct.FileAttachment.Add(new FileAttachment { AttachToObjectId = aDest.ObjectId, AttachToAType = aDest.AType, StoredFileName = src.StoredFileName, DisplayFileName = src.DisplayFileName, ContentType = src.ContentType, LastModified = src.LastModified, Notes = src.Notes, Exists = src.Exists, Size = src.Size }); ct.FileAttachment.Add(new FileAttachment
{
AttachToObjectId = aDest.ObjectId,
AttachToAType = aDest.AType,
StoredFileName = src.StoredFileName,
DisplayFileName = src.DisplayFileName,
ContentType = src.ContentType,
LastModified = src.LastModified,
Notes = src.Notes,
Exists = src.Exists,
Size = src.Size,
AttachedByUserId=attachedByUserId//
});
} }
await ct.SaveChangesAsync(); await ct.SaveChangesAsync();
} }

2
server/AyaNova/biz/PMBiz.cs
View File

@@ -151,7 +151,7 @@ namespace AyaNova.Biz
if (newObject.GenCopyAttachmentsFrom != null && !newObject.GenCopyAttachmentsFrom.IsEmpty) if (newObject.GenCopyAttachmentsFrom != null && !newObject.GenCopyAttachmentsFrom.IsEmpty)
{ {
//copy attachment from existing object //copy attachment from existing object
await AttachmentBiz.DuplicateAttachments(newObject.GenCopyAttachmentsFrom, new AyaTypeId(AyaType.PM, newObject.Id), ct); await AttachmentBiz.DuplicateAttachments(newObject.GenCopyAttachmentsFrom, new AyaTypeId(AyaType.PM, newObject.Id), this.UserId, ct);
newObject.GenCopyAttachmentsFrom = null;//so it doesn't get returned newObject.GenCopyAttachmentsFrom = null;//so it doesn't get returned
} }
await PMHandlePotentialNotificationEvent(AyaEvent.Created, newObject); await PMHandlePotentialNotificationEvent(AyaEvent.Created, newObject);

2
server/AyaNova/biz/QuoteBiz.cs
View File

@@ -155,7 +155,7 @@ namespace AyaNova.Biz
if (newObject.GenCopyAttachmentsFrom != null && !newObject.GenCopyAttachmentsFrom.IsEmpty) if (newObject.GenCopyAttachmentsFrom != null && !newObject.GenCopyAttachmentsFrom.IsEmpty)
{ {
//copy attachment from existing object //copy attachment from existing object
await AttachmentBiz.DuplicateAttachments(newObject.GenCopyAttachmentsFrom, new AyaTypeId(AyaType.Quote, newObject.Id), ct); await AttachmentBiz.DuplicateAttachments(newObject.GenCopyAttachmentsFrom, new AyaTypeId(AyaType.Quote, newObject.Id), this.UserId, ct);
newObject.GenCopyAttachmentsFrom = null;//so it doesn't get returned newObject.GenCopyAttachmentsFrom = null;//so it doesn't get returned
} }
await QuoteHandlePotentialNotificationEvent(AyaEvent.Created, newObject); await QuoteHandlePotentialNotificationEvent(AyaEvent.Created, newObject);

2
server/AyaNova/biz/WorkOrderBiz.cs
View File

@@ -176,7 +176,7 @@ namespace AyaNova.Biz
if (newObject.GenCopyAttachmentsFrom != null && !newObject.GenCopyAttachmentsFrom.IsEmpty) if (newObject.GenCopyAttachmentsFrom != null && !newObject.GenCopyAttachmentsFrom.IsEmpty)
{ {
//copy attachment from existing object //copy attachment from existing object
await AttachmentBiz.DuplicateAttachments(newObject.GenCopyAttachmentsFrom, new AyaTypeId(AyaType.WorkOrder, newObject.Id), ct); await AttachmentBiz.DuplicateAttachments(newObject.GenCopyAttachmentsFrom, new AyaTypeId(AyaType.WorkOrder, newObject.Id), this.UserId, ct);
newObject.GenCopyAttachmentsFrom = null;//so it doesn't get returned newObject.GenCopyAttachmentsFrom = null;//so it doesn't get returned
} }
await WorkOrderHandlePotentialNotificationEvent(AyaEvent.Created, newObject); await WorkOrderHandlePotentialNotificationEvent(AyaEvent.Created, newObject);