diff --git a/devdocs/todo.txt b/devdocs/todo.txt index 0e111a9f..c41fb03e 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -4,31 +4,12 @@ -TODO: post to server and test - - -todo: add switch somewhere to "automatic backup" so can turn off in event of externally done backup - this will take backup processing out of the generator loop - but keep the backup ui so even if external, can download the backup files - - -todo: add backup master time out setting - environment variable - - - - TODO: restrict server so randos can't login since the client now has all the logins helpfully pre-loaded on it not sure how to do that and still support phone via cellular network or other people's wifi from logging in Firewall settings I guess of some kind or maybe require a manual edit to the password, like add a 1 to the end of all of them or something? -todo: it would be very handy to say the least to be able to run raven locally in linux for testing here - maybe virtual box, but I sure don't want to fuck up things, maybe need another computer, some cheap shitbox can test on? - is it slowing down development is really the only question I guess - -todo: notification? todo: OPS notification created for failed jobs also maybe direct immediate email bypassing generator? @@ -61,14 +42,22 @@ todo: onboarding and default manager account password - maybe tied to license if licensed so they bring some info they have from rockfish / their license purchase or something? - don't want it to be onerous too much and have some very inexperienced users so... - see what other programs do, like our forum software + todo: API docs, make separate page for datalists and remove from api-response-format.md doc but put a reference link to it there. -DEPLOY AND TEST -todo: Test backup on Linux - - going to need to run in vm I think maybe +TODO: When go to full beta trial for people to look at need it to handle simultaneous logins somehow + maybe they get their own trial instance or something MAYBE todo: tag refcount Move this into a procedure, it's apparently quite slow now that I can see the metrics + +todo: add backup master time out setting + environment variable + +todo: add switch somewhere to "automatic backup" so can turn off in event of externally done backup + this will take backup processing out of the generator loop + but keep the backup ui so even if external, can download the backup files + diff --git a/server/AyaNova/Controllers/BackupController.cs b/server/AyaNova/Controllers/BackupController.cs index f2a0fdac..288e3f95 100644 --- a/server/AyaNova/Controllers/BackupController.cs +++ b/server/AyaNova/Controllers/BackupController.cs @@ -25,7 +25,7 @@ namespace AyaNova.Api.Controllers [ApiController] [ApiVersion("8.0")] [Route("api/v{version:apiVersion}/backup")] - [Produces("application/json")] + [Produces("application/json")] public class BackupController : ControllerBase { private readonly AyContext ct; @@ -47,6 +47,8 @@ namespace AyaNova.Api.Controllers serverState = apiServerState; } + //DANGER: MUST ADD AUTHORIZE ATTRIBUTE TO ANY NEW ROUTES + //[Authorize] /// /// Trigger immediate system backup @@ -125,7 +127,7 @@ namespace AyaNova.Api.Controllers await Task.Delay(nFailedAuthDelay);//DOS protection return StatusCode(403, new ApiNotAuthorizedResponse()); } - + if (!FileUtil.UtilityFileExists(fileName)) { await Task.Delay(nFailedAuthDelay);//fishing protection @@ -139,8 +141,8 @@ namespace AyaNova.Api.Controllers } -//DANGER: MUST ADD AUTHORIZE ATTRIBUTE TO ANY NEW ROUTES -//[Authorize] + //DANGER: MUST ADD AUTHORIZE ATTRIBUTE TO ANY NEW ROUTES + //[Authorize] }//eoc }//eons