From d37af11c683247cabe2b06cbe59fc813803ce011 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Fri, 17 Jul 2020 17:23:56 +0000 Subject: [PATCH] --- devdocs/specs/core-notification.txt | 4 +-- .../AyaNova/Controllers/EnumListController.cs | 4 +-- server/AyaNova/biz/NotifyEventType.cs | 36 +++++++++---------- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/devdocs/specs/core-notification.txt b/devdocs/specs/core-notification.txt index d7c24cce..01549870 100644 --- a/devdocs/specs/core-notification.txt +++ b/devdocs/specs/core-notification.txt @@ -222,7 +222,7 @@ CSRAccepted [CUSTOMER] CSRRejected [CUSTOMER] NewWorkorder [CUSTOMER] WorkorderStatusChange [CUSTOMER] [CONDITION: WOSTATUS integer] -WorkorderClosed [CUSTOMER] +### DEPRECATED, WOSTATUS event now replaces this ### WorkorderClosed [CUSTOMER] ### HOLD for v.next lots of cases around customer satisfaction survey etc not initial release though WorkorderFollowUp [CUSTOMER]###### QuoteStatusChanged [CUSTOMER] [CONDITION: QUOTESTATUS integer] ServiceBank[Currency/Hours/Incidents]Depleted [GENERAL] @@ -234,7 +234,7 @@ ScheduleMarkerImminent (now "reminder") [PERSONAL] ScheduleMarkerCreated (now "reminder") [PERSONAL] WorkorderItemScheduledUserCreatedUpdated [PERSONAL] WorkorderItemScheduledUserEventImminent [PERSONAL] -WorkorderCloseByDatePassed (user) [general] +### CHANGED same concept but uses a COMPLETED type status as the trigger, so I guess it's WorkorderPastCompletionDate or something### WorkorderCloseByDatePassed (user) [general] WorkorderStatusChanged (user) [GENERAL] [CONDITION: WOSTATUS integer] WorkorderItemOutsideServiceOverdue [general] WorkorderItemOutsideServiceReceivedBack [GENERAL] diff --git a/server/AyaNova/Controllers/EnumListController.cs b/server/AyaNova/Controllers/EnumListController.cs index 0a36755e..de23747d 100644 --- a/server/AyaNova/Controllers/EnumListController.cs +++ b/server/AyaNova/Controllers/EnumListController.cs @@ -237,7 +237,7 @@ namespace AyaNova.Api.Controllers TranslationKeysToFetch.Add("NotifyEventContractExpiring"); TranslationKeysToFetch.Add("NotifyEventCSRAccepted"); TranslationKeysToFetch.Add("NotifyEventCSRRejected"); - TranslationKeysToFetch.Add("NotifyEventWorkorderClosed"); + //TranslationKeysToFetch.Add("NotifyEventWorkorderClosed"); TranslationKeysToFetch.Add("NotifyEventQuoteStatusChange"); TranslationKeysToFetch.Add("NotifyEventQuoteStatusAge"); TranslationKeysToFetch.Add("NotifyEventObjectAge"); @@ -268,7 +268,7 @@ namespace AyaNova.Api.Controllers ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventContractExpiring"], Id = (long)NotifyEventType.ContractExpiring }); ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventCSRAccepted"], Id = (long)NotifyEventType.CSRAccepted }); ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventCSRRejected"], Id = (long)NotifyEventType.CSRRejected }); - ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventWorkorderClosed"], Id = (long)NotifyEventType.WorkorderClosed }); + // ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventWorkorderClosed"], Id = (long)NotifyEventType.WorkorderClosed }); ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventQuoteStatusChange"], Id = (long)NotifyEventType.QuoteStatusChange }); ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventQuoteStatusAge"], Id = (long)NotifyEventType.QuoteStatusAge }); ReturnList.Add(new NameIdItem() { Name = LT["NotifyEventObjectAge"], Id = (long)NotifyEventType.ObjectAge }); diff --git a/server/AyaNova/biz/NotifyEventType.cs b/server/AyaNova/biz/NotifyEventType.cs index 9e4cb904..87ec27a7 100644 --- a/server/AyaNova/biz/NotifyEventType.cs +++ b/server/AyaNova/biz/NotifyEventType.cs @@ -21,24 +21,24 @@ namespace AyaNova.Biz QuoteStatusChange = 9,//Quote object, any *change* of status including from no status (new) to a specific conditional status ID value ObjectAge = 10,//Any object, Age (conditional on AgeValue) after creation event of any object of conditional specific AyaType and optionally conditional tags ServiceBankDepleted = 11,//ServiceBank object, any change to balance triggers this check, conditional on decvalue as remaining balance left to trigger this notification - ReminderImminent = 12,//Reminder object - ScheduledOnWorkorder = 13, - ScheduledOnWorkorderImminent = 14, - WorkorderCloseByPassed = 15, - OutsideServiceOverdue = 16, - OutsideServiceReceived = 17, - PartRequestReceived = 18, - NotifyHealthCheck = 19,//with timespan to set frequency - BackupStatus = 20, - CustomerServiceImminent = 21, - PartRequested = 22, - WorkorderTotalExceedsThreshold = 23,//"the Andy" - WorkorderStatusAge = 24,//sitting too long in same status - UnitWarrantyExpiry = 25, - UnitMeterReadingMultipleExceeded = 26, - DefaultNotification = 27,//old quick notification, refers now to any direct text notification internal or user to user used for system notifications (default delivers in app but user can opt to also get email) - ServerOperationsProblem = 28,//and serious issue with server operations requiring intervention, - QuoteStatusAge = 29//quote stuck in same status too long + ReminderImminent = 12,//Reminder object, Advance notice setting tag conditional + ScheduledOnWorkorder = 13,//Workorder / WorkorderItemScheduledUser object, instant notification when current user is scheduled on a service workorder + ScheduledOnWorkorderImminent = 14,//Workorder / WorkorderItemScheduledUser object, advanced (settable) notification when current user's scheduled date/time is imminent + WorkorderCloseByPassed = 15,//##TODO Workorder object , need to rename this and rethink it in line with this is really related to not setting workorder to a finished or completed status type in time + OutsideServiceOverdue = 16,//Workorder object , WorkorderItemOutsideService created / updated, sets advance notice on due date tag filterable + OutsideServiceReceived = 17,//Workorder object , WorkorderItemOutsideService updated, instant notification when item received, tag filterable + PartRequestReceived = 18,//Workorder object / workorderitempartrequest updated, sent to person who requested when parts received back + NotifyHealthCheck = 19,//NO OBJECT, direct subscription to receive recurring daily notify system "ping" sent out at fixed time of 9am every day server local time + BackupStatus = 20,//NO OBJECT, direct subscription to receive results of last backup operation + CustomerServiceImminent = 21,//Workorder / WorkorderItemScheduledUser object, notice that scheduled service is due, can set advance notice, CUSTOMER gets delivery + PartRequested = 22,//Workorder object / workorderitempartrequest created tag filterable + WorkorderTotalExceedsThreshold = 23,//"the Andy" Workorder updated / created, based on balance total so conditional on DecValue + WorkorderStatusAge = 24,//Workorder object Created / Updated, conditional on exact status selected IdValue, Tags conditional, advance notice can be set + UnitWarrantyExpiry = 25,//Unit object created, advance notice can be used, tag conditional + UnitMeterReadingMultipleExceeded = 26,//UnitMeterReading object, Created, conditional on DecValue as the Multiple threshold, if passed then notifies + DefaultNotification = 27,//NO OBJECT old quick notification, refers now to any direct text notification internal or user to user used for system notifications (default delivers in app but user can opt to also get email) + ServerOperationsProblem = 28,//NO OBJECT and serious issue with server operations requiring intervention, + QuoteStatusAge = 29//Quote object Created / Updated, conditional on exact status selected IdValue, Tags conditional, advance notice can be set //NEW ITEMS REQUIRE translation KEYS