devdocs/todo.txt

@@ -3,8 +3,6 @@
 {"login": "OpsAdminLimited","password": "OpsAdminLimited"}
 
 
-todo: FAKER, is there a leak, do I need to dispose of it somehow, am I using it right?
-	(it appeared high in objects in allocated memory when investigating memory consumption)
 
 todo: static hunt, look for anything declared static that doesn't need to be
 

server/AyaNova/biz/AyaFormFieldDefinitions.cs

@@ -10,7 +10,7 @@ namespace AyaNova.Biz
 
     public static class AyaFormFieldDefinitions
     {
-
+        private static Dictionary<string, List<AyaFormFieldDefinition>> _ayaFormFields;
         public static List<string> AyaFormFieldDefinitionKeys
         {
             get
@@ -39,18 +39,16 @@ namespace AyaNova.Biz
 
         public static List<AyaFormFieldDefinition> AyaFormFields(string key)
         {
-            /*
+            //Initialize the static list here on first retrieval
-            *****************************  WARNING: Be careful here, if a standard field is hideable and also it's DB SCHEMA is  set to NON NULLABLE then the CLIENT end needs to set a default
+            if (_ayaFormFields == null)
+            {
+                _ayaFormFields = new Dictionary<string, List<AyaFormFieldDefinition>>();
+                /*  *****************************  WARNING: Be careful here, if a standard field is hideable and also it's DB SCHEMA is  set to NON NULLABLE then the CLIENT end needs to set a default
                     *****************************  Otherwise the hidden field can't be set and the object can't be saved EVER        
                 */
-            List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
-            //CoreBizObject add here
-            if (key == AyaType.Widget.ToString())
-            {
-
-
                 #region WIDGET_KEY
-
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetName", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetSerial", FieldKey = "Serial" });
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetDollarAmount", FieldKey = "DollarAmount" });
@@ -67,7 +65,6 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "Wiki", FieldKey = "Wiki" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Attachments", FieldKey = "Attachments" });
 
-
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetCustom1", FieldKey = "WidgetCustom1", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetCustom2", FieldKey = "WidgetCustom2", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetCustom3", FieldKey = "WidgetCustom3", IsCustomField = true });
@@ -84,13 +81,13 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetCustom14", FieldKey = "WidgetCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetCustom15", FieldKey = "WidgetCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WidgetCustom16", FieldKey = "WidgetCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.Widget.ToString(), l);
-                #endregion
                 }
+                #endregion widget
 
-            if (key == AyaType.User.ToString())
-            {
                 #region USER_KEY
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "UserEmployeeNumber", FieldKey = "EmployeeNumber" });
                     l.Add(new AyaFormFieldDefinition { TKey = "AuthorizationRoles", FieldKey = "Roles", Hideable = false });
@@ -117,14 +114,13 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "UserCustom14", FieldKey = "UserCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "UserCustom15", FieldKey = "UserCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "UserCustom16", FieldKey = "UserCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.User.ToString(), l);
-                #endregion
                 }
+                #endregion
 
-
-            if (key == AyaType.Customer.ToString())
-            {
                 #region Customer
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "CustomerNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -148,14 +144,13 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "CustomerCustom14", FieldKey = "CustomerCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "CustomerCustom15", FieldKey = "CustomerCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "CustomerCustom16", FieldKey = "CustomerCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.Customer.ToString(), l);
-                #endregion
                 }
+                #endregion
 
-
-            if (key == AyaType.HeadOffice.ToString())
-            {
                 #region HeadOffice
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "HeadOfficeNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -179,13 +174,13 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "HeadOfficeCustom14", FieldKey = "HeadOfficeCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "HeadOfficeCustom15", FieldKey = "HeadOfficeCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "HeadOfficeCustom16", FieldKey = "HeadOfficeCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.HeadOffice.ToString(), l);
-                #endregion
                 }
+                #endregion
 
-            if (key == AyaType.Contract.ToString())
-            {
                 #region Contract
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "ContractNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -209,14 +204,14 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "ContractCustom14", FieldKey = "ContractCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "ContractCustom15", FieldKey = "ContractCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "ContractCustom16", FieldKey = "ContractCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.Contract.ToString(), l);
-                #endregion
                 }
+                #endregion
 
-
-            if (key == AyaType.LoanUnit.ToString())
-            {
                 #region LoanUnit
+                {
+
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "LoanUnitNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -240,13 +235,14 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "LoanUnitCustom14", FieldKey = "LoanUnitCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "LoanUnitCustom15", FieldKey = "LoanUnitCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "LoanUnitCustom16", FieldKey = "LoanUnitCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.LoanUnit.ToString(), l);
-                #endregion
+
-            }
+                }
+                #endregion
 
-            if (key == AyaType.Part.ToString())
-            {
                 #region Part
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "PartNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -270,13 +266,15 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "PartCustom14", FieldKey = "PartCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "PartCustom15", FieldKey = "PartCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "PartCustom16", FieldKey = "PartCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.Part.ToString(), l);
-                #endregion
+
-            }
+                }
+                #endregion
 
-            if (key == AyaType.Project.ToString())
-            {
                 #region Project
+                {
+
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "ProjectNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -300,13 +298,14 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "ProjectCustom14", FieldKey = "ProjectCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "ProjectCustom15", FieldKey = "ProjectCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "ProjectCustom16", FieldKey = "ProjectCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.Project.ToString(), l);
-                #endregion
+
-            }
+                }
+                #endregion
 
-            if (key == AyaType.PurchaseOrder.ToString())
-            {
                 #region PurchaseOrder
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "PurchaseOrderNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -330,13 +329,14 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "PurchaseOrderCustom14", FieldKey = "PurchaseOrderCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "PurchaseOrderCustom15", FieldKey = "PurchaseOrderCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "PurchaseOrderCustom16", FieldKey = "PurchaseOrderCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.PurchaseOrder.ToString(), l);
-                #endregion
+
-            }
+                }
+                #endregion
 
-            if (key == AyaType.Unit.ToString())
-            {
                 #region Unit
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -360,13 +360,14 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitCustom14", FieldKey = "UnitCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitCustom15", FieldKey = "UnitCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitCustom16", FieldKey = "UnitCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.Unit.ToString(), l);
-                #endregion
+
-            }
+                }
+                #endregion
 
-            if (key == AyaType.UnitModel.ToString())
-            {
                 #region UnitModel
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitModelNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -390,13 +391,15 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitModelCustom14", FieldKey = "UnitModelCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitModelCustom15", FieldKey = "UnitModelCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "UnitModelCustom16", FieldKey = "UnitModelCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.UnitModel.ToString(), l);
-                #endregion
+
-            }
+                }
+                #endregion
 
-            if (key == AyaType.Vendor.ToString())
-            {
                 #region Vendor
+                {
+
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "VendorNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -420,15 +423,14 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "VendorCustom14", FieldKey = "VendorCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "VendorCustom15", FieldKey = "VendorCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "VendorCustom16", FieldKey = "VendorCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.Vendor.ToString(), l);
-                #endregion
+
                 }
+                #endregion
 
-
-
-            if (key == AyaType.WorkOrder.ToString())
-            {
                 #region WorkOrder
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderSerial", FieldKey = "Serial", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -452,15 +454,14 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderCustom14", FieldKey = "WorkOrderCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderCustom15", FieldKey = "WorkOrderCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderCustom16", FieldKey = "WorkOrderCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.WorkOrder.ToString(), l);
-                #endregion
+
                 }
+                #endregion
 
-
-
-             if (key == AyaType.WorkOrderItem.ToString())
-            {
                 #region WorkOrderItem
+                {
+                    List<AyaFormFieldDefinition> l = new List<AyaFormFieldDefinition>();
                     l.Add(new AyaFormFieldDefinition { TKey = "Name", FieldKey = "Name", Hideable = false });
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderItemNotes", FieldKey = "Notes" });
                     l.Add(new AyaFormFieldDefinition { TKey = "Active", FieldKey = "Active", Hideable = false });
@@ -484,12 +485,16 @@ namespace AyaNova.Biz
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderItemCustom14", FieldKey = "WorkOrderItemCustom14", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderItemCustom15", FieldKey = "WorkOrderItemCustom15", IsCustomField = true });
                     l.Add(new AyaFormFieldDefinition { TKey = "WorkOrderItemCustom16", FieldKey = "WorkOrderItemCustom16", IsCustomField = true });
-                return l;
+                    _ayaFormFields.Add(AyaType.WorkOrderItem.ToString(), l);
-                #endregion
-            }
-            //******************************************************
 
+                }
+                #endregion
+                //******************************************************
+            }
+
+            if (!_ayaFormFields.ContainsKey(key))
                 throw new System.ArgumentOutOfRangeException($"AyaFormFieldDefinitions: {key} is not valid");
+            return _ayaFormFields[key];
 
         }