diff --git a/.vscode/launch.json b/.vscode/launch.json index f994e0f9..ee6f9a8a 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -50,7 +50,7 @@ "AYANOVA_FOLDER_USER_FILES": "c:\\temp\\RavenTestData\\userfiles", "AYANOVA_FOLDER_BACKUP_FILES": "c:\\temp\\RavenTestData\\backupfiles", "AYANOVA_SERVER_TEST_MODE":"true", - "AYANOVA_SERVER_TEST_MODE_SEEDLEVEL":"small", + "AYANOVA_SERVER_TEST_MODE_SEEDLEVEL":"huge", "AYANOVA_SERVER_TEST_MODE_TZ_OFFSET":"-7", "AYANOVA_BACKUP_PG_DUMP_PATH":"C:\\data\\code\\PostgreSQLPortable_12.0\\App\\PgSQL\\bin\\" diff --git a/devdocs/todo.txt b/devdocs/todo.txt index 598fda6c..c8f21219 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -4,44 +4,17 @@ -todo: static hunt, look for anything declared static that doesn't need to be -todo: tag refcount - Move this into a procedure, it's apparently quite slow now that I can see the metrics +TODO: BIG UPDATE ALL GUTS - -todo: I might be using List<> too much when I should be using IEnumerable instead - read this: https://www.claudiobernasconi.ch/2013/07/22/when-to-use-ienumerable-icollection-ilist-and-list/ - -TODO: Why is this adding UTC bit to this query check the source code maybe something is up -Schema settings mean that pg will ignore any tz specification so in theory it's ignored, but... - -SELECT a.gid, a.xmin, a.created, a.exclusive, a.jobinfo, a.jobstatus, a.jobtype, a.name, a.objectid, a.objecttype, a.startafter, a.subtype -FROM aopsjob AS a -WHERE ((a.startafter < NOW() AT TIME ZONE 'UTC') AND (a.exclusive = @__exclusiveOnly_0)) AND (a.jobstatus = 1) -ORDER BY a.created -2020-05-27 12:51:57.2585|INFO|Microsoft.EntityFrameworkCore.Database.Command|Executed DbCommand (10ms) [Parameters=[@__exclusiveOnly_0='False'], CommandType='Text', CommandTimeout='30'] -SELECT a.gid, a.xmin, a.created, a.exclusive, a.jobinfo, a.jobstatus, a.jobtype, a.name, a.objectid, a.objecttype, a.startafter, a.subtype -FROM aopsjob AS a -WHERE ((a.startafter < NOW() AT TIME ZONE 'UTC') AND (a.exclusive = @__exclusiveOnly_0)) AND (a.jobstatus = 1) -ORDER BY a.created - -todo: Check all routes with datetime parameters, are they being used in a query parameter? - if so, then they need to be converted to UTC to query properly: - .Where(z => z.t >= tsStart.ToUniversalTime() - -todo: Are serial numbers working properly, I'm seeing gaps in widget but it could be because of unit testing - -todo: leave running check it does overnight backup properly +TODO: post to server and test todo: add backup turn off setting environment variable todo: add backup master time out setting environment variable -TODO: BIG UPDATE ALL GUTS -TODO: post to server and test todo: it would be very handy to say the least to be able to run raven locally in linux for testing here maybe virtual box, but I sure don't want to fuck up things, maybe need another computer, some cheap shitbox can test on? @@ -85,4 +58,9 @@ todo: API docs, make separate page for datalists and remove from api-response-fo DEPLOY AND TEST todo: Test backup on Linux - - going to need to run in vm I think maybe \ No newline at end of file + - going to need to run in vm I think maybe + + +MAYBE +todo: tag refcount + Move this into a procedure, it's apparently quite slow now that I can see the metrics diff --git a/server/AyaNova/biz/TagBiz.cs b/server/AyaNova/biz/TagBiz.cs index 24ad86e7..21fa5489 100644 --- a/server/AyaNova/biz/TagBiz.cs +++ b/server/AyaNova/biz/TagBiz.cs @@ -81,6 +81,9 @@ namespace AyaNova.Biz //I considered a circuit breaker / timeout here, but theoretically it should not be an issue //at some point it should not be a concurrency issue anymore //And this is not critical functionality requiring a transaction and locking + + //TODO: Move this into a stored procedure just like search keyword processing for efficiency + //it's likely not going to be an issue but still, it's not right to do it this way do { //START: Get tag word and concurrency token and count