Report render process manager v2.0
This commit is contained in:
@@ -1,5 +1,8 @@
|
||||
using System;
|
||||
using System.Collections.Concurrent;
|
||||
using System.Collections.Generic;
|
||||
using System.Diagnostics;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
using Microsoft.Extensions.Logging;
|
||||
|
||||
@@ -12,67 +15,150 @@ namespace AyaNova.Util
|
||||
/// also zombie process issues in linux etc, this just ensures it's safe
|
||||
/// This is triggered when a report is rendered
|
||||
/// </summary>
|
||||
internal static class ReportProcessorManager
|
||||
internal static class ReportRenderManager
|
||||
{
|
||||
internal static int ReporterProcessId { get; set; } = -1;
|
||||
internal static DateTime Started { get; set; }
|
||||
|
||||
internal async static Task EnsureReporterAvailableAsync(ILogger log)
|
||||
/*
|
||||
Use thread safe concurrent dictionary collection to manage up to AYANOVA_REPORT_RENDERING_MAX_INSTANCES
|
||||
(it's allowed to go slightly over, this is not ever going to be exactly right under heavy load, but it should always kill the old processes no matter what)
|
||||
|
||||
Render route controller checks for an available slot with the reportprocessormanager first "ProcessSlotAvailable"
|
||||
if there is no free slot it immediately callse Cleanup which looks for the oldest slot that is over the limit and attempts to shut it down, once shut down it returns true
|
||||
if there is no free slot and none are over the limit it returns false signifying try again
|
||||
|
||||
|
||||
If there *is* a free slot then it passes off to reportbiz as usual
|
||||
Report biz reserves a slot when launches the browser process with here by adding it to the dictionary "AddProcess(processid)"
|
||||
When the report is generated it will remove from the slot by calling into here "RemoveProcess(processId)"
|
||||
Remove from slot here will confirm the process is no longer running and if it is kill it or if it's not remove it from the collection
|
||||
|
||||
expired processes are removed by the act of tryign to get a new slot so in this way it still supports running super long reports overnight for example as long as there is no contention
|
||||
The other way was by a job that looks for expired processes but that would mean all old jobs would expire all the time so there would be an issue with huge reports never working
|
||||
|
||||
|
||||
*/
|
||||
|
||||
//thread safe collection for unordered items, optimized for single thread produce/consume (which is the norm here) but supports multithread produce / consume (which is needed for separate cleanup job)
|
||||
private static ConcurrentBag<ReportRenderInstanceInfo> _baginstances = new ConcurrentBag<ReportRenderInstanceInfo>();
|
||||
|
||||
public class ReportRenderInstanceInfo
|
||||
{
|
||||
Process reportProcess = ReporterProcess();
|
||||
if (reportProcess == null)
|
||||
public int ReporterProcessId { get; set; }
|
||||
public DateTime Started { get; set; }
|
||||
|
||||
public ReportRenderInstanceInfo(int processId)
|
||||
{
|
||||
return;
|
||||
ReporterProcessId = processId;
|
||||
Started = DateTime.UtcNow;
|
||||
}
|
||||
//await it's completion in the specified timeout
|
||||
int HardTimeout = ServerBootConfig.AYANOVA_REPORT_RENDERING_TIMEOUT;
|
||||
//don't wait forever, hard cap of 3 minutes regardless of setting
|
||||
if (HardTimeout > 180000) HardTimeout = 180000;
|
||||
bool keepOnWaiting = true;
|
||||
while (keepOnWaiting)
|
||||
}
|
||||
|
||||
|
||||
public static bool RenderSlotAvailable()
|
||||
{
|
||||
if (_baginstances.Count >= ServerBootConfig.AYANOVA_REPORT_RENDERING_MAX_INSTANCES)
|
||||
{
|
||||
//don't check continually
|
||||
await Task.Delay(500);
|
||||
//check process is still running
|
||||
if (reportProcess?.HasExited == false)
|
||||
//check for expired and remove
|
||||
var Instances = _baginstances.ToArray();
|
||||
ReportRenderInstanceInfo oldest = null;
|
||||
foreach (ReportRenderInstanceInfo i in Instances)
|
||||
{
|
||||
//time to kill it?
|
||||
if ((DateTime.UtcNow - Started).TotalMilliseconds > HardTimeout)
|
||||
if (oldest == null)
|
||||
{
|
||||
log.LogInformation($"Report processor did not complete in {HardTimeout}ms and will be force stopped");
|
||||
reportProcess.Kill();
|
||||
keepOnWaiting = false;
|
||||
oldest = i;
|
||||
continue;
|
||||
}
|
||||
if (i.Started < oldest.Started) oldest = i;
|
||||
}
|
||||
if (oldest != null)
|
||||
{
|
||||
try
|
||||
{
|
||||
var p = Process.GetProcessById(oldest.ReporterProcessId);
|
||||
if (p != null)
|
||||
{
|
||||
//try to kill it
|
||||
p.Kill();
|
||||
if (p?.HasExited == false) return false;//can't kill it so can't free up a slot
|
||||
}
|
||||
_baginstances.TryTake(out oldest);
|
||||
return true;//process that was there is now not there so while not perfect system we will consider it free
|
||||
|
||||
}
|
||||
catch (ArgumentException)
|
||||
{
|
||||
return true;//no process available / not running
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
log.LogDebug($"EnsureReporterAvailableAsync Reporter processor completed normally");
|
||||
keepOnWaiting = false;
|
||||
}
|
||||
};
|
||||
ReporterProcessId = -1;
|
||||
Started = DateTime.MinValue;
|
||||
return;
|
||||
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
internal static void RecordNewReportGeneratorProcess(int processId)
|
||||
|
||||
internal static void AddProcess(int processId)
|
||||
{
|
||||
ReporterProcessId = processId;
|
||||
Started = DateTime.UtcNow;
|
||||
_baginstances.Add(new ReportRenderInstanceInfo(processId));
|
||||
}
|
||||
|
||||
private static Process ReporterProcess()
|
||||
{
|
||||
if (ReporterProcessId == -1) return null;
|
||||
try
|
||||
{
|
||||
return Process.GetProcessById(ReporterProcessId);
|
||||
}
|
||||
catch (ArgumentException)
|
||||
{
|
||||
return null;//no process available / not running
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
// internal async static Task EnsureReporterAvailableAsync(ILogger log)
|
||||
// {
|
||||
// Process reportProcess = ReporterProcess();
|
||||
// if (reportProcess == null)
|
||||
// {
|
||||
// return;
|
||||
// }
|
||||
// //await it's completion in the specified timeout
|
||||
// int HardTimeout = ServerBootConfig.AYANOVA_REPORT_RENDERING_TIMEOUT;
|
||||
// //don't wait forever, hard cap of 3 minutes regardless of setting
|
||||
// if (HardTimeout > 180000) HardTimeout = 180000;
|
||||
// bool keepOnWaiting = true;
|
||||
// while (keepOnWaiting)
|
||||
// {
|
||||
// //don't check continually
|
||||
// await Task.Delay(500);
|
||||
// //check process is still running
|
||||
// if (reportProcess?.HasExited == false)
|
||||
// {
|
||||
// //time to kill it?
|
||||
// if ((DateTime.UtcNow - Started).TotalMilliseconds > HardTimeout)
|
||||
// {
|
||||
// log.LogInformation($"Report processor did not complete in {HardTimeout}ms and will be force stopped");
|
||||
// reportProcess.Kill();
|
||||
// keepOnWaiting = false;
|
||||
// }
|
||||
// }
|
||||
// else
|
||||
// {
|
||||
// log.LogDebug($"EnsureReporterAvailableAsync Reporter processor completed normally");
|
||||
// keepOnWaiting = false;
|
||||
// }
|
||||
// };
|
||||
// ReporterProcessId = -1;
|
||||
// Started = DateTime.MinValue;
|
||||
// return;
|
||||
// }
|
||||
|
||||
// internal static void RecordNewReportGeneratorProcess(int processId)
|
||||
// {
|
||||
// ReporterProcessId = processId;
|
||||
// Started = DateTime.UtcNow;
|
||||
// }
|
||||
|
||||
// private static Process ReporterProcess()
|
||||
// {
|
||||
// if (ReporterProcessId == -1) return null;
|
||||
// try
|
||||
// {
|
||||
// return Process.GetProcessById(ReporterProcessId);
|
||||
// }
|
||||
// catch (ArgumentException)
|
||||
// {
|
||||
// return null;//no process available / not running
|
||||
// }
|
||||
// }
|
||||
|
||||
|
||||
/*
|
||||
|
||||
Reference in New Issue
Block a user