diff --git a/devdocs/todo.txt b/devdocs/todo.txt index c837b323..e7674980 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -1,8 +1,7 @@ PRIORITY - ALWAYS Lowest level stuff first =-=-=-=- - todo: server bizobjectnamefetcherdirect isn't handling workorders properly (or other serialized objects) - - adde special handling if the name of the "name" column is "serial" or maybe can just run a special query instead? + todo: check non-ops user can login during seeding operation todo: BizRoles.cs seems to get hammered on every single request, is it efficient? - Why is it not cached in some way? diff --git a/server/AyaNova/biz/BizObjectNameFetcherDirect.cs b/server/AyaNova/biz/BizObjectNameFetcherDirect.cs index a9d22819..63d3f6f5 100644 --- a/server/AyaNova/biz/BizObjectNameFetcherDirect.cs +++ b/server/AyaNova/biz/BizObjectNameFetcherDirect.cs @@ -3,7 +3,7 @@ namespace AyaNova.Biz //Turn a type and ID into a displayable name //this version uses a direct DataReader for performance in tight loops (search) - //Used by search + //Used by search and eventlog processor internal static class BizObjectNameFetcherDirect { @@ -20,6 +20,8 @@ namespace AyaNova.Biz { return "-"; } + + string TABLE = string.Empty; string COLUMN = "name"; //CoreBizObject add here BUT ONLY ADD IF AYATYPE NAME DIFFERS FROM TABLE NAME OR NO NAME FIELD AS PRIMARY NAME-LIKE COLUMN @@ -43,6 +45,18 @@ namespace AyaNova.Biz cmd.CommandText = $"SELECT m.serial FROM aworkorder AS m WHERE m.id = {id} LIMIT 1"; using (var dr = cmd.ExecuteReader()) return dr.Read() ? dr.GetInt64(0).ToString() : "-"; + //Not sure what to return here, defaulting to nothing for now + case AyaType.WorkOrderItem: + case AyaType.WorkOrderItemExpense: + case AyaType.WorkOrderItemLabor: + case AyaType.WorkOrderItemLoan: + case AyaType.WorkOrderItemPart: + case AyaType.WorkOrderItemPartRequest: + case AyaType.WorkOrderItemScheduledUser: + case AyaType.WorkOrderItemTask: + case AyaType.WorkOrderItemTravel: + case AyaType.WorkOrderItemUnit: + return "-"; default: TABLE = "a" + aytype.ToString().ToLowerInvariant(); break;