case 4716 - pick-list search text passed as SQL parameters

PickListSqlBuilder put the search text and the tag search text into the SQL
inside quotes with no escaping, reachable by any login (security review F18);
an apostrophe in a search also made the query fail. The builder now writes
@plq / @pltag and PickListFetcher adds them as Npgsql parameters (same %text%
match; wildcards typed by the user still apply).

Changelog: searching selection lists for text with an apostrophe now works.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-24 12:28:43 -07:00
parent e58ab2c100
commit b1944b7ca3
5 changed files with 17 additions and 9 deletions

View File

@@ -34,6 +34,7 @@ IN PROGRESS
**Fixed**
- Server: searching selection lists for text that contains an apostrophe (for example a name like O'Brien) now works.
- Server: hardened data table filter handling of number and role filter values.
- Server: data table date filters for "greater than or equal", "less than" and "not equal" could include or exclude records on the boundary of the selected date.
- Server: the database connection used for administrative operations is now built correctly when the database name also appears elsewhere in the connection setting.