diff --git a/devdocs/todo.txt b/devdocs/todo.txt index 33c32a8a..274cabdc 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -4,14 +4,6 @@ eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOiIxNTcxODU5OTU0IiwiZXhwIjoiMTU3MjQ ## IMMEDIATE ITEMS -Need to add separate role for mini to datalist because mini is used for picklists and everyone sb able to fetch a picklist in most cases but not the full list in some cases -Need to use the authorizationroles already set up for the lists so that I'm not duplicating effort - -Make up the USER datalists - -DataList object naming scheme, should it be prepended so they all align well and are easy to spot in the project or since they are exposed should it not? - - Cadillac problem? - INTEGRATION TEST UPDATE Update tests when appropriate (when it's working fully and not mocked) diff --git a/server/AyaNova/DataList/TestWidgetDataList.cs b/server/AyaNova/DataList/TestWidgetDataList.cs index 28093a3d..a6ab0e38 100644 --- a/server/AyaNova/DataList/TestWidgetDataList.cs +++ b/server/AyaNova/DataList/TestWidgetDataList.cs @@ -8,10 +8,11 @@ namespace AyaNova.DataList public TestWidgetDataList() { ListKey = nameof(TestWidgetDataList); - SQLFrom = "from awidget left outer join auser on (awidget.userid=auser.id)"; - FullListAllowedRoles = AuthorizationRoles.AllInternalStaff;//anyone but clients and subcontractors (just for test) - MiniListAllowedRoles = AuthorizationRoles.All;//anyone (so can select on forms) DefaultListObjectType = AyaType.Widget; + SQLFrom = "from awidget left outer join auser on (awidget.userid=auser.id)"; + FullListAllowedRoles = BizRoles.GetRoleSet(DefaultListObjectType).ReadFullRecord; + MiniListAllowedRoles = AuthorizationRoles.All;//anyone (so can select on forms) + DefaultDataListDisplayTemplate = @" { ""full"":[""widgetname"",""widgetserial"",""widgetdollaramount"",""widgetroles"",""widgetstartdate"",""widgetactive"",""username""], diff --git a/server/AyaNova/DataList/TestWidgetUserEmailDataList.cs b/server/AyaNova/DataList/TestWidgetUserEmailDataList.cs index 715980e7..f3e56e18 100644 --- a/server/AyaNova/DataList/TestWidgetUserEmailDataList.cs +++ b/server/AyaNova/DataList/TestWidgetUserEmailDataList.cs @@ -17,7 +17,7 @@ namespace AyaNova.DataList { ListKey = nameof(TestWidgetUserEmailDataList); SQLFrom = "from awidget left outer join auser on (awidget.userid=auser.id) left outer join auseroptions on (auser.id=auseroptions.userid)"; - FullListAllowedRoles = AuthorizationRoles.AllInternalStaff;//anyone but clients and subcontractors (just for test) + FullListAllowedRoles = BizRoles.GetRoleSet(DefaultListObjectType).ReadFullRecord; MiniListAllowedRoles = AuthorizationRoles.AllExceptCustomers;//anyone but clients who shouldn't see users email addresses (so can select on forms) DefaultListObjectType = AyaType.Widget; DefaultDataListDisplayTemplate = @" diff --git a/server/AyaNova/DataList/UserDataList.cs b/server/AyaNova/DataList/UserDataList.cs index bc6a8865..fa4e5e57 100644 --- a/server/AyaNova/DataList/UserDataList.cs +++ b/server/AyaNova/DataList/UserDataList.cs @@ -10,7 +10,7 @@ namespace AyaNova.DataList DefaultListObjectType = AyaType.User; ListKey = nameof(UserDataList); SQLFrom = "from auser"; - FullListAllowedRoles = BizRoles.GetRoleSet(DefaultListObjectType).ReadFullRecord;//anyone but clients and subcontractors (just for test) + FullListAllowedRoles = BizRoles.GetRoleSet(DefaultListObjectType).ReadFullRecord; MiniListAllowedRoles = AuthorizationRoles.All;//anyone (so can select on forms) DefaultDataListDisplayTemplate = @" {