From aa690bd97a43a4f83e7ecc2fd4c0032f4c214537 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Wed, 18 Mar 2020 21:59:04 +0000 Subject: [PATCH] --- devdocs/specs/core-tags.txt | 2 +- server/AyaNova/Controllers/TagListController.cs | 10 +++++----- server/AyaNova/biz/TagUtil.cs | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/devdocs/specs/core-tags.txt b/devdocs/specs/core-tags.txt index 7507d167..5445d881 100644 --- a/devdocs/specs/core-tags.txt +++ b/devdocs/specs/core-tags.txt @@ -81,7 +81,7 @@ TAG GROUP DEPRECATED 2018-12-05 If a tag is deleted it must be removed from any tag groups and if there are no other items in that tag group then the tag group must be deleted as well?? - Or maybe is just an empty group with a warning symbol in ui Tag groups will become a major way to save filters for things because a lot of filtering will be by tags so this should be a solid feature. - - RETRIEVAL / PICKLISTS: need to modify the tag picklist to optionally return TAGGROUP names as well as identify they are group so UI can feature differently + - RETRIEVAL / LISTS: need to modify the tag list to optionally return TAGGROUP names as well as identify they are group so UI can feature differently FILTERING AND SORTING BY TAG-GROUP - All code that filters and sorts by tag should accept a tag group as a separate type of input and dynamically build the tag filter list from the group and individual tags separately diff --git a/server/AyaNova/Controllers/TagListController.cs b/server/AyaNova/Controllers/TagListController.cs index 02c5031e..230324c5 100644 --- a/server/AyaNova/Controllers/TagListController.cs +++ b/server/AyaNova/Controllers/TagListController.cs @@ -12,7 +12,7 @@ namespace AyaNova.Api.Controllers { /// - /// Enum pick list controller + /// /// [ApiController] [ApiVersion("8.0")] @@ -41,19 +41,19 @@ namespace AyaNova.Api.Controllers /// - /// Get tag picklist + /// Get tag list /// /// The query to filter the returned list by /// Filtered list (maximum 25 items are returned for any query) - [HttpGet("picklist")] - public async Task GetPickList([FromQuery]string query) + [HttpGet("list")] + public async Task GetList([FromQuery]string query) { if (!serverState.IsOpen) { return StatusCode(503, new ApiErrorResponse(ApiErrorCode.API_CLOSED, null, serverState.Reason)); } - return Ok(ApiOkResponse.Response(await TagUtil.PickListFilteredAsync(ct, query), true)); + return Ok(ApiOkResponse.Response(await TagUtil.TagListFilteredAsync(ct, query), true)); } diff --git a/server/AyaNova/biz/TagUtil.cs b/server/AyaNova/biz/TagUtil.cs index 3703eb0e..0640a8d9 100644 --- a/server/AyaNova/biz/TagUtil.cs +++ b/server/AyaNova/biz/TagUtil.cs @@ -157,7 +157,7 @@ namespace AyaNova.Biz //Pick list for driving pick list route //going with contains for now as I think it's more useful in the long run and still captures startswith intent by user - public static async Task> PickListFilteredAsync(AyContext ct, string q) + public static async Task> TagListFilteredAsync(AyContext ct, string q) { //This path is intended for internal use and accepts that there may not be a filter specified //however the client will always require a filter to display a tag list for choosing from