From a6156d09aa796082bc3e6b9d92bdfcf5ac81a0b0 Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Mon, 20 Jan 2020 21:10:00 +0000
Subject: [PATCH]

---
 devdocs/todo.txt                | 9 +++++++++
 server/AyaNova/biz/WidgetBiz.cs | 6 ++++++
 2 files changed, 15 insertions(+)

diff --git a/devdocs/todo.txt b/devdocs/todo.txt
index a3fecbec..ee88c63f 100644
--- a/devdocs/todo.txt
+++ b/devdocs/todo.txt
@@ -8,6 +8,15 @@ eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOiIxNTcxODU5OTU0IiwiZXhwIjoiMTU3MjQ
 Continue work on widget->user->email list
 	- working now on turning it into proper object return json
 
+TODO: Grid filters for multi join tables
+	- Going to need a SOURCE of *all* possible fields for selecting to filter and sort in a multi table list
+	- I think the objectfielddefinitions is only part of the equation
+	- Not really done with lists until this is sorted out
+	- Can't just filter on the presentation fields, maybe you want to present that way but want to filter on an unshown field
+	- So maybe their's another step back where there is a master list of all fields for a list to choose from beyond the objectfielddefinitions?
+		- Or maybe my example one is just not what would normally be used?
+
+
 GRID LISTS TODO NOW:
 	- Make a joined table list for development 	
 		- Widget list with User and their email
diff --git a/server/AyaNova/biz/WidgetBiz.cs b/server/AyaNova/biz/WidgetBiz.cs
index a308849e..e6e0e69d 100644
--- a/server/AyaNova/biz/WidgetBiz.cs
+++ b/server/AyaNova/biz/WidgetBiz.cs
@@ -491,6 +491,12 @@ namespace AyaNova.Biz
                         //flag to handle first column which has no display value, just an id instead
                         bool isFirstDFColumn=true;
                         //Iterate object fields, build return row list as required
+
+                        //WAIT A SECOND, this is not correct, we are meant to return the template fields only, not all the fields in the objectfieldefinition which is a superset of the template
+                        //instead it needs to iterate the *template* (but do the DF field first on it's own) and only grab the data that's in the template
+                        //TEST THIS BY ADDING SUPERFLOUS FIELD TO THE OBJECTFIELDEFINITION THAT ISN'T IN THE TEMPLATE
+                        //See the select builder, IIRC it already does select only the fields required, it's probably just this block of code below that needs adapting
+
                         //INSERT INTO THE RETURN ROWS LIST
                         foreach (AyaObjectFieldDefinition f in AyaObjectFields)
                         {