From 83f238702d84fab0fbb9cf973818eee643e1bc5e Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Thu, 18 Feb 2021 20:39:22 +0000 Subject: [PATCH] --- server/AyaNova/biz/PickListBiz.cs | 11 ++++++++++- server/AyaNova/biz/PurchaseOrderBiz.cs | 3 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/server/AyaNova/biz/PickListBiz.cs b/server/AyaNova/biz/PickListBiz.cs index 3311ab93..6c7406c1 100644 --- a/server/AyaNova/biz/PickListBiz.cs +++ b/server/AyaNova/biz/PickListBiz.cs @@ -143,8 +143,17 @@ namespace AyaNova.Biz //used to populate UI with picklist format display for items internal async Task GetTemplatedNameAsync(AyaType ayaType, long id, string variant, ILogger log) { + //short circuit for empty types + if (id == 0) + { + return string.Empty; + } long[] preIds = { id }; var PickList = PickListFactory.GetAyaPickList(ayaType); + + if (log == null) + log = AyaNova.Util.ApplicationLogging.CreateLogger("PickListBiz::GetTemplatedNameAsync"); + //Autocomplete and tagonly query terms now set for consumption by PickListFetcher, ready to fetch... List items = await PickListFetcher.GetResponseAsync(PickList, null, null, true, preIds, variant, ct, log); if (items.Count == 0) @@ -154,7 +163,7 @@ namespace AyaNova.Biz return items[0].Name; } - + //get picklist templates, basically all the object types that support picklists internal List GetListOfAllPickListTypes(long translationId) { diff --git a/server/AyaNova/biz/PurchaseOrderBiz.cs b/server/AyaNova/biz/PurchaseOrderBiz.cs index 680a1c79..a67335f4 100644 --- a/server/AyaNova/biz/PurchaseOrderBiz.cs +++ b/server/AyaNova/biz/PurchaseOrderBiz.cs @@ -108,8 +108,9 @@ namespace AyaNova.Biz //populate names for client ui var pl= new PickListBiz(ct,UserId,UserTranslationId,CurrentUserRoles); + var log= AyaNova.Util.ApplicationLogging.CreateLogger("PickListBiz::GetTemplatedNameAsync"); foreach(PurchaseOrderItem item in ret.Items){ - item.PartName= await pl.GetPickListAsync() + item.PartName= await pl.GetTemplatedNameAsync(AyaType.Part,item.PartId,null,log); } if (logTheGetEvent && ret != null) await EventLogProcessor.LogEventToDatabaseAsync(new Event(UserId, id, BizType, AyaEvent.Retrieved), ct);