From 7ab06a82afbcc5f20bd69ca600e6a1c3d302445a Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Tue, 22 Oct 2019 23:05:36 +0000
Subject: [PATCH]

---
 .vscode/launch.json       | 35 +++++++++++++++++++++--------------
 devdocs/todo.txt          |  6 +++++-
 server/AyaNova/Program.cs |  1 +
 server/AyaNova/Startup.cs |  2 +-
 4 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 0e208a45..17ec1dc0 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -16,20 +16,27 @@
       "cwd": "${workspaceFolder}/server/AyaNova",
       "stopAtEntry": false,
       "internalConsoleOptions": "openOnSessionStart",
-      "launchBrowser": {
-        "enabled": true,
-        "args": "${auto-detect-url}/api/v8/",
-        "windows": {
-          "command": "cmd.exe",
-          "args": "/C start http://localhost:7575/api/v8/"
-        },
-        "osx": {
-          "command": "open"
-        },
-        "linux": {
-          "command": "xdg-open"
-        }
-      },
+       // Enable launching a web browser when ASP.NET Core starts. For more information: https://aka.ms/VSCode-CS-LaunchJson-WebBrowser
+       //this needs to be tweaked probably
+       //https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#starting-a-web-browser
+       "serverReadyAction": {
+        "action": "openExternally",
+        "pattern": "^\\s*Now listening on:\\s+(https?://\\S+)"                
+    },
+      // "launchBrowser": {
+      //   "enabled": true,
+      //   "args": "${auto-detect-url}/api/v8/",
+      //   "windows": {
+      //     "command": "cmd.exe",
+      //     "args": "/C start http://localhost:7575/api/v8/"
+      //   },
+      //   "osx": {
+      //     "command": "open"
+      //   },
+      //   "linux": {
+      //     "command": "xdg-open"
+      //   }
+      // },
       "env": {
         "ASPNETCORE_ENVIRONMENT": "Development",
         "AYANOVA_JWT_SECRET": "UNLICENSED5G*QQJ8#bQ7$Xr_@sXfHq4",
diff --git a/devdocs/todo.txt b/devdocs/todo.txt
index 57d5906d..792e960a 100644
--- a/devdocs/todo.txt
+++ b/devdocs/todo.txt
@@ -16,7 +16,11 @@ UPDATE all the things before commencing work
 - Find and read changes for 3.1 dotnet core and Note that that above is for v2.2 my controllers appear to date from the v1 .net core era and I will need to then move them to the .netcore 3.1 era changes 
 	- This is important and worth doing to make sure everything will work going forward (the swashbuckle [apicontroller] attribute debacle is proof of this)
 
-- Should not process jobs during boot, maybe serverstate=booting would be useful here?
+- Make the browser launch again, s
+- 2019-10-22 15:43:22.6844|INFO|Seeder|SEEDER: Seed data level - SmallOneManShopTrialDataSet, timeZoneOffset - -7
+- Add automated test to retrieve a manual page to ensure it's working
+- Add automated test to retrieve metrics to know it's working
+- Add automated test to retrieve apiroot page to know it's working
 
 -------------------------------------------------------------------------------------------------------------------------------------
 Need a sprint to get to a fully testable client with entry form, list and as much as possible all features from COMMON-* specs list 
diff --git a/server/AyaNova/Program.cs b/server/AyaNova/Program.cs
index 6a34013e..0fca3ef9 100644
--- a/server/AyaNova/Program.cs
+++ b/server/AyaNova/Program.cs
@@ -35,6 +35,7 @@ namespace AyaNova
             #region Initialize Logging                     
             //NOTE: there is a logging issue that breaks all this with .net 3.1 hostbuilder vs webhostbuilder but webhostbuilder will be deprecated so we need to work around it
             //the discussion about that is here: https://github.com/aspnet/AspNetCore/issues/9337
+            //I think I worked around it
 
             //NLOG OFFICIAL GUIDELINES FOR .net core 3.x  https://github.com/NLog/NLog/wiki/Getting-started-with-ASP.NET-Core-3
 
diff --git a/server/AyaNova/Startup.cs b/server/AyaNova/Startup.cs
index bd5fd77f..73fee081 100644
--- a/server/AyaNova/Startup.cs
+++ b/server/AyaNova/Startup.cs
@@ -56,7 +56,7 @@ namespace AyaNova
 
         private readonly ILogger _newLog;
 
-        private readonly ILogger<Startup>x_log;
+       // private readonly ILogger<Startup>x_log;
         private string _connectionString = "";
         private readonly Microsoft.AspNetCore.Hosting.IWebHostEnvironment _hostingEnvironment;