diff --git a/devdocs/todo.txt b/devdocs/todo.txt index 8d7a3b0c..f75b38af 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -9,6 +9,9 @@ TODO: DataFilter how to distinguish between filtering on specific ID value or on - Might need to add a filter on ID type of thing maybe? - Wait and see...YAGNI scenario maybe +PagedResponse url is not including all the parameters like the datalisttype so technically it's invalid + - fix the url so it includes the full query string parameters that matter and are not paging related + INTEGRATION TEST UPDATE Update tests when appropriate (when it's working fully and not mocked) UPDATE SPEC DOCS with new format and names etc or at least remove nonsense as necessary diff --git a/server/AyaNova/Controllers/DataListController.cs b/server/AyaNova/Controllers/DataListController.cs index 6f21ec07..a6bbdc6c 100644 --- a/server/AyaNova/Controllers/DataListController.cs +++ b/server/AyaNova/Controllers/DataListController.cs @@ -7,6 +7,8 @@ using AyaNova.Api.ControllerHelpers; using AyaNova.Biz; using AyaNova.DataList; using System.Threading.Tasks; +using Newtonsoft.Json; +using Newtonsoft.Json.Linq; namespace AyaNova.Api.Controllers { @@ -23,6 +25,7 @@ namespace AyaNova.Api.Controllers private readonly ApiServerState serverState; + /// /// ctor /// diff --git a/server/AyaNova/Startup.cs b/server/AyaNova/Startup.cs index 58c11f3f..a62de9dd 100644 --- a/server/AyaNova/Startup.cs +++ b/server/AyaNova/Startup.cs @@ -81,6 +81,9 @@ namespace AyaNova config.Filters.Add(new AyaNova.Api.ControllerHelpers.ApiCustomExceptionFilter(_newLog)); }); + + + //Prevent default model binding automatic 400 page so we can consistently show *our* error to our specs //https://docs.microsoft.com/en-us/aspnet/core/web-api/index?view=aspnetcore-3.1#automatic-http-400-responses MvcBuilder.ConfigureApiBehaviorOptions(options => @@ -89,9 +92,12 @@ namespace AyaNova }); _newLog.LogDebug("BOOT: init JSON"); + MvcBuilder.AddNewtonsoftJson(options => { + options.SerializerSettings.Formatting = Newtonsoft.Json.Formatting.None; options.SerializerSettings.DateTimeZoneHandling = Newtonsoft.Json.DateTimeZoneHandling.Utc; + }); @@ -134,7 +140,7 @@ namespace AyaNova bool LOG_SENSITIVE_DATA = false; #if (DEBUG) - LOG_SENSITIVE_DATA = false; + LOG_SENSITIVE_DATA = false; #endif