admin/raven
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

case 4224

Browse Source
This commit is contained in:
John Cardinal
2022-10-27 22:02:47 +00:00
parent b9b52c958c
commit 460af91bf4
4 changed files with 11 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docs/8.0/ayanova/docs/changelog.md
View File

@@ -6,7 +6,13 @@ The most recent changes are written in the AyaNova manual [hosted on our website
## 2022 ## 2022
### AyaNova 8.0.18 (2022-10-25) ### AyaNova 8.0.19 (2022-XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX)
#### Fixed
- Server: With generated sample data only, not production use, Work order and Quote could potententially not show as locked when set to a locking status
### AyaNova 8.0.18 (2022-10-27)
#### Fixed #### Fixed

2
server/AyaNova/biz/QuoteBiz.cs
View File

@@ -5231,7 +5231,7 @@ namespace AyaNova.Biz
var wid = await GetQuoteIdFromRelativeAsync(ayaType, id, ct); var wid = await GetQuoteIdFromRelativeAsync(ayaType, id, ct);
var stat = await ct.QuoteState.AsNoTracking() var stat = await ct.QuoteState.AsNoTracking()
.Where(z => z.QuoteId == wid.ParentId) .Where(z => z.QuoteId == wid.ParentId)
.OrderByDescending(z => z.Created) .OrderByDescending(z => z.Id)//case 4224
.Take(1) .Take(1)
.FirstOrDefaultAsync(); .FirstOrDefaultAsync();

2
server/AyaNova/biz/UnitMeterReadingBiz.cs
View File

@@ -230,7 +230,7 @@ namespace AyaNova.Biz
var lastMeterReading = await ct.UnitMeterReading.AsNoTracking() var lastMeterReading = await ct.UnitMeterReading.AsNoTracking()
.Where(x => x.UnitId == proposedObj.UnitId) .Where(x => x.UnitId == proposedObj.UnitId)
.OrderByDescending(z => z.MeterDate) .OrderByDescending(z => z.MeterDate)//note: if in future there is an issue with not being most recent this sb id instead of date but if date is manually updatable then no
.Skip(1)//because it's already saved this current reading by the time it gets here .Skip(1)//because it's already saved this current reading by the time it gets here
.Take(1) .Take(1)
.FirstOrDefaultAsync(); .FirstOrDefaultAsync();

20
server/AyaNova/biz/WorkOrderBiz.cs
View File

@@ -7034,7 +7034,7 @@ namespace AyaNova.Biz
var wid = await GetWorkOrderIdFromRelativeAsync(ayaType, id, ct); var wid = await GetWorkOrderIdFromRelativeAsync(ayaType, id, ct);
var stat = await ct.WorkOrderState.AsNoTracking() var stat = await ct.WorkOrderState.AsNoTracking()
.Where(z => z.WorkOrderId == wid.ParentId) .Where(z => z.WorkOrderId == wid.ParentId)
.OrderByDescending(z => z.Created) .OrderByDescending(z => z.Id)//case 4224
.Take(1) .Take(1)
.FirstOrDefaultAsync(); .FirstOrDefaultAsync();
@@ -7047,26 +7047,8 @@ namespace AyaNova.Biz
return mCurrentWorkOrderStatus; return mCurrentWorkOrderStatus;
} }
// internal static async Task<WorkOrderStatus> GetCurrentWorkOrderStatusFromRelatedAsync(AyaType ayaType, long id, AyContext ct)
// {
// //static method
// var wid = await GetWorkOrderIdFromRelativeAsync(ayaType, id, ct);
// var stat = await ct.WorkOrderState.AsNoTracking()
// .Where(z => z.WorkOrderId == wid.WorkOrderId)
// .OrderByDescending(z => z.Created)
// .Take(1)
// .FirstOrDefaultAsync();
// //no state set yet?
// if (stat == null)
// { //default
// return new WorkOrderStatus() { Id = -1, Locked = false, Completed = false };
// }
// return await ct.WorkOrderStatus.AsNoTracking().Where(z => z.Id == stat.WorkOrderStatusId).FirstAsync();//this should never not be null
// }
#endregion utility #endregion utility