From 3ea44f93e8742221002f45e83a147d11462c3c90 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Thu, 24 Sep 2020 19:15:55 +0000 Subject: [PATCH] --- dist/docker/linux-x64/ayanovadocker/dockerfile | 2 +- server/AyaNova/biz/ReportBiz.cs | 17 +++++++++-------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/dist/docker/linux-x64/ayanovadocker/dockerfile b/dist/docker/linux-x64/ayanovadocker/dockerfile index c309ecc3..07e3ead5 100644 --- a/dist/docker/linux-x64/ayanovadocker/dockerfile +++ b/dist/docker/linux-x64/ayanovadocker/dockerfile @@ -1,4 +1,4 @@ -FROM mcr.microsoft.com/dotnet/core/aspnet:3.1-alpine +FROM mcr.microsoft.com/dotnet/aspnet:5.0-alpine WORKDIR /app COPY ./files . RUN apk add postgresql-client diff --git a/server/AyaNova/biz/ReportBiz.cs b/server/AyaNova/biz/ReportBiz.cs index 1a51b20d..c7ca89b2 100644 --- a/server/AyaNova/biz/ReportBiz.cs +++ b/server/AyaNova/biz/ReportBiz.cs @@ -425,7 +425,7 @@ namespace AyaNova.Biz using (var page = await browser.NewPageAsync()) { //see catch block - var ChromiumProcessID = browser.Process.Id; + // var ChromiumProcessID = browser.Process.Id; try { @@ -676,13 +676,14 @@ namespace AyaNova.Biz log.LogDebug($"Closing browser"); await browser.CloseAsync(); - //this probably isn't absolutely necessary but insurance - var process = System.Diagnostics.Process.GetProcessById(ChromiumProcessID); - if (ChromiumProcessID > 0 && process?.HasExited == false) - { - log.LogError($"Error during render, Chromium process (pid {ChromiumProcessID}) still active, forcing it to stop now"); - process.Kill(); - } + //this probably isn't absolutely necessary but insurance + //bugbug: crashes linux? + // var process = System.Diagnostics.Process.GetProcessById(ChromiumProcessID); + // if (ChromiumProcessID > 0 && process?.HasExited == false) + // { + // log.LogError($"Error during render, Chromium process (pid {ChromiumProcessID}) still active, forcing it to stop now"); + // process.Kill(); + // } } } }