From 3c3c52bee482f652a2f35f319cdbfb4a2e900abc Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Thu, 17 Jan 2019 00:52:16 +0000 Subject: [PATCH] --- devdocs/todo.txt | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/devdocs/todo.txt b/devdocs/todo.txt index 49111fa3..1fadd694 100644 --- a/devdocs/todo.txt +++ b/devdocs/todo.txt @@ -13,14 +13,8 @@ Do the stuff in the Client todo first then back to the server as required. SERVER - - (CODED, NOT TESTED) Add validation of custom fields in widget - - Test? Hard to test when it affects so many other tests but perhaps I can slog through and make one of the custom fields required and modify all the widget tests to include that field - - Do the test after the next item below as it will affect all existing tests - - Add validation of required fields that are not custom in widget - - Test? Same as above really, so maybe code it all at once - - - Then do the things all the way down to JWT issues below + - DO ALL THE THINGS!!!! - all the way down to DOCS MANUAL below which isn't urgent and go back to client stuff - PickListFetcher: WTF? It has a reference to widgetbiz in it, isn't this a generic class?? @@ -35,18 +29,9 @@ SERVER - Error messages from the API, shouldn't they be localized?? - - CUSTOM FIELDS?! - - CUSTOM FIELDS (case 3426) - - https://rockfish.ayanova.com/default.htm#!/rfcaseEdit/3426 - - https://rockfish.ayanova.com/default.htm#!/rfcaseEdit/1442 - - This wasn't worked out and needs to be done now - - Work this out in the core-custom-fields.txt doc in specifications and document it there before any coding - - Implement it with the widget + - USER object add the custom fields code as in Widget - - - - - JWT issues?? + - JWT issues?? - potentially lots of issues, look into it as using them kind of mindlessly right now. It could be simply that people are attempting to do other things I am not but to be safe read the criticism and see if any of it applies: http://cryto.net/~joepie91/blog/2016/06/13/stop-using-jwt-for-sessions/ @@ -61,8 +46,15 @@ SERVER - It's been a while, some of the modules date to last fall - Test on OPS server + - WTF is this shit when logging is set to normal: + 2019-01-16 16:13:03.4808|WARN|Microsoft.EntityFrameworkCore.Query|Query: '(from Widget _4 in DbSet select [_4]).Skip(__p_1).Take(__p_2)' uses a row limiting operation (Skip/Take) without OrderBy which may lead to unpredictable results. + 2019-01-16 16:13:03.6455|WARN|Microsoft.EntityFrameworkCore.Query|Query: '(from Widget _4 in DbSet select [_4]).Skip(__p_1).Take(__p_2)' uses a row limiting operation (Skip/Take) without OrderBy which may lead to unpredictable results. + +=-=-=-=-=-=- +Less urgent things... + DOCS / MANUAL - Disable google fonts for manual / docs generator: - first need to upgrade to latest mkdocs AND material theme for mkdocs