diff --git a/server/AyaNova/Controllers/CustomerController.cs b/server/AyaNova/Controllers/CustomerController.cs
index e2cf6b9e..14e2c882 100644
--- a/server/AyaNova/Controllers/CustomerController.cs
+++ b/server/AyaNova/Controllers/CustomerController.cs
@@ -3,8 +3,6 @@ using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Routing;
using Microsoft.AspNetCore.Authorization;
-
-using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging;
using AyaNova.Models;
using AyaNova.Api.ControllerHelpers;
@@ -39,81 +37,6 @@ namespace AyaNova.Api.Controllers
serverState = apiServerState;
}
-
- ///
- /// Get full Customer object
- ///
- ///
- /// A single Customer
- [HttpGet("{id}")]
- public async Task GetCustomer([FromRoute] long id)
- {
- if (!serverState.IsOpen)
- return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
-
- //Instantiate the business object handler
- CustomerBiz biz = CustomerBiz.GetBiz(ct, HttpContext);
-
- //NOTE: This is the first check and often the only check but in some cases with some objects this will also need to check biz object rules
- if (!Authorized.HasReadFullRole(HttpContext.Items, biz.BizType))
- return StatusCode(403, new ApiNotAuthorizedResponse());
-
- if (!ModelState.IsValid)
- return BadRequest(new ApiErrorResponse(ModelState));
-
- var o = await biz.GetAsync(id);
- if (o == null)
- return NotFound(new ApiErrorResponse(ApiErrorCode.NOT_FOUND));
-
- // NOTE: HERE would be the second check of biz rules before returning the object
- // in cases where there is also a business rule to affect retrieval on top of basic rights
-
- return Ok(ApiOkResponse.Response(o, !Authorized.HasModifyRole(HttpContext.Items, biz.BizType)));
- }
-
-
-
- ///
- /// Put (update) Customer
- ///
- ///
- ///
- ///
- [HttpPut("{id}")]
- public async Task PutCustomer([FromRoute] long id, [FromBody] Customer inObj)
- {
- if (!serverState.IsOpen)
- return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
-
- if (!ModelState.IsValid)
- return BadRequest(new ApiErrorResponse(ModelState));
-
- //Instantiate the business object handler
- CustomerBiz biz = CustomerBiz.GetBiz(ct, HttpContext);
-
- var o = await biz.GetAsync(id, false);
- if (o == null)
- return NotFound(new ApiErrorResponse(ApiErrorCode.NOT_FOUND));
-
- if (!Authorized.HasModifyRole(HttpContext.Items, biz.BizType))
- return StatusCode(403, new ApiNotAuthorizedResponse());
-
- try
- {
- if (!await biz.PutAsync(o, inObj))
- return BadRequest(new ApiErrorResponse(biz.Errors));
- }
- catch (DbUpdateConcurrencyException)
- {
- if (!await biz.ExistsAsync(id))
- return NotFound(new ApiErrorResponse(ApiErrorCode.NOT_FOUND));
- else
- return StatusCode(409, new ApiErrorResponse(ApiErrorCode.CONCURRENCY_CONFLICT));
- }
- return Ok(ApiOkResponse.Response(new { Concurrency = o.Concurrency }, true));
- }
-
-
///
/// Create Customer
///
@@ -139,68 +62,94 @@ namespace AyaNova.Api.Controllers
///
/// Duplicate Customer
+ /// (Wiki and Attachments are not duplicated)
///
- /// Create a duplicate of this items id
+ /// Source object id
/// From route path
- ///
+ /// Customer
[HttpPost("duplicate/{id}")]
public async Task DuplicateCustomer([FromRoute] long id, ApiVersion apiVersion)
{
if (!serverState.IsOpen)
return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
-
- //Instantiate the business object handler
CustomerBiz biz = CustomerBiz.GetBiz(ct, HttpContext);
-
- //If a user has change roles
if (!Authorized.HasCreateRole(HttpContext.Items, biz.BizType))
return StatusCode(403, new ApiNotAuthorizedResponse());
-
if (!ModelState.IsValid)
return BadRequest(new ApiErrorResponse(ModelState));
-
- var oSrc = await biz.GetAsync(id, false);
- if (oSrc == null)
- return NotFound(new ApiErrorResponse(ApiErrorCode.NOT_FOUND));
-
- //Create and validate
- Customer o = await biz.DuplicateAsync(oSrc);
+ Customer o = await biz.DuplicateAsync(id);
if (o == null)
return BadRequest(new ApiErrorResponse(biz.Errors));
else
return CreatedAtAction(nameof(CustomerController.GetCustomer), new { id = o.Id, version = apiVersion.ToString() }, new ApiCreatedResponse(o));
+ }
+
+ ///
+ /// Get Customer
+ ///
+ ///
+ /// Customer
+ [HttpGet("{id}")]
+ public async Task GetCustomer([FromRoute] long id)
+ {
+ if (!serverState.IsOpen)
+ return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
+ CustomerBiz biz = CustomerBiz.GetBiz(ct, HttpContext);
+ if (!Authorized.HasReadFullRole(HttpContext.Items, biz.BizType))
+ return StatusCode(403, new ApiNotAuthorizedResponse());
+ if (!ModelState.IsValid)
+ return BadRequest(new ApiErrorResponse(ModelState));
+ var o = await biz.GetAsync(id);
+ if (o == null) return NotFound(new ApiErrorResponse(ApiErrorCode.NOT_FOUND));
+ return Ok(ApiOkResponse.Response(o, !Authorized.HasModifyRole(HttpContext.Items, biz.BizType)));
}
+ ///
+ /// Put (update) Customer
+ ///
+ ///
+ ///
+ [HttpPut("{id}")]
+ public async Task PutCustomer([FromBody] Customer updatedObject)
+ {
+ if (!serverState.IsOpen)
+ return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
+ if (!ModelState.IsValid)
+ return BadRequest(new ApiErrorResponse(ModelState));
+ CustomerBiz biz = CustomerBiz.GetBiz(ct, HttpContext);
+ if (!Authorized.HasModifyRole(HttpContext.Items, biz.BizType))
+ return StatusCode(403, new ApiNotAuthorizedResponse());
+ var o = await biz.PutAsync(updatedObject);//In future may need to return entire object, for now just concurrency token
+ if (o == null)
+ {
+ if (biz.Errors.Exists(m => m.Code == ApiErrorCode.CONCURRENCY_CONFLICT))
+ return StatusCode(409, new ApiErrorResponse(biz.Errors));
+ else
+ return BadRequest(new ApiErrorResponse(biz.Errors));
+ }
+ return Ok(ApiOkResponse.Response(new { Concurrency = o.Concurrency }, true));;
+ }
+
///
/// Delete Customer
///
///
- /// Ok
+ /// NoContent
[HttpDelete("{id}")]
public async Task DeleteCustomer([FromRoute] long id)
{
if (!serverState.IsOpen)
return StatusCode(503, new ApiErrorResponse(serverState.ApiErrorCode, null, serverState.Reason));
-
if (!ModelState.IsValid)
return BadRequest(new ApiErrorResponse(ModelState));
-
- //Instantiate the business object handler
CustomerBiz biz = CustomerBiz.GetBiz(ct, HttpContext);
-
- var o = await biz.GetAsync(id, false);
- if (o == null)
- return NotFound(new ApiErrorResponse(ApiErrorCode.NOT_FOUND));
-
if (!Authorized.HasDeleteRole(HttpContext.Items, biz.BizType))
return StatusCode(403, new ApiNotAuthorizedResponse());
-
- if (!await biz.DeleteAsync(o))
+ if (!await biz.DeleteAsync(id))
return BadRequest(new ApiErrorResponse(biz.Errors));
-
return NoContent();
}
diff --git a/server/AyaNova/Controllers/WorkOrderController.cs b/server/AyaNova/Controllers/WorkOrderController.cs
index 74fdc27b..68fdbd66 100644
--- a/server/AyaNova/Controllers/WorkOrderController.cs
+++ b/server/AyaNova/Controllers/WorkOrderController.cs
@@ -1,10 +1,8 @@
-using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Routing;
using Microsoft.AspNetCore.Authorization;
-using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging;
using AyaNova.Models;
using AyaNova.Api.ControllerHelpers;