This commit is contained in:
2020-10-13 17:34:48 +00:00
parent b33742a40a
commit fcfad814dd
14 changed files with 51 additions and 29 deletions

View File

@@ -2,27 +2,34 @@
@@@@@@@@@@@@@@@ ROADMAP STAGE 4 - REPORTING / DASHBOARD / KPI
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
todo: manifest / favicon convert to green/blue shirt from yellow
files need to go into C:\data\code\raven-client\ayanova\public\img\icons
https://github.com/onderceylan/pwa-asset-generator
https://realfavicongenerator.net/
have all the icons I need generated in temp folder
replace existing, add apple ones as seems to make sense, update manifest and index.HTML
any used need to be copied to server graphics folder for backup as well
Finally, test with devops and iPad and all devices to confirm
To try:
msft pwa stuff
It uses one of the additional icon24 or 48 for the task bar icon when running as an app
still has the 16px tiny one on the desktop
android from chrome is white background
android from ff is same color green as the shirt background! fuck!
maybe becuase it doesn't have a "maskable icon" see below
https://developers.google.com/web/fundamentals/design-and-ux/browser-customization
https://stackoverflow.com/questions/48956465/favicon-standard-2020-svg-ico-png-and-dimensions
remove the favico.ico completely as a test
ISSUES AFTER CHANGING ICON:
tiny icon used in windows when chrome install used
no image at all used in Android when chrome install used
todo: needs a maskable icon according to lighthouse:
The icons array must contain one object with a purpose property, and the value of that purpose property must include maskable.
https://web.dev/maskable-icon/
todo: for some reason the 32px icon is being surrounded by an if statement in the generated index.html page in dist folder
I think I tried commenting out the 32bit null one to see what would happen but haven't built yet to compare
May require a manual step for release of removing the comment if I can't find a way to turn that shit off, no idea what part of the build process is responsible, maybe workbox stuff?
TODO: tiny icon used in windows when chrome install to desktop used
Issue on github: https://github.com/RealFaviconGenerator/realfavicongenerator/issues/446
todo: figure out which tool and get rid of this added to index.html on build:
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
todo: client build, turn off generating manifest.json as I have a static one already
todo: service workers for monaco going in root of website folder, must be a config setting to move it into the proper place (not there)
couldn't find anything about it, may need to post to ask, it's not the end of the world but kind of stupid looking as all the rest of the js is in subfolder
todo: login, large view, branded logo and footer text not centered equally?