diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt index cf4baca7..e79e2e39 100644 --- a/ayanova/devdocs/todo.txt +++ b/ayanova/devdocs/todo.txt @@ -13,19 +13,12 @@ LISTVIEW REPLACE CURRENT <----HERE not THERE ---v TODO (now) CLIENT - Fix error: "enumSelectionList" is not defined on the instance but referenced during render - prevents enum filtering - - META filters: Make sure ALL serverdatacriteria meta columns are key named "meta*" to fix two problems - in cases where it's using existnig user facing columns make dupes with meta* names - - META: Return datatable data - make sure "meta" columns are not included in filter return list - user should never be aware of them at all, some are security related, not that they can do anything but it's just a waste of bandwidth and leaks information + Not liking the default filter, could lead to confusion User needs an easy way to definitively de-filter completely Maybe show a "remove filter" button beside the selector when it's the default and it's filtered? + Or, at the very least show "filtered" on the results so user KNOWS it's filtered @@ -52,7 +45,8 @@ LISTVIEW REPLACE CURRENT <----HERE not THERE ---v todo (after) Test TEST **TEST** - Test all column types are properly filterable including ENUMS + Test all column types are properly filterable including ENUMS and TAGS + unfilterable columns? Do they show a filter icon? wut? Clean up the server and client code including the wierd props not being used set on all list forms etc get rid of the countless commented out lines that are now irrelevant and will just cause confusion in future Duplicate option for filter is no longer required at server routes / biz diff --git a/ayanova/src/components/data-table.vue b/ayanova/src/components/data-table.vue index 916bad4b..a92988d9 100644 --- a/ayanova/src/components/data-table.vue +++ b/ayanova/src/components/data-table.vue @@ -24,16 +24,22 @@ @input="selectedFilterChanged" prepend-icon="$ayiEdit" @click:prepend="editFilter()" + :append-outer-icon="clearFilterIcon()" + @click:append-outer="clearFilter()" data-cy="selectSavedFilter" > +
$ayiSync - + + $ayiColumns
@@ -527,6 +533,15 @@ export default { } return clr; }, + clearFilter() { + //reset default filter and switch to it and trigger getdata + }, + clearFilterIcon() { + if (this.serverFilter && this.serverFilter.length > 0) { + return "$clear"; + } + return null; + }, async editFilter() { let res = await this.$refs.dataTableFilterManager.open(); if (res && res.refresh == true) {