From f804d70c27e330be7012307fee47b8eb3bc5973e Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Tue, 5 Jan 2021 23:22:44 +0000
Subject: [PATCH]

---
 ayanova/devdocs/todo.txt                |  7 +++---
 ayanova/src/views/acc-service-banks.vue |  2 +-
 ayanova/tests/e2e/specs/smoke.js        | 30 ++++++++++++++++++++++---
 3 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index 2749f5ff..04999578 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -6,10 +6,9 @@
 MISC ITEMS THAT CAME UP
 
 todo: Active field is probably very seldom used, perhaps it should always be the last field in the forms?
+	Yes, move active to just before Notes on every form or if no notes make it the last less than 12 column field
+
 
-todo: I keep thinking I should just move to LT keys for all datalist and formfield and picklist column definitions, drop the tkey and fieldkey type fields in favor of just one key that is the translation key
-	But maybe I'd regret that later if I have a really complex object with multiple of the same field names?
-	Maybe it's a complete non-issue and fuck it
 	
 todo: consider moving service contracts to Accounting area?
 
@@ -67,7 +66,7 @@ todo: actual customer reports so can figure out datalist for bringing other name
 
 
 CURRENTLY DOING: 	
-	LoanItem
+	LoanUnit - migrate
 
 
 	
diff --git a/ayanova/src/views/acc-service-banks.vue b/ayanova/src/views/acc-service-banks.vue
index e8cd939b..ef938f4f 100644
--- a/ayanova/src/views/acc-service-banks.vue
+++ b/ayanova/src/views/acc-service-banks.vue
@@ -22,7 +22,7 @@
       :metaView="metaView"
       :ridColumnOpenable="false"
       v-on:selection-change="handleSelected"
-      data-cy="service-banksTable"
+      data-cy="serviceBanksTable"
     >
     </gz-data-table>
   </div>
diff --git a/ayanova/tests/e2e/specs/smoke.js b/ayanova/tests/e2e/specs/smoke.js
index cc6fcfb7..434d97dc 100644
--- a/ayanova/tests/e2e/specs/smoke.js
+++ b/ayanova/tests/e2e/specs/smoke.js
@@ -113,19 +113,23 @@ describe("SMOKE", () => {
 
     cy.visit("/svc-units");
     cy.url().should("include", "/svc-units");
-    cy.get("[data-cy=underconstruction]");
+    cy.get("[data-cy=unitsTable]");
+
+    cy.visit("/svc-units/1");
+    cy.url().should("include", "/svc-units/1");
+    cy.get("[data-cy=serial]");
 
     cy.visit("/svc-unit-models");
     cy.url().should("include", "/svc-unit-models");
     cy.get("[data-cy=unitmodelsTable]");
- 
+
     cy.visit("/svc-unit-models/1");
     cy.url().should("include", "svc-unit-models/1");
     cy.get("[data-cy=number]");
 
     cy.visit("/svc-loaners");
     cy.url().should("include", "/svc-loaners");
-    cy.get("[data-cy=underconstruction]");
+    cy.get("[data-cy=loanUnitsTable]");
 
     cy.visit("/svc-contracts");
     cy.url().should("include", "/svc-contracts");
@@ -135,6 +139,10 @@ describe("SMOKE", () => {
     cy.url().should("include", "/svc-projects");
     cy.get("[data-cy=projectsTable]");
 
+    cy.visit("/svc-projects/1");
+    cy.url().should("include", "/svc-projects/1");
+    cy.get("[data-cy=name]");
+
     cy.visit("/svc-csr-list");
     cy.url().should("include", "/svc-csr-list");
     cy.get("[data-cy=underconstruction]");
@@ -174,18 +182,34 @@ describe("SMOKE", () => {
     cy.get("[data-cy=name]");
 
     //################# ACCOUNTING
+    cy.visit("/acc-service-banks");
+    cy.url().should("include", "/acc-service-banks");
+    cy.get("[data-cy=serviceBanksTable]");
+
     cy.visit("/acc-service-rates");
     cy.url().should("include", "/acc-service-rates");
     cy.get("[data-cy=serviceRatesTable]");
 
+    cy.visit("/acc-service-rates/1");
+    cy.url().should("include", "/acc-service-rates/1");
+    cy.get("[data-cy=name]");
+
     cy.visit("/acc-travel-rates");
     cy.url().should("include", "/acc-travel-rates");
     cy.get("[data-cy=travelRatesTable]");
 
+    cy.visit("/acc-travel-rates/1");
+    cy.url().should("include", "/acc-travel-rates/1");
+    cy.get("[data-cy=name]");
+
     cy.visit("/acc-tax-codes");
     cy.url().should("include", "/acc-tax-codes");
     cy.get("[data-cy=taxCodesTable]");
 
+    cy.visit("/acc-tax-codes/1");
+    cy.url().should("include", "/acc-tax-codes/1");
+    cy.get("[data-cy=name]");
+
     //################# ADMIN
     cy.visit("/adm-global-settings");
     cy.url().should("include", "/adm-global-settings");