From ee4fb103de181911289e28c76d4c0b42a6117c7f Mon Sep 17 00:00:00 2001
From: John Cardinal <support@ayanova.com>
Date: Sat, 2 Jan 2021 18:34:49 +0000
Subject: [PATCH] CLEANUP remove extraneous containers and rows and columns

---
 ayanova/devdocs/todo.txt                      |  2 +-
 ayanova/src/components/tag-picker.vue         | 10 +--
 ayanova/src/views/adm-translation.vue         | 28 +++----
 ayanova/src/views/adm-user.vue                |  2 +-
 ayanova/src/views/ay-evaluate.vue             | 81 +++++++------------
 .../src/views/home-notify-subscription.vue    |  4 +-
 ayanova/src/views/home-reminder.vue           |  4 +-
 ayanova/src/views/home-review.vue             |  4 +-
 .../src/views/ops-notification-settings.vue   | 22 ++---
 ayanova/src/views/svc-project.vue             |  4 +-
 ayanova/src/views/svc-unit-model.vue          |  4 +-
 ayanova/src/views/vendor.vue                  |  4 +-
 ayanova/src/views/widget.vue                  |  6 +-
 13 files changed, 65 insertions(+), 110 deletions(-)

diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt
index b4cdd610..39decb8a 100644
--- a/ayanova/devdocs/todo.txt
+++ b/ayanova/devdocs/todo.txt
@@ -22,7 +22,7 @@ todo: Notification at server has NotifyDeliveryLog object unused and no UI at fr
 	and no ui to view them?!
 	figure it out
 
-todo: do not compare null in queries so double check and instead make sure it's using "Is not null" or "is null" instead as results are non determinant otherwise
+todo: figure out the grid view form slowness, maybe there are extraneous elements or something, it's important because it's oft-used
 
 todo: unitmodel, maybe can make a combo unique constraint for the model number or name by combining with the vendorID
 	it's doubtful two models from the same vendor would have the same model number so this covers that case or am I wrong on that?
diff --git a/ayanova/src/components/tag-picker.vue b/ayanova/src/components/tag-picker.vue
index 473c9c49..b636710d 100644
--- a/ayanova/src/components/tag-picker.vue
+++ b/ayanova/src/components/tag-picker.vue
@@ -18,14 +18,6 @@
       deletable-chips
       cache-items
     >
-      <!-- <template v-slot:no-data>
-        <v-list-item>
-          <v-list-item-title>
-            Search for your favorite
-            <strong>TAG</strong>
-          </v-list-item-title>
-        </v-list-item>
-      </template> -->
       <template slot="no-data" v-if="tagSearchEntry">
         <v-container fluid>
           <v-row>
@@ -47,7 +39,7 @@
 /////////////////////////////////////////////////////////////////////////////////////////////////////////////
 /*  eslint-disable    */
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////
-//NOTE: I had some concerns about how the selection is made, but leving it for now
+//NOTE: I had some concerns about how the selection is made, but leaving it for now
 //basically the typed text stays after you select from dropdown, however, it clears as soon as you tab off
 //and in theory it could help if picking more than one tag that have similar selection criteria
 export default {
diff --git a/ayanova/src/views/adm-translation.vue b/ayanova/src/views/adm-translation.vue
index 029aeb6b..d0f49f69 100644
--- a/ayanova/src/views/adm-translation.vue
+++ b/ayanova/src/views/adm-translation.vue
@@ -9,25 +9,17 @@
             <span class="headline">{{ $ay.t("FindAndReplace") }}</span>
           </v-card-title>
           <v-card-text>
-            <v-container>
-              <v-row>
-                <v-col cols="12">
-                  <v-text-field
-                    v-model="find"
-                    :label="$ay.t('Find')"
-                    required
-                  ></v-text-field>
-                </v-col>
+            <v-text-field
+              v-model="find"
+              :label="$ay.t('Find')"
+              required
+            ></v-text-field>
 
-                <v-col cols="12">
-                  <v-text-field
-                    v-model="replace"
-                    :label="$ay.t('Replace')"
-                    required
-                  ></v-text-field>
-                </v-col>
-              </v-row>
-            </v-container>
+            <v-text-field
+              v-model="replace"
+              :label="$ay.t('Replace')"
+              required
+            ></v-text-field>
           </v-card-text>
           <v-card-actions>
             <v-spacer></v-spacer>
diff --git a/ayanova/src/views/adm-user.vue b/ayanova/src/views/adm-user.vue
index 8387cdfe..8b4424b4 100644
--- a/ayanova/src/views/adm-user.vue
+++ b/ayanova/src/views/adm-user.vue
@@ -1,5 +1,5 @@
 <template>
- <div>
+  <div>
     <gz-report-selector ref="reportSelector"></gz-report-selector>
 
     <div v-if="formState.ready">
diff --git a/ayanova/src/views/ay-evaluate.vue b/ayanova/src/views/ay-evaluate.vue
index 6738b249..aa7dd23d 100644
--- a/ayanova/src/views/ay-evaluate.vue
+++ b/ayanova/src/views/ay-evaluate.vue
@@ -4,60 +4,37 @@
       <v-dialog v-model="seedDialog" persistent max-width="600px">
         <v-card>
           <v-card-title>
-            <span class="headline">{{ $ay.t("GenerateSampleData") }}</span>
+            <span class="headline  mb-2">{{
+              $ay.t("GenerateSampleData")
+            }}</span>
           </v-card-title>
           <v-card-text>
-            <v-container>
-              <v-row>
-                <v-col cols="12">
-                  <!-- <div class="text-h5 mt-8 mb-2">
-                    {{ $ay.t("GenerateSampleData") }}
-                  </div> -->
-                  <v-col cols="12" v-if="formState.readOnly">
-                    <div class="text-h6 mt-8 warning--text">
-                      {{ $ay.t("ErrorSecurityAdministratorOnlyMessage") }}
-                    </div>
-                  </v-col>
-                  <v-col cols="12">
-                    <v-select
-                      v-model="obj.seedLevel"
-                      :items="selectLists.seedLevels"
-                      :rules="[form().required(this, 'seedLevel')]"
-                      @input="fieldValueChanged('seedLevel')"
-                      ref="seedLevel"
-                      item-text="name"
-                      item-value="id"
-                      :readonly="formState.readOnly"
-                      :label="$ay.t('SeedLevel')"
-                    ></v-select>
-                  </v-col>
-                  <v-col cols="12">
-                    <v-text-field
-                      v-model="obj.timeZoneOffset"
-                      :readonly="formState.readOnly"
-                      :rules="[
-                        form().decimalValid(this, 'timeZoneOffset'),
-                        form().required(this, 'timeZoneOffset')
-                      ]"
-                      :label="$ay.t('UserTimeZoneOffset')"
-                      type="number"
-                      ref="timeZoneOffset"
-                      @input="fieldValueChanged('timeZoneOffset')"
-                    ></v-text-field>
-                  </v-col>
-
-                  <!-- <v-col cols="12">
-                    <v-btn
-                      :loading="seedingJobActive"
-                      
-                      @click="generate()"
-                      class="my-8 mr-4"
-                      >{{ $ay.t("StartJob") }}</v-btn
-                    >
-                  </v-col> -->
-                </v-col>
-              </v-row>
-            </v-container>
+            <div v-if="formState.readOnly" class="text-h6 mt-8 warning--text">
+              {{ $ay.t("ErrorSecurityAdministratorOnlyMessage") }}
+            </div>
+            <v-select
+              v-model="obj.seedLevel"
+              :items="selectLists.seedLevels"
+              :rules="[form().required(this, 'seedLevel')]"
+              @input="fieldValueChanged('seedLevel')"
+              ref="seedLevel"
+              item-text="name"
+              item-value="id"
+              :readonly="formState.readOnly"
+              :label="$ay.t('SeedLevel')"
+            ></v-select>
+            <v-text-field
+              v-model="obj.timeZoneOffset"
+              :readonly="formState.readOnly"
+              :rules="[
+                form().decimalValid(this, 'timeZoneOffset'),
+                form().required(this, 'timeZoneOffset')
+              ]"
+              :label="$ay.t('UserTimeZoneOffset')"
+              type="number"
+              ref="timeZoneOffset"
+              @input="fieldValueChanged('timeZoneOffset')"
+            ></v-text-field>
           </v-card-text>
           <v-card-actions>
             <v-spacer></v-spacer>
diff --git a/ayanova/src/views/home-notify-subscription.vue b/ayanova/src/views/home-notify-subscription.vue
index 81f9c80d..89f18691 100644
--- a/ayanova/src/views/home-notify-subscription.vue
+++ b/ayanova/src/views/home-notify-subscription.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-container fluid>
+  <div>
     <v-row v-if="formState.ready">
       <v-col>
         <v-form ref="form">
@@ -132,7 +132,7 @@
         :size="60"
       ></v-progress-circular>
     </template>
-  </v-container>
+  </div>
 </template>
 
 <script>
diff --git a/ayanova/src/views/home-reminder.vue b/ayanova/src/views/home-reminder.vue
index e0041475..2aabd897 100644
--- a/ayanova/src/views/home-reminder.vue
+++ b/ayanova/src/views/home-reminder.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-container fluid>
+  <div>
     <gz-report-selector ref="reportSelector"></gz-report-selector>
     <div v-if="formState.ready">
       <gz-error :errorBoxMessage="formState.errorBoxMessage"></gz-error>
@@ -131,7 +131,7 @@
         :size="60"
       ></v-progress-circular>
     </template>
-  </v-container>
+  </div>
 </template>
 
 <script>
diff --git a/ayanova/src/views/home-review.vue b/ayanova/src/views/home-review.vue
index 0d8bb68f..49250fc1 100644
--- a/ayanova/src/views/home-review.vue
+++ b/ayanova/src/views/home-review.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-container fluid>
+  <div>
     <gz-report-selector ref="reportSelector"></gz-report-selector>
     <div v-if="formState.ready">
       <gz-error :errorBoxMessage="formState.errorBoxMessage"></gz-error>
@@ -167,7 +167,7 @@
         :size="60"
       ></v-progress-circular>
     </template>
-  </v-container>
+  </div>
 </template>
 
 <script>
diff --git a/ayanova/src/views/ops-notification-settings.vue b/ayanova/src/views/ops-notification-settings.vue
index ec3988a6..d49cf19c 100644
--- a/ayanova/src/views/ops-notification-settings.vue
+++ b/ayanova/src/views/ops-notification-settings.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-container fluid>
+  <div>
     <v-row justify="center">
       <v-dialog v-model="testDialog" persistent max-width="600px">
         <v-card>
@@ -7,18 +7,12 @@
             <span class="headline">{{ $ay.t("TestSMTPSettings") }}</span>
           </v-card-title>
           <v-card-text>
-            <v-container>
-              <v-row>
-                <v-col cols="12">
-                  <v-text-field
-                    v-model="testAddress"
-                    :label="$ay.t('TestToAddress')"
-                    required
-                    hint="test_send_to@example.com"
-                  ></v-text-field>
-                </v-col>
-              </v-row>
-            </v-container>
+            <v-text-field
+              v-model="testAddress"
+              :label="$ay.t('TestToAddress')"
+              required
+              hint="test_send_to@example.com"
+            ></v-text-field>
           </v-card-text>
           <v-card-actions>
             <v-spacer></v-spacer>
@@ -159,7 +153,7 @@
         </v-form>
       </v-col>
     </v-row>
-  </v-container>
+  </div>
 </template>
 
 <script>
diff --git a/ayanova/src/views/svc-project.vue b/ayanova/src/views/svc-project.vue
index 031c5fca..54ae584f 100644
--- a/ayanova/src/views/svc-project.vue
+++ b/ayanova/src/views/svc-project.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-container fluid>
+  <div>
     <gz-report-selector ref="reportSelector"></gz-report-selector>
     <div v-if="formState.ready">
       <gz-error :errorBoxMessage="formState.errorBoxMessage"></gz-error>
@@ -179,7 +179,7 @@
         :size="60"
       ></v-progress-circular>
     </template>
-  </v-container>
+  </div>
 </template>
 
 <script>
diff --git a/ayanova/src/views/svc-unit-model.vue b/ayanova/src/views/svc-unit-model.vue
index e71adbd0..feef8e58 100644
--- a/ayanova/src/views/svc-unit-model.vue
+++ b/ayanova/src/views/svc-unit-model.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-container fluid>
+  <div>
     <gz-report-selector ref="reportSelector"></gz-report-selector>
     <div v-if="formState.ready">
       <gz-error :errorBoxMessage="formState.errorBoxMessage"></gz-error>
@@ -258,7 +258,7 @@
         :size="60"
       ></v-progress-circular>
     </template>
-  </v-container>
+  </div>
 </template>
 
 <script>
diff --git a/ayanova/src/views/vendor.vue b/ayanova/src/views/vendor.vue
index 991315c9..48011e2c 100644
--- a/ayanova/src/views/vendor.vue
+++ b/ayanova/src/views/vendor.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-container fluid>
+  <div>
     <gz-report-selector ref="reportSelector"></gz-report-selector>
     <div v-if="formState.ready">
       <gz-error :errorBoxMessage="formState.errorBoxMessage"></gz-error>
@@ -583,7 +583,7 @@
         :size="60"
       ></v-progress-circular>
     </template>
-  </v-container>
+  </div>
 </template>
 
 <script>
diff --git a/ayanova/src/views/widget.vue b/ayanova/src/views/widget.vue
index 316dcd61..74c890b1 100644
--- a/ayanova/src/views/widget.vue
+++ b/ayanova/src/views/widget.vue
@@ -1,7 +1,7 @@
 <template>
-  <v-container fluid>
+  <div>
     <gz-report-selector ref="reportSelector"></gz-report-selector>
-    <!-- {{ formState }} -->
+
     <v-row v-if="formState.ready">
       <v-col>
         <v-form ref="form">
@@ -232,7 +232,7 @@
         :size="60"
       ></v-progress-circular>
     </template>
-  </v-container>
+  </div>
 </template>
 
 <script>