diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt index 51fd2222..5ab7c098 100644 --- a/ayanova/devdocs/todo.txt +++ b/ayanova/devdocs/todo.txt @@ -23,31 +23,15 @@ FIRST CLIENT SOURCE CODE COMMIT JAN 3rd 2019 # OUTSTANDING MAJOR AREAS TO BETA -todo: dbutil erase db new tables not added!! - should it keep config values so user can erase trial db but keep all their settings and logo and shit? - YES DOCUMENT HOW TO **COMPLETELY** ERASE WITH CONFIG SETTING AND WHAT IS KEPT WITH REGULAR LICENSE ERASE - holup, from server todo previously: -todo: AYANOVA_SERVER_TEST_MODE Is this a thing anymore? I think I need to remove it as an environment variable and all the startup code to go with it -todo: AYANOVA_PERMANENTLY_ERASE_DATABASE does more than that, also resets dbid, should this option name be changed to something more dire - it sounds just like the option in ayaNova to erase all data but those are two different things - "permanently" is redundant as well. -todo: permanently erase db startup thing, should it really exist? - It will zap the dbid so a user might expect to just use their old license but it wont' fetch again - we could issue a new key to replace with the new dbid and also issue a revoke key for the old dbid so that - there can be no fraudulent use this way. - I guess it's a rare situation and if the option to delete is there people will surely fuck up and use it unintentionally? - or maybe not -todo: could be a presentation issue but erasing the database and "permanently" erasing the db do two different things completely - Maybe change the biz object erase to empty or remove all data or something along those lines - If it requires too much explanation then it's probably mis-identified as to what it does - -todo: test with licensed key to ensure evaluate is gone and everything works logging in as each user to regular home page - todo: mirror remove not used settings in regular user notify subscription to avoid duplicate problem there too with invalid or more likely hidden and hard to diagnose settings + + rockfish b4beta cases # OUTSTANDING BEFORE RELEASE +todo: test with licensed key to ensure evaluate is gone and everything works logging in as each user to regular home page + - License agreement change from beta to regular - Docs completed filling in, many empty pages still diff --git a/ayanova/src/views/customer-notify-subscription.vue b/ayanova/src/views/customer-notify-subscription.vue index e9248a46..9479e87d 100644 --- a/ayanova/src/views/customer-notify-subscription.vue +++ b/ayanova/src/views/customer-notify-subscription.vue @@ -929,10 +929,7 @@ export default { if (!this.showAdvanceNotice) { this.obj.advanceNotice = "00:00:00"; } - if (!this.showDecValue) { - this.obj.decValue = 0; - } - if (!this.showIntegerDecValue) { + if (!this.showDecValue && !this.showIntegerDecValue) { this.obj.decValue = 0; } diff --git a/ayanova/src/views/home-notify-subscription.vue b/ayanova/src/views/home-notify-subscription.vue index b769ba54..3c3f90c0 100644 --- a/ayanova/src/views/home-notify-subscription.vue +++ b/ayanova/src/views/home-notify-subscription.vue @@ -521,6 +521,22 @@ export default { try { vm.formState.loading = true; window.$gz.form.deleteAllErrorBoxErrors(vm); + + //don't include invalid settings (could be set by duplicate option) + if (!this.showAgeValue) { + this.obj.ageValue = "00:00:00"; + } + if (!this.showAdvanceNotice) { + this.obj.advanceNotice = "00:00:00"; + } + if (!this.showDecValue && !this.showIntegerDecValue) { + this.obj.decValue = 0; + } + + if (!this.showQuoteStatus && !this.showWoStatus) { + this.obj.idValue = 0; + } + //don't send the deliveryaddress if it's an in-app notification if (vm.obj.deliveryMethod == 1) { vm.obj.deliveryAddress = null;