re-factor / cleanup

ayanova/src/views/customer-workorders.vue

@@ -6,10 +6,10 @@
       data-list-key="CustomerWorkOrderDataList"
       :show-select="rights.read"
       :reload="reload"
-      @selection-change="handleSelected"
       data-cy="workordersTable"
       :client-criteria="clientCriteria"
       :pre-filter-mode="preFilterMode"
+      @selection-change="handleSelected"
       @clear-pre-filter="clearPreFilter"
     >
     </gz-data-table>
@@ -18,6 +18,21 @@
 <script>
 const FORM_KEY = "customer-workorder-list";
 export default {
+  data() {
+    return {
+      rights: window.$gz.role.defaultRightsObject(),
+      aType: window.$gz.type.WorkOrder,
+      selectedItems: [],
+      reload: false,
+      openDialog: false,
+      openWoNumber: null,
+      clientCriteria: undefined,
+      preFilterMode: null,
+      objectId: null,
+      aForType: null,
+      name: null
+    };
+  },
   async created() {
     this.rights = window.$gz.role.getRights(window.$gz.type.WorkOrder);
     window.$gz.eventBus.$on("menu-click", clickHandler);
@@ -49,21 +64,6 @@ export default {
   beforeDestroy() {
     window.$gz.eventBus.$off("menu-click", clickHandler);
   },
-  data() {
-    return {
-      rights: window.$gz.role.defaultRightsObject(),
-      aType: window.$gz.type.WorkOrder,
-      selectedItems: [],
-      reload: false,
-      openDialog: false,
-      openWoNumber: null,
-      clientCriteria: undefined,
-      preFilterMode: null,
-      objectId: null,
-      aForType: null,
-      name: null
-    };
-  },
   methods: {
     handleSelected(selected) {
       this.selectedItems = selected;
@@ -86,21 +86,6 @@ async function clickHandler(menuItem) {
   const m = window.$gz.menu.parseMenuItem(menuItem);
   if (m.owner == FORM_KEY && !m.disabled) {
     switch (m.key) {
-      // case "report":
-      //   {
-      //     const res = await m.vm.$refs.reportSelector.open(
-      //       m.vm.$refs.gzdatatable.getDataListSelection(
-      //         window.$gz.type.WorkOrder
-      //       ),
-      //       m.id
-      //     );
-      //     if (res == null) {
-      //       return;
-      //     }
-      //window.$gz.form.setLastReportMenuItem(FORM_KEY, res, m.vm);
-      //   }
-      //   break;
-
       default:
         window.$gz.eventBus.$emit(
           "notify-warning",
@@ -113,7 +98,7 @@ async function clickHandler(menuItem) {
 //////////////////////
 //
 //
-function generateMenu(vm) {
+function generateMenu() {
   const menuOptions = {
     isMain: true,
     icon: "$ayiTools",