re-factor / cleanup

ayanova/src/components/role-control.vue

@@ -7,17 +7,47 @@
     chips
     deletable-chips
     :value="selectedValue"
-    @input="handleInput"
     :readonly="readonly"
     :disabled="disabled"
     :label="label"
     :rules="rules"
     :error-messages="errorMessages"
     :data-cy="'roleinput:' + testId"
+    @input="handleInput"
   ></v-select>
 </template>
 <script>
 export default {
+  props: {
+    label: { type: String, default: null },
+    rules: { type: Array, default: undefined },
+    errorMessages: { type: Array, default: null },
+    value: { type: Number, default: 0 },
+    readonly: { type: Boolean, default: false },
+    disabled: { type: Boolean, default: false },
+    limitSelectionTo: { type: String, default: null }, //"inside" - no customer roles, "outside" - no non-customer roles
+    testId: { type: String, default: null }
+  },
+  data() {
+    return {
+      internalValue: null,
+      availableRoles: []
+    };
+  },
+  computed: {
+    selectedValue() {
+      const ret = [];
+      if (this.value != null && this.value != 0) {
+        for (let i = 0; i < this.availableRoles.length; i++) {
+          const role = this.availableRoles[i];
+          if (this.value & role.id) {
+            ret.push(role.id);
+          }
+        }
+      }
+      return ret;
+    }
+  },
   async created() {
     await window.$gz.enums.fetchEnumList("AuthorizationRoles");
     const rawRoles = window.$gz.enums.getSelectionList("AuthorizationRoles");
@@ -36,36 +66,6 @@ export default {
       }
     }
   },
-  data() {
-    return {
-      internalValue: null,
-      availableRoles: []
-    };
-  },
-  props: {
-    label: { type: String, default: null },
-    rules: { type: Array, default: undefined },
-    errorMessages: { type: Array, default: null },
-    value: { type: Number, default: 0 },
-    readonly: { type: Boolean, default: false },
-    disabled: { type: Boolean, default: false },
-    limitSelectionTo: { type: String, default: null }, //"inside" - no customer roles, "outside" - no non-customer roles
-    testId: { type: String, default: null }
-  },
-  computed: {
-    selectedValue() {
-      const ret = [];
-      if (this.value != null && this.value != 0) {
-        for (let i = 0; i < this.availableRoles.length; i++) {
-          const role = this.availableRoles[i];
-          if (!!(this.value & role.id)) {
-            ret.push(role.id);
-          }
-        }
-      }
-      return ret;
-    }
-  },
   methods: {
     handleInput(value) {
       let newValue = 0;