adding back fa- to icons so can more easily find them in code and removing helper function that added fa- automatically

ayanova/src/api/gzmenu.js

@@ -11,9 +11,6 @@ export default {
   // called from App.vue
   handleMenuChange(vm, ctx) {
     vm.appBar.isMain = ctx.isMain;
-    if (ctx.icon && !ctx.icon.startsWith("fa-")) {
-      ctx.icon = "fa-" + ctx.icon;
-    }
     vm.appBar.icon = ctx.icon;
     vm.appBar.title = ctx.title;
 
@@ -56,14 +53,14 @@ export default {
     if (isCoreBizObject) {
       vm.appBar.menuItems.push({
         title: window.$gz.translation.get("Attachments"),
-        icon: "paperclip",
+        icon: "fa-paperclip",
         key: "app:attachments",
         data: { ayaType: formAyaType, recordId: formRecordId }
       });
 
       vm.appBar.menuItems.push({
         title: window.$gz.translation.get("WikiPage"),
-        icon: "feather",
+        icon: "fa-feather",
         key: "app:wiki",
         data: { ayaType: formAyaType, recordId: formRecordId }
       });
@@ -73,7 +70,7 @@ export default {
 
       vm.appBar.menuItems.push({
         title: window.$gz.translation.get("Review"),
-        icon: "calendar-check",
+        icon: "fa-calendar-check",
         key: "app:review",
         data: { ayaType: formAyaType, recordId: formRecordId }
       });
@@ -82,7 +79,7 @@ export default {
       //anything not would be the exception rather than the rule
       vm.appBar.menuItems.push({
         title: window.$gz.translation.get("History"),
-        icon: "history",
+        icon: "fa-history",
         key: "app:history",
         data: { ayaType: formAyaType, recordId: formRecordId }
       });
@@ -107,7 +104,7 @@ export default {
       //customize
       vm.appBar.menuItems.push({
         title: window.$gz.translation.get("Customize"),
-        icon: "sliders-h",
+        icon: "fa-sliders-h",
         data: ctx.formData.formCustomTemplateKey,
         key: "app:customize"
       });
@@ -129,7 +126,7 @@ export default {
       //For all forms but not on the search form itself; if this is necessary for others then make a nosearch or something flag controlled by incoming ctx but if not then this should suffice
       vm.appBar.menuItems.push({
         title: window.$gz.translation.get("Search"),
-        icon: "search",
+        icon: "fa-search",
         key: "app:search",
         data: formAyaType
       });
@@ -138,7 +135,7 @@ export default {
     //HELP
     vm.appBar.menuItems.push({
       title: window.$gz.translation.get("MenuHelp"),
-      icon: "question-circle",
+      icon: "fa-question-circle",
       key: "app:help",
       data: vm.appBar.helpUrl
     });
@@ -147,7 +144,7 @@ export default {
     if (ctx.helpUrl != "form-ay-about") {
       vm.appBar.menuItems.push({
         title: window.$gz.translation.get("HelpAboutAyaNova"),
-        icon: "info-circle",
+        icon: "fa-info-circle",
         key: "app:nav:abt",
         data: "ay-about"
       });
@@ -156,7 +153,7 @@ export default {
     //LOGOUT
     vm.appBar.menuItems.push({
       title: window.$gz.translation.get("Logout"),
-      icon: "sign-out-alt",
+      icon: "fa-sign-out-alt",
       key: "app:logout"
     });
   },