From d7cc0ce407694ee53454c9e9a2a14d2d6d06caa4 Mon Sep 17 00:00:00 2001 From: John Cardinal Date: Wed, 10 Feb 2021 16:16:33 +0000 Subject: [PATCH] --- ayanova/devdocs/todo.txt | 29 +++++++++---------- ayanova/src/App.vue | 2 +- ayanova/src/components/attachment-control.vue | 4 +-- ayanova/src/components/currency-control.vue | 2 +- ayanova/src/components/dash-base.vue | 4 +-- .../components/data-table-filter-control.vue | 4 +-- .../data-table-filter-manager-control.vue | 4 +-- ayanova/src/components/data-table.vue | 4 +-- ayanova/src/components/date-control.vue | 7 ++--- .../src/components/date-native-control.vue | 6 ++-- ayanova/src/components/date-time-control.vue | 8 ++--- .../components/date-time-native-control.vue | 6 ++-- ayanova/src/components/decimal-control.vue | 4 +-- ayanova/src/components/duration-control.vue | 7 ++--- ayanova/src/components/error-control.vue | 2 +- .../components/extension-delete-control.vue | 2 +- .../components/extension-export-control.vue | 2 +- .../src/components/extension-tags-control.vue | 2 +- ayanova/src/components/role-control.vue | 6 ++-- ayanova/src/components/time-control.vue | 8 ++--- .../src/components/time-native-control.vue | 7 ++--- ayanova/src/components/wiki-control.vue | 4 +-- ayanova/src/views/widget.vue | 2 +- ayanova/tests/e2e/plugins/index.js | 3 +- 24 files changed, 62 insertions(+), 67 deletions(-) diff --git a/ayanova/devdocs/todo.txt b/ayanova/devdocs/todo.txt index 50934520..5112d57b 100644 --- a/ayanova/devdocs/todo.txt +++ b/ayanova/devdocs/todo.txt @@ -10,16 +10,6 @@ MISC ITEMS THAT CAME UP ## CLIENT MISC ITEMS -todo: customer popup notes need to pop pop pop, forgot to code for that before - It's been requested for a couple of other places as well so I need a re-usable solution for this - maybe it requires dismissal rather than what I was thinking of which is a self closing alert as people may want to read it for a while. - However, I also find that incredibly annoying but I guess that's the point :) - -todo: vendor add popup notes and implement on form - case 3300 - -todo: if a menu item has no icon, can it be shown to the left and exclude the space taken up by the icon? - see CSR form for example todo: Date input shows higher than other components in forms date only input read only format see CSR form created field @@ -36,15 +26,14 @@ todo: Attachments button should indicate attachments: (Says add attachment when none) +todo: WHEN HAVE WORKORDER FORM customer popup notes need to pop pop pop, forgot to code for that before + It's been requested for a couple of other places as well so I need a re-usable solution for this + maybe it requires dismissal rather than what I was thinking of which is a self closing alert as people may want to read it for a while. + However, I also find that incredibly annoying but I guess that's the point :) + ## SERVER MISC ITEMS -todo: many biz objects are not using new PUT methodology - Might be because new methodology assumes complete PUT object as a entire replacement not a partial update - some of these objects (User) do partial updates so.... - also this includes *all* of the initial workorder object so there's that - might be that they don't need it but for consistency should check into it -todo: how to add locale keys in future after release without erasing all data? todo: userbiz validate can delete has funky error todo: bugbug filter on a phone number field results in error at server as unsupported type make sure all types are supported @@ -119,6 +108,14 @@ todo: actual customer reports so can figure out datalist for bringing other name todo: server boot up message should show the port it's listening on if possible or configured to listen on Users may well not know what port they are using and this will ease that greatly + +todo: many biz objects are not using new PUT methodology + Might be because new methodology assumes complete PUT object as a entire replacement not a partial update + some of these objects (User) do partial updates so.... + also this includes *all* of the initial workorder object so there's that + might be that they don't need it but for consistency should check into it + +todo: how to add locale keys in future after release without erasing all data? ######################################################################################################################## ######################################################################################################################## ######################################################################################################################## diff --git a/ayanova/src/App.vue b/ayanova/src/App.vue index 78f298ed..ac3c586f 100644 --- a/ayanova/src/App.vue +++ b/ayanova/src/App.vue @@ -381,7 +381,7 @@ export default { } }, props: { - source: String + source: { type: String, default: null } }, methods: { afterLeave() { diff --git a/ayanova/src/components/attachment-control.vue b/ayanova/src/components/attachment-control.vue index 36e534b2..01a00681 100644 --- a/ayanova/src/components/attachment-control.vue +++ b/ayanova/src/components/attachment-control.vue @@ -181,8 +181,8 @@ export default { }; }, props: { - ayaType: Number, - ayaId: Number, + ayaType: { type: Number, default: null }, + ayaId: { type: Number, default: null }, readonly: Boolean }, computed: {}, diff --git a/ayanova/src/components/currency-control.vue b/ayanova/src/components/currency-control.vue index a8703e79..8d99ff50 100644 --- a/ayanova/src/components/currency-control.vue +++ b/ayanova/src/components/currency-control.vue @@ -32,7 +32,7 @@ export default { }, props: { label: { type: String, default: null }, - rules: { type: Array, default: null }, + rules: { type: Array, default: undefined }, value: { type: Number, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, diff --git a/ayanova/src/components/dash-base.vue b/ayanova/src/components/dash-base.vue index 5b68237a..c56155a4 100644 --- a/ayanova/src/components/dash-base.vue +++ b/ayanova/src/components/dash-base.vue @@ -156,9 +156,9 @@ export default { type: String, required: true }, - title: String, + title: { type: String, default: null }, showMoreButton: { type: Boolean, default: false }, - addUrl: String, + addUrl: { type: String, default: null }, count: { type: Number, default: 0 }, updateFrequency: { type: Number, default: 60000 }, maxListItems: { type: Number, default: 10 }, diff --git a/ayanova/src/components/data-table-filter-control.vue b/ayanova/src/components/data-table-filter-control.vue index b7f90a04..991ce99d 100644 --- a/ayanova/src/components/data-table-filter-control.vue +++ b/ayanova/src/components/data-table-filter-control.vue @@ -355,8 +355,8 @@ export default { } }), props: { - dataListKey: String, - activeFilterId: Number + dataListKey: { type: String, default: null }, + activeFilterId: { type: Number, default: null } }, methods: { async saveAndExit() { diff --git a/ayanova/src/components/data-table-filter-manager-control.vue b/ayanova/src/components/data-table-filter-manager-control.vue index d59fb78e..562bb862 100644 --- a/ayanova/src/components/data-table-filter-manager-control.vue +++ b/ayanova/src/components/data-table-filter-manager-control.vue @@ -88,8 +88,8 @@ export default { } }), props: { - dataListKey: String, - activeFilterId: Number + dataListKey: { type: String, default: null }, + activeFilterId: { type: Number, default: null } }, methods: { async deleteFilter() { diff --git a/ayanova/src/components/data-table.vue b/ayanova/src/components/data-table.vue index 297f51ea..0918961a 100644 --- a/ayanova/src/components/data-table.vue +++ b/ayanova/src/components/data-table.vue @@ -437,8 +437,8 @@ export default { }; }, props: { - formKey: String, - dataListKey: String, + formKey: { type: String, default: null }, + dataListKey: { type: String, default: null }, clientCriteria: { type: String, default: undefined diff --git a/ayanova/src/components/date-control.vue b/ayanova/src/components/date-control.vue index 14efd672..eb8fdfd5 100644 --- a/ayanova/src/components/date-control.vue +++ b/ayanova/src/components/date-control.vue @@ -62,14 +62,13 @@ export default { defaultLocale: window.$gz.locale.getBrowserFirstLanguage().split("-", 1)[0] }), props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, value: { type: String, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, - - testId: String + testId: { type: String, default: null } }, computed: { hasErrors() { diff --git a/ayanova/src/components/date-native-control.vue b/ayanova/src/components/date-native-control.vue index 794909cf..07b8f84d 100644 --- a/ayanova/src/components/date-native-control.vue +++ b/ayanova/src/components/date-native-control.vue @@ -32,13 +32,13 @@ export default { }; }, props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, value: { type: String, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, - testId: String + testId: { type: String, default: null } }, computed: { dateValue() { diff --git a/ayanova/src/components/date-time-control.vue b/ayanova/src/components/date-time-control.vue index 5211aac0..1e95f0e3 100644 --- a/ayanova/src/components/date-time-control.vue +++ b/ayanova/src/components/date-time-control.vue @@ -101,13 +101,13 @@ export default { defaultLocale: window.$gz.locale.getBrowserFirstLanguage().split("-", 1)[0] }), props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, - value: String, + value: { type: String, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, - testId: String + testId: { type: String, default: null } }, computed: { hasErrors() { diff --git a/ayanova/src/components/date-time-native-control.vue b/ayanova/src/components/date-time-native-control.vue index 9cbe6f7b..b5c15177 100644 --- a/ayanova/src/components/date-time-native-control.vue +++ b/ayanova/src/components/date-time-native-control.vue @@ -47,13 +47,13 @@ export default { }, props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, value: { type: String, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, - testId: String + testId: { type: String, default: null } }, computed: { splitValue() { diff --git a/ayanova/src/components/decimal-control.vue b/ayanova/src/components/decimal-control.vue index 4701dab5..a3c57ed1 100644 --- a/ayanova/src/components/decimal-control.vue +++ b/ayanova/src/components/decimal-control.vue @@ -33,8 +33,8 @@ export default { }; }, props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, value: { type: Number, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, diff --git a/ayanova/src/components/duration-control.vue b/ayanova/src/components/duration-control.vue index 9c5c1e8c..cc42b04c 100644 --- a/ayanova/src/components/duration-control.vue +++ b/ayanova/src/components/duration-control.vue @@ -85,16 +85,15 @@ //{"data":{"testTSDaysWMS":"22.10:15:22.0330000","testTSHMS":"05:16:33","testTS_DHMS":"5.10:15:33","testTS_MS":"00:15:33","testTS_S":"00:00:33","testTS_D":"22.00:00:00"}} export default { props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, value: { type: String, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, - showSeconds: { type: Boolean, default: true }, showDays: { type: Boolean, default: true }, - testId: String + testId: { type: String, default: null } }, computed: { hasErrors() { diff --git a/ayanova/src/components/error-control.vue b/ayanova/src/components/error-control.vue index d04af9da..9d4ce765 100644 --- a/ayanova/src/components/error-control.vue +++ b/ayanova/src/components/error-control.vue @@ -17,7 +17,7 @@ export default { data: () => ({}), props: { - errorBoxMessage: String + errorBoxMessage: { type: String, default: null } } }; diff --git a/ayanova/src/components/extension-delete-control.vue b/ayanova/src/components/extension-delete-control.vue index 3c12daa9..5ee270ee 100644 --- a/ayanova/src/components/extension-delete-control.vue +++ b/ayanova/src/components/extension-delete-control.vue @@ -121,7 +121,7 @@ export default { } }, props: { - dataListSelection: Object + dataListSelection: { type: Object, default: null } } }; diff --git a/ayanova/src/components/extension-export-control.vue b/ayanova/src/components/extension-export-control.vue index 3cc377da..c00a7bf6 100644 --- a/ayanova/src/components/extension-export-control.vue +++ b/ayanova/src/components/extension-export-control.vue @@ -61,7 +61,7 @@ export default { } }, props: { - dataListSelection: Object + dataListSelection: { type: Object, default: null } } }; diff --git a/ayanova/src/components/extension-tags-control.vue b/ayanova/src/components/extension-tags-control.vue index 17ffd22f..7e9d20f1 100644 --- a/ayanova/src/components/extension-tags-control.vue +++ b/ayanova/src/components/extension-tags-control.vue @@ -173,7 +173,7 @@ export default { } }, props: { - dataListSelection: Object + dataListSelection: { type: Object, default: null } } }; diff --git a/ayanova/src/components/role-control.vue b/ayanova/src/components/role-control.vue index 2a31aef6..d2f1b692 100644 --- a/ayanova/src/components/role-control.vue +++ b/ayanova/src/components/role-control.vue @@ -44,14 +44,14 @@ export default { }; }, props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, value: { type: Number, default: 0 }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, limitSelectionTo: { type: String, default: null }, //"inside" - no customer roles, "outside" - no non-customer roles - testId: String + testId: { type: String, default: null } }, computed: { selectedValue() { diff --git a/ayanova/src/components/time-control.vue b/ayanova/src/components/time-control.vue index 4fc24c5e..2fcaa5b0 100644 --- a/ayanova/src/components/time-control.vue +++ b/ayanova/src/components/time-control.vue @@ -68,13 +68,13 @@ export default { defaultLocale: window.$gz.locale.getBrowserFirstLanguage().split("-", 1)[0] }), props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, - value: String, + value: { type: String, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, - testId: String + testId: { type: String, default: null } }, computed: { hasErrors() { diff --git a/ayanova/src/components/time-native-control.vue b/ayanova/src/components/time-native-control.vue index 471be09f..8d6ccbd0 100644 --- a/ayanova/src/components/time-native-control.vue +++ b/ayanova/src/components/time-native-control.vue @@ -35,14 +35,13 @@ export default { }, props: { - label: String, - rules: Array, + label: { type: String, default: null }, + rules: { type: Array, default: undefined}, errorMessages: { type: Array, default: null }, value: { type: String, default: null }, readonly: { type: Boolean, default: false }, disabled: { type: Boolean, default: false }, - - testId: String + testId: { type: String, default: null } }, computed: { timeValue() { diff --git a/ayanova/src/components/wiki-control.vue b/ayanova/src/components/wiki-control.vue index c44b170f..2a03b4f1 100644 --- a/ayanova/src/components/wiki-control.vue +++ b/ayanova/src/components/wiki-control.vue @@ -392,8 +392,8 @@ export default { }, props: { value: { type: String, default: "" }, - ayaType: Number, - ayaId: Number, + ayaType: { type: Number, default: null }, + ayaId: { type: Number, default: null }, readonly: Boolean }, watch: { diff --git a/ayanova/src/views/widget.vue b/ayanova/src/views/widget.vue index 48aa4b81..89981c8f 100644 --- a/ayanova/src/views/widget.vue +++ b/ayanova/src/views/widget.vue @@ -319,7 +319,7 @@ export default { name: null, serial: 0, dollarAmount: null, - active: null, + active: true, userType: 2, //defaulted here to something valid startDate: null, endDate: null, diff --git a/ayanova/tests/e2e/plugins/index.js b/ayanova/tests/e2e/plugins/index.js index 0f8ca22a..db94ea70 100644 --- a/ayanova/tests/e2e/plugins/index.js +++ b/ayanova/tests/e2e/plugins/index.js @@ -1,5 +1,6 @@ // https://docs.cypress.io/guides/guides/plugins-guide.html -/* eslint-disable import/no-extraneous-dependencies, global-require */ +/* esXXXXXlint-disable import/no-extraneous-dependencies, global-require */ +/* eslint-disable global-require */ const webpack = require("@cypress/webpack-preprocessor"); module.exports = (on, config) => {